yiguolei commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1378901154
##########
be/src/vec/data_types/get_least_supertype.cpp:
##########
@@ -149,16 +161,16 @@ void get_numeric_type(const TypeIndexSet& types,
DataTypePtr* type, bool compati
*type = std::make_shared<DataTypeFloat64>();
return;
} else {
- LOG(INFO) << " because some of them are integers and some are
floating point "
- "but there is no floating point type, that can
exactly represent "
- "all required integers";
+ VLOG_DEBUG << " because some of them are integers and some are
floating point "
Review Comment:
可能需要把variant 相关的类型推导，统一放个地方啊
##########
be/src/vec/data_types/get_least_supertype.cpp:
##########
@@ -149,16 +161,16 @@ void get_numeric_type(const TypeIndexSet& types,
DataTypePtr* type, bool compati
*type = std::make_shared<DataTypeFloat64>();
return;
} else {
- LOG(INFO) << " because some of them are integers and some are
floating point "
- "but there is no floating point type, that can
exactly represent "
- "all required integers";
+ VLOG_DEBUG << " because some of them are integers and some are
floating point "
Review Comment:
可能需要把variant 相关的类型推导，统一放个地方啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
