[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r531491646



##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/LoadChecker.java
##########
@@ -565,18 +568,14 @@ private void runOneQuorumFinishedDeleteJob(AsyncDeleteJob 
job) {
             load.removeDeleteJobAndSetState(job);
             return;
         }
-        db.readLock();
-        try {
-            // if the delete job is quorum finished, just set it to finished
-            job.clearTasks();
-            job.setState(DeleteState.FINISHED);
-            // log
-            Catalog.getCurrentCatalog().getEditLog().logFinishAsyncDelete(job);
-            load.removeDeleteJobAndSetState(job);
-            LOG.info("delete job {} finished", job.getJobId());
-        } finally {
-            db.readUnlock();
-        }
+
+        // if the delete job is quorum finished, just set it to finished
+        job.clearTasks();

Review comment:
       I cannot find the suitable lock to protect this part




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org