caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r531485398
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadPendingTask.java
##########
@@ -133,13 +136,18 @@ private void createEtlJobConf() throws LoadException {
}
Map<Long, EtlTable> tables = Maps.newHashMap();
- db.readLock();
+ Map<Long, Set<Long>> tableIdToPartitionIds = Maps.newHashMap();
+ Set<Long> allPartitionsTableIds = Sets.newHashSet();
+ prepareTablePartitionInfos(db, tableIdToPartitionIds,
allPartitionsTableIds);
Review comment:
I think it doesn't matter? if i modify table meta or drop table after db
read lock, the final result is still same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
