[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r531466818



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
##########
@@ -894,18 +893,8 @@ public long getBackendReportVersion(long backendId) {
     public void updateBackendReportVersion(long backendId, long 
newReportVersion, long dbId) {
         AtomicLong atomicLong = null;
         if ((atomicLong = idToReportVersionRef.get(backendId)) != null) {
-            Database db = Catalog.getCurrentCatalog().getDb(dbId);
-            if (db != null) {
-                db.readLock();
-                try {
-                    atomicLong.set(newReportVersion);
-                    LOG.debug("update backend {} report version: {}, db: {}", 
backendId, newReportVersion, dbId);
-                } finally {
-                    db.readUnlock();
-                }
-            } else {
-                LOG.warn("failed to update backend report version, db {} does 
not exist", dbId);
-            }
+            atomicLong.set(newReportVersion);

Review comment:
       atomicLong is AtomicLong,so I think it is meanless for add table lock or 
db lock?

##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/task/HadoopLoadPendingTask.java
##########
@@ -70,41 +70,41 @@ public HadoopLoadPendingTask(LoadJob job) {
 
     @Override
     protected void createEtlRequest() throws Exception {
-        db.readLock();
-        try {
-            EtlTaskConf taskConf = new EtlTaskConf();
-            // output path
-            taskConf.setOutputPath(getOutputPath());
-            // output file pattern
-            taskConf.setOutputFilePattern(job.getLabel() + 
".%(table)s.%(view)s.%(bucket)s");
-            // tables (partitions)
-            Map<String, EtlPartitionConf> etlPartitions = 
createEtlPartitions();
-            Preconditions.checkNotNull(etlPartitions);
-            taskConf.setEtlPartitions(etlPartitions);
+        EtlTaskConf taskConf = new EtlTaskConf();

Review comment:
       add table lock in createEtlPartitions




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org