[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r536084860



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##########
@@ -265,17 +265,16 @@ private void executeDynamicPartition() {
             String tableName;
             boolean skipAddPartition = false;
             OlapTable olapTable;
-            db.readLock();
+            olapTable = (OlapTable) db.getTable(tableId);

Review comment:
       Another consideration is to avoid deadlock， all lock sequence is db lock 
-> table lock -> other lock, and if we has get table lock and sometimes need to 
get table again from db, there may cause dead lock, so db get table operation 
not get db read lock anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org