[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r531470831



##########
File path: fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
##########
@@ -664,18 +667,25 @@ private void checkAndPrepareMeta() {
                                 remoteDataProperty, (short) 
restoreReplicationNum,
                                 
remotePartitionInfo.getIsInMemory(remotePartId));
                         localTbl.addPartition(restoredPart);
+                    } finally {
+                        localTbl.writeUnlock();
                     }
 
-                    // add restored tables
-                    for (OlapTable tbl : restoredTbls) {
+                }
+
+                // add restored tables
+                for (OlapTable tbl : restoredTbls) {
+                    db.writeLock();
+                    try {

Review comment:
       use this function use cause side effect that edit log write create table 
info.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org