yiguolei commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1322676069
##########
be/src/runtime/memory/cache_manager.h:
##########
@@ -25,12 +26,12 @@ namespace doris {
// Hold the list of all caches, for prune when memory not enough or timing.
class CacheManager {
public:
- static void create_global_instance() {
- DCHECK(_s_instance == nullptr);
- static CacheManager instance;
- _s_instance = &instance;
+ static CacheManager* create_global_instance() {
+ DCHECK(ExecEnv::GetInstance()->get_cache_manager() == nullptr);
Review Comment:
not need this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
