github-actions[bot] commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1322858568
##########
be/test/runtime/external_scan_context_mgr_test.cpp:
##########
@@ -38,13 +38,11 @@ class ExternalScanContextMgrTest : public testing::Test {
_exec_env._fragment_mgr = fragment_mgr;
_exec_env._result_queue_mgr = result_queue_mgr;
}
- virtual ~ExternalScanContextMgrTest() {
- delete _exec_env._fragment_mgr;
- delete _exec_env._result_queue_mgr;
- }
+ virtual ~ExternalScanContextMgrTest() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~ExternalScanContextMgrTest() = default;
```
##########
be/test/runtime/external_scan_context_mgr_test.cpp:
##########
@@ -38,13 +38,11 @@ class ExternalScanContextMgrTest : public testing::Test {
_exec_env._fragment_mgr = fragment_mgr;
_exec_env._result_queue_mgr = result_queue_mgr;
}
- virtual ~ExternalScanContextMgrTest() {
- delete _exec_env._fragment_mgr;
- delete _exec_env._result_queue_mgr;
- }
+ virtual ~ExternalScanContextMgrTest() {}
protected:
virtual void SetUp() {}
+ virtual void TearDown() { _exec_env.destroy(); }
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
void TearDown() override { _exec_env.destroy(); }
```
##########
be/test/runtime/external_scan_context_mgr_test.cpp:
##########
@@ -38,13 +38,11 @@ class ExternalScanContextMgrTest : public testing::Test {
_exec_env._fragment_mgr = fragment_mgr;
_exec_env._result_queue_mgr = result_queue_mgr;
}
- virtual ~ExternalScanContextMgrTest() {
- delete _exec_env._fragment_mgr;
- delete _exec_env._result_queue_mgr;
- }
+ virtual ~ExternalScanContextMgrTest() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~ExternalScanContextMgrTest() override {}
```
##########
be/test/runtime/routine_load_task_executor_test.cpp:
##########
@@ -92,29 +93,31 @@ TEST_F(RoutineLoadTaskExecutorTest, exec_task) {
task.__set_kafka_load_info(k_info);
- RoutineLoadTaskExecutor executor(&_env);
+ RoutineLoadTaskExecutor* executor = new
RoutineLoadTaskExecutor(ExecEnv::GetInstance());
Review Comment:
warning: variable 'executor' is not initialized
[cppcoreguidelines-init-variables]
```suggestion
RoutineLoadTaskExecutor* executor = nullptr = new
RoutineLoadTaskExecutor(ExecEnv::GetInstance());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
