zhiqiang-hhhh commented on code in PR #24029: URL: https://github.com/apache/doris/pull/24029#discussion_r1322682789
########## be/src/runtime/exec_env.h: ########## @@ -305,4 +368,28 @@ ExecEnv::get_client_cache<TPaloBrokerServiceClient>() { return _broker_client_cache; } +inline TabletSchemaCache* GetGlobalTabletSchemaCache() { + return ExecEnv::GetInstance()->get_tablet_schema_cache(); +} + +inline io::S3FileBufferPool* GetGlobalS3FileBufferPool() { + return ExecEnv::GetInstance()->get_s3_file_buffer_pool(); +} + +inline StorageEngine* GetGlobalStorageEngine() { Review Comment: Agree. May be we should also unify access method to ExecEnv? I do not think other class has any necessity to hold a raw pointer to ExecEnv instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org