yiguolei commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1322666592
##########
be/src/olap/tablet_schema_cache.h:
##########
@@ -32,19 +33,18 @@ class TabletSchemaCache {
public:
~TabletSchemaCache();
- static void create_global_schema_cache() {
- DCHECK(_s_instance == nullptr);
- static TabletSchemaCache instance;
- _s_instance = &instance;
- std::thread t(&TabletSchemaCache::_recycle, _s_instance);
+ static TabletSchemaCache* create_global_schema_cache() {
Review Comment:
We'd better add a seperate shutdown method for this class and add a start
method to start the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
