github-actions[bot] commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1323090700
##########
be/test/runtime/external_scan_context_mgr_test.cpp:
##########
@@ -38,13 +38,11 @@ class ExternalScanContextMgrTest : public testing::Test {
_exec_env._fragment_mgr = fragment_mgr;
_exec_env._result_queue_mgr = result_queue_mgr;
}
- virtual ~ExternalScanContextMgrTest() {
- delete _exec_env._fragment_mgr;
- delete _exec_env._result_queue_mgr;
- }
+ ~ExternalScanContextMgrTest() = default;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~ExternalScanContextMgrTest() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
