gaodayue commented on a change in pull request #3025: Restructure storage type to support complex types expending URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r394095206
########## File path: be/src/olap/column_vector.h ########## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "common/status.h" +#include "olap/olap_common.h" +#include "olap/rowset/segment_v2/common.h" // for ordinal_t +#include "olap/types.h" + +namespace doris { + +// struct that contains column data(null bitmap), data array in sub class. +struct ColumnVectorBatch { +public: + explicit ColumnVectorBatch(const TypeInfo* type_info, bool is_nullable) + : _type_info(type_info), _capacity(0), _nullable(is_nullable) {} + + virtual ~ColumnVectorBatch(); + + const TypeInfo* type_info() const { return _type_info; } + + size_t get_capacity() { return _capacity; } Review comment: ```suggestion size_t capacity() const { return _capacity; } ``` For accessor methods, we don't use "get_" in name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
