gaodayue commented on a change in pull request #3025: Restructure storage type
to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r395095068
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -151,6 +151,12 @@ message ColumnMetaPB {
repeated ColumnIndexMetaPB indexes = 8;
// pointer to dictionary page when using DICT_ENCODING
optional PagePointerPB dict_page = 9;
+
+ repeated ColumnMetaPB children_columns = 10;
+ repeated string children_clolumn_names = 11;
+
+ // required
+ optional uint64 num_rows = 12;
Review comment:
Add a comment about why we need this. In addition, perhaps num_values is
better name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
