gaodayue commented on a change in pull request #3025: Restructure storage type
to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r394137314
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -94,19 +98,46 @@ class ColumnWriter {
Status append_nulls(size_t num_rows);
Status append(const void* data, size_t num_rows);
Status append_nullable(const uint8_t* nullmap, const void* data, size_t
num_rows);
+ Status append_nullable_by_null_signs(const bool* null_signs, const void*
data, size_t num_rows);
Review comment:
There are too many variants of append methods, which is difficult to use and
adds maintenance cost. Since SegmentWriter currently only supports single row
insert API, can you unify the append methods of ColumnWriter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
