gaodayue commented on a change in pull request #3025: Restructure storage type
to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r395127606
##########
File path: be/src/olap/rowset/segment_v2/column_reader.h
##########
@@ -187,6 +196,25 @@ class ColumnReader {
std::unique_ptr<BloomFilterIndexReader> _bloom_filter_index;
};
+class ArrayColumnReader : public ColumnReader {
Review comment:
It's a bad class design to make ArrayColumnReader directly inheriting from
ColumnReader. You'd better start with a ColumnReader interface and design
ScalarColumnReader and ArrayColumnReader separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
