gaodayue commented on a change in pull request #3025: Restructure storage type
to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r395066907
##########
File path: be/src/olap/row_block2.cpp
##########
@@ -63,7 +54,7 @@ Status RowBlockV2::convert_to_row_block(RowCursor* helper,
RowBlock* dst) {
for (uint16_t i = 0; i < _selected_size; ++i) {
uint16_t row_idx = _selection_vector[i];
dst->get_row(i, helper);
- bool is_null = BitmapTest(_column_null_bitmaps[cid], row_idx);
+ bool is_null = column_block(cid).is_null(row_idx);
Review comment:
You create too many calls of `column_block(cid)` which will hurt performance
because each invocation will create a ColumnBlock object. Better to get
`ColumnVectorBatch*` before the for loop and use that pointer to do the work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
