[ovmf test] 172126: all pass - PUSHED

2022-08-03 Thread osstest service owner
flight 172126 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172126/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d2191197217f9d16541c2d051235c494fa80bce3 baseline version: ovmf 0dc9b78a46813d61533b2

[linux-linus test] 172111: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172111 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 172093 build-amd64-xsm

[xen-4.16-testing test] 172110: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172110 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/172110/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 171881 test-amd64-i38

[linux-5.4 test] 172108: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172108 linux-5.4 real [real] flight 172127 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172108/ http://logs.test-lab.xenproject.org/osstest/logs/172127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

[xen-4.15-testing test] 172109: tolerable FAIL - PUSHED

2022-08-03 Thread osstest service owner
flight 172109 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/172109/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 171880 test-armhf-armhf-libvirt 16

Re: preparations for 4.16.2

2022-08-03 Thread Stefano Stabellini
On Wed, 3 Aug 2022, Jan Beulich wrote: > On 03.08.2022 11:29, Julien Grall wrote: > > On 27/07/2022 08:26, Jan Beulich wrote: > >> All, > > > > Hi Jan, > > > >> the release is due in about two weeks time. > >> > >> Please point out backports you find missing from the respective staging > >> branc

Re: [PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation

2022-08-03 Thread Stefano Stabellini
On Wed, 3 Aug 2022, Xenia Ragiadakou wrote: > The macro parameters 'off' and 'uart' are used as expressions and it is > good to be enclosed in parentheses to prevent against unintended expansion. > > For the 'uart' case, in mvebu3700_write(), correct the second parentheses > that seems to have bee

Re: [PATCH] doc: Add git commands to generate Fixes

2022-08-03 Thread Stefano Stabellini
On Wed, 3 Aug 2022, Bertrand Marquis wrote: > Add git commands examples that can be used to generate fixes and how to > use the pretty configuration for git. > This should make it easier for contributors to have the right format. > > Signed-off-by: Bertrand Marquis Acked-by: Stefano Stabellini

[xen-unstable bisection] complete build-arm64-libvirt

2022-08-03 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-arm64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git

[qemu-mainline test] 172103: tolerable FAIL - PUSHED

2022-08-03 Thread osstest service owner
flight 172103 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 172087 test-amd64-amd64-qemuu-nested-amd 2

Re: [PATCH v1 4/7] tools/ocaml: Makefile to drive dune

2022-08-03 Thread Anthony PERARD
On Wed, Aug 03, 2022 at 03:37:19PM +, Edwin Torok wrote: > > On 3 Aug 2022, at 14:46, Anthony PERARD wrote: > > On Fri, Jul 29, 2022 at 06:53:27PM +0100, Edwin Török wrote: > >> +.PHONY: build-tools-oxenstored-prepare > >> +build-tools-oxenstored-prepare: build-tools-public-headers > >> + tes

[xen-unstable test] 172104: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172104 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172104/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172073 build-amd64-libvir

Re: [PATCH v11] xsm: refactor flask sid alloc and domain check

2022-08-03 Thread Daniel P. Smith
On 8/3/22 11:26, Jan Beulich wrote: > On 03.08.2022 17:17, Daniel P. Smith wrote: >> Changes in v11: >> - put back dom0_created variable in flask_domain_create() to ensure the >> enforcement that dom0_t is a singleton label > > Stale patch or bad rev log? Nope, having a bad day. Staged the chan

[xen-unstable-smoke test] 172116: tolerable FAIL - PUSHED

2022-08-03 Thread osstest service owner
flight 172116 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

Re: [PATCH v1 4/7] tools/ocaml: Makefile to drive dune

2022-08-03 Thread Edwin Torok
> On 3 Aug 2022, at 14:46, Anthony PERARD wrote: > > On Fri, Jul 29, 2022 at 06:53:27PM +0100, Edwin Török wrote: >> create a separate Makefile that can be used to drive dune. >> >> Usage: >> `make -f Makefile.dune` >> >> There are some files that need to be created by the Makefile based >> b

Re: [PATCH v11] xsm: refactor flask sid alloc and domain check

2022-08-03 Thread Jan Beulich
On 03.08.2022 17:17, Daniel P. Smith wrote: > Changes in v11: > - put back dom0_created variable in flask_domain_create() to ensure the > enforcement that dom0_t is a singleton label Stale patch or bad rev log? > @@ -548,22 +556,19 @@ static int cf_check flask_domain_create(struct domain > *d,

[PATCH v11] xsm: refactor flask sid alloc and domain check

2022-08-03 Thread Daniel P. Smith
The function flask_domain_alloc_security() allocates the security context and assigns an initial SID for the domain under construction. When it came to SID assignment of the initial domain, flask_domain_alloc_security() would assign unlabeled_t. Then in flask_domain_create() it would be switched to

[PATCH] doc: Add git commands to generate Fixes

2022-08-03 Thread Bertrand Marquis
Add git commands examples that can be used to generate fixes and how to use the pretty configuration for git. This should make it easier for contributors to have the right format. Signed-off-by: Bertrand Marquis --- docs/process/sending-patches.pandoc | 4 1 file changed, 4 insertions(+) d

Re: [PATCH V7 01/11] xen/pci: arm: add stub for is_memory_hole

2022-08-03 Thread Oleksandr
On 03.08.22 12:29, Rahul Singh wrote: Hi Oleksandr, Hello Rahul On 29 Jul 2022, at 5:28 pm, Oleksandr wrote: Hello Rahul On 19.07.22 20:42, Oleksandr Tyshchenko wrote: From: Oleksandr Andrushchenko Add a stub for is_memory_hole which is required for PCI passthrough on Arm. Sign

Re: [XEN PATCH v2 4/4] build: replace get-fields.sh by a perl script

2022-08-03 Thread Jan Beulich
On 03.08.2022 15:27, Anthony PERARD wrote: > On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote: >> The get-fields.sh which generate all the include/compat/.xlat/*.h >> headers is quite slow. It takes for example nearly 3 seconds to >> generate platform.h on a recent machine, or 2.3 sec

Re: [PATCH v1 4/7] tools/ocaml: Makefile to drive dune

2022-08-03 Thread Anthony PERARD
On Fri, Jul 29, 2022 at 06:53:27PM +0100, Edwin Török wrote: > create a separate Makefile that can be used to drive dune. > > Usage: > `make -f Makefile.dune` > > There are some files that need to be created by the Makefile based > build system (such as all the C code in $(XEN_ROOT)/tools/libs),

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Bertrand Marquis
> On 3 Aug 2022, at 14:01, Julien Grall wrote: > > Hi Bertrand, > > On 03/08/2022 13:56, Bertrand Marquis wrote: >>> On 3 Aug 2022, at 13:55, Bertrand Marquis wrote: >>> >>> >>> On 3 Aug 2022, at 13:10, Julien Grall wrote: Hi, On 03/08/2022 13:05, Jan Beulich wr

Re: [XEN PATCH v2 4/4] build: replace get-fields.sh by a perl script

2022-08-03 Thread Anthony PERARD
On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote: > The get-fields.sh which generate all the include/compat/.xlat/*.h > headers is quite slow. It takes for example nearly 3 seconds to > generate platform.h on a recent machine, or 2.3 seconds for memory.h. > > Since it's only text pro

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Julien Grall
Hi Bertrand, On 03/08/2022 13:56, Bertrand Marquis wrote: On 3 Aug 2022, at 13:55, Bertrand Marquis wrote: On 3 Aug 2022, at 13:10, Julien Grall wrote: Hi, On 03/08/2022 13:05, Jan Beulich wrote: On 03.08.2022 13:57, Bertrand Marquis wrote: When calling python tools to convert misra

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Bertrand Marquis
> On 3 Aug 2022, at 13:55, Bertrand Marquis wrote: > > > >> On 3 Aug 2022, at 13:10, Julien Grall wrote: >> >> Hi, >> >> On 03/08/2022 13:05, Jan Beulich wrote: >>> On 03.08.2022 13:57, Bertrand Marquis wrote: When calling python tools to convert misra documentation or merge cppc

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Bertrand Marquis
> On 3 Aug 2022, at 13:10, Julien Grall wrote: > > Hi, > > On 03/08/2022 13:05, Jan Beulich wrote: >> On 03.08.2022 13:57, Bertrand Marquis wrote: >>> When calling python tools to convert misra documentation or merge >>> cppcheck xml files, use $(PYTHON). >>> While there fix misra document con

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Bertrand Marquis
> On 3 Aug 2022, at 13:05, Jan Beulich wrote: > > On 03.08.2022 13:57, Bertrand Marquis wrote: >> When calling python tools to convert misra documentation or merge >> cppcheck xml files, use $(PYTHON). >> While there fix misra document conversion script to be executable. >> >> Fixes: 57caa537

[xen-unstable-smoke test] 172107: tolerable FAIL - PUSHED

2022-08-03 Thread osstest service owner
flight 172107 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6 lib

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Anthony PERARD
On Wed, Aug 03, 2022 at 01:58:34PM +0200, Jan Beulich wrote: > On 03.08.2022 12:57, Anthony PERARD wrote: > > On Wed, Aug 03, 2022 at 10:24:26AM +, Edwin Torok wrote: > >> > >> -ifneq ($(MAKECMDGOALS),clean) > >> +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > > > > I think it would be better w

Re: [PATCH v1 3/7] tools/ocaml/*/dune: dune based build system

2022-08-03 Thread Christian Lindig
On 3 Aug 2022, at 12:25, Anthony PERARD mailto:[email protected]>> wrote: On Fri, Jul 29, 2022 at 06:53:26PM +0100, Edwin Török wrote: Based on Christian Lindig's work. Should we have is "Signed-off-by" tag then? Also he might be the author of the patch, isn't it? This only refers to

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Jan Beulich
On 03.08.2022 14:10, Julien Grall wrote: > On 03/08/2022 13:05, Jan Beulich wrote: >> On 03.08.2022 13:57, Bertrand Marquis wrote: >>> When calling python tools to convert misra documentation or merge >>> cppcheck xml files, use $(PYTHON). >>> While there fix misra document conversion script to be

Re: [xen-unstable test] 172089: regressions - FAIL

2022-08-03 Thread Jan Beulich
On 03.08.2022 14:02, Julien Grall wrote: > On 03/08/2022 08:13, osstest service owner wrote: >> flight 172089 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/172089/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could

[libvirt test] 172095: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172095 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172095/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Julien Grall
Hi, On 03/08/2022 13:05, Jan Beulich wrote: On 03.08.2022 13:57, Bertrand Marquis wrote: When calling python tools to convert misra documentation or merge cppcheck xml files, use $(PYTHON). While there fix misra document conversion script to be executable. Fixes: 57caa53753 (xen: Add MISRA sup

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Jan Beulich
On 03.08.2022 13:57, Bertrand Marquis wrote: > When calling python tools to convert misra documentation or merge > cppcheck xml files, use $(PYTHON). > While there fix misra document conversion script to be executable. > > Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) > Fixes: 4

Re: [xen-unstable test] 172089: regressions - FAIL

2022-08-03 Thread Julien Grall
Hi, On 03/08/2022 08:13, osstest service owner wrote: flight 172089 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172089/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-

[PATCH v3 2/5] tools/xenstore: add documentation for new set/get-feature commands

2022-08-03 Thread Juergen Gross
Add documentation for two new Xenstore wire commands SET_FEATURE and GET_FEATURE used to set or query the Xenstore features visible in the ring page of a given domain. Signed-off-by: Juergen Gross --- V2: - remove feature bit (Julien Grall) - GET_FEATURE without domid will return Xenstore support

[PATCH v3 5/5] tools/xenstore: add migration stream extensions for new features

2022-08-03 Thread Juergen Gross
Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain quota Signed-off-by: Juergen Gross --- V3: - new patch --- docs/designs/xenstore-migration.md | 85 -- 1 file changed, 82

[PATCH v3 3/5] tools/xenstore: add documentation for new set/get-quota commands

2022-08-03 Thread Juergen Gross
Add documentation for two new Xenstore wire commands SET_QUOTA and GET_QUOTA used to set or query the global Xenstore quota or those of a given domain. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V2: - remove feature bit (Julien Grall) - add possibility to access global quota and

[PATCH v3 1/5] tools/xenstore: minor fix of the migration stream doc

2022-08-03 Thread Juergen Gross
Drop mentioning the non-existent read-only socket in the migration stream description document. Signed-off-by: Juergen Gross --- V3: - new patch --- docs/designs/xenstore-migration.md | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/designs/xenstore-migration.md

[PATCH v3 0/5] tools/xenstore: add some new features to the documentation

2022-08-03 Thread Juergen Gross
In the past there have been spotted some shortcomings in the Xenstore interface, which should be repaired. Those are in detail: - Using driver domains for large number of domains needs per domain Xenstore quota [1]. The feedback sent was rather slim (one reply), but it was preferring a new set

[PATCH v3 4/5] tools/xenstore: add documentation for extended watch command

2022-08-03 Thread Juergen Gross
Add documentation for an extension of the WATCH command used to limit the scope of watched paths. Additionally it enables to receive more information in the events related to special watches (@introduceDomain or @releaseDomain). Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- docs/mi

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Jan Beulich
On 03.08.2022 12:57, Anthony PERARD wrote: > On Wed, Aug 03, 2022 at 10:24:26AM +, Edwin Torok wrote: >> >> -ifneq ($(MAKECMDGOALS),clean) >> +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > > I think it would be better with $(filter-out,): > > ifeq (,$(filter-out %clean,$(MAKECMDGOALS))) >

[PATCH v2] tools: use $(PYTHON) to call cppcheck tools

2022-08-03 Thread Bertrand Marquis
When calling python tools to convert misra documentation or merge cppcheck xml files, use $(PYTHON). While there fix misra document conversion script to be executable. Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make

Re: [PATCH v1 3/7] tools/ocaml/*/dune: dune based build system

2022-08-03 Thread Anthony PERARD
On Fri, Jul 29, 2022 at 06:53:26PM +0100, Edwin Török wrote: > Based on Christian Lindig's work. Should we have is "Signed-off-by" tag then? Also he might be the author of the patch, isn't it? > Initially this will be used to build unit tests, and to make development > easier. > > Dune supports p

[linux-linus test] 172093: tolerable FAIL - PUSHED

2022-08-03 Thread osstest service owner
flight 172093 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172093/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 172084 test-armhf-armhf-libvirt 16 saver

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Anthony PERARD
On Wed, Aug 03, 2022 at 10:24:26AM +, Edwin Torok wrote: > > -ifneq ($(MAKECMDGOALS),clean) > +ifeq (,$(findstring clean,$(MAKECMDGOALS))) I think it would be better with $(filter-out,): ifeq (,$(filter-out %clean,$(MAKECMDGOALS))) > .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile >

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Jan Beulich
On 03.08.2022 12:24, Edwin Torok wrote: > > >> On 3 Aug 2022, at 11:16, Jan Beulich wrote: >> >> On 29.07.2022 19:53, Edwin Török wrote: >>> Trying to include .ocamldep.make will cause it to be generated if it >>> doesn't exist. >>> We do not want this during make clean: we would remove it anywa

Re: [PATCH v1 5/7] tools/ocaml: fix compiler warnings

2022-08-03 Thread Christian Lindig
On 3 Aug 2022, at 11:39, Andrew Cooper mailto:[email protected]>> wrote: There are no side effects here. Can't the line simply be deleted? Yes. The compiler tells us about unused bindings like these and this is the easy way to acknowledge this without removing the code but it could b

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Edwin Torok
> On 3 Aug 2022, at 11:16, Jan Beulich wrote: > > On 29.07.2022 19:53, Edwin Török wrote: >> Trying to include .ocamldep.make will cause it to be generated if it >> doesn't exist. >> We do not want this during make clean: we would remove it anyway. >> >> Speeds up make clean. >> >> Before (me

Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean

2022-08-03 Thread Jan Beulich
On 29.07.2022 19:53, Edwin Török wrote: > Trying to include .ocamldep.make will cause it to be generated if it > doesn't exist. > We do not want this during make clean: we would remove it anyway. > > Speeds up make clean. > > Before (measured on f732240fd3bac25116151db5ddeb7203b62e85ce, July 2022

Re: [XEN PATCH v3 06/25] tools/fuzz/x86_instruction_emulator: rework makefile

2022-08-03 Thread Anthony PERARD
On Wed, Aug 03, 2022 at 07:56:34AM +0200, Jan Beulich wrote: > On 02.08.2022 19:09, Anthony PERARD wrote: > > On Mon, Jul 11, 2022 at 04:08:55PM +0200, Jan Beulich wrote: > >> Can you confirm things to work when > >> building locally in just this subdir, e.g. via > >> > >> make -sC .../tools/fuzz/x

Re: [PATCH v2 0/2] xen: credit2: fix boot hangs if dom0_nodes is used

2022-08-03 Thread Jan Beulich
On 03.08.2022 11:58, Dario Faggioli wrote: > Take 2 of this series. I think I've addressed Jan's comments. v1 was > Message-id: <[email protected]> > > Currently, if the dom0_nodes parameter is used, to limit the hard or > soft affinity of dom0's vCPUs

Re: [PATCH 1/2] xen: sched: dom0_vcpus_pin should only affect dom0

2022-08-03 Thread Dario Faggioli
On Wed, 2022-08-03 at 08:19 +0200, Jan Beulich wrote: > On 02.08.2022 18:08, Dario Faggioli wrote: > > > ... for it to be strictly only Dom0, you want to check d- > > > >domain_id > > > here. > > > > > Ok, I'll send an update that does that. > > Well - if you agree, I'd be happy to make the chang

[PATCH v2 2/2] xen/sched: setup dom0 vCPUs affinity only once

2022-08-03 Thread Dario Faggioli
Right now, affinity for dom0 vCPUs is setup in two steps. This is a problem as, at least in Credit2, unit_insert() sees and uses the "intermediate" affinity, and place the vCPUs on CPUs where they cannot be run. And this in turn results in boot hangs, if the "dom0_nodes" parameter is used. Fix thi

[PATCH v2 1/2] xen: sched: dom0_vcpus_pin should only affect dom0

2022-08-03 Thread Dario Faggioli
If dom0_vcpus_pin is used, make sure the pinning is only done for dom0 vcpus, instead of for the hardware domain (which might not be dom0 at all!). Suggested-by: Jan Beulich Signed-off-by: Dario Faggioli Reviewed-by: Jan Beulich --- Cc: George Dunlap --- Changes from v1: - check domain_id to b

[PATCH v2 0/2] xen: credit2: fix boot hangs if dom0_nodes is used

2022-08-03 Thread Dario Faggioli
Take 2 of this series. I think I've addressed Jan's comments. v1 was Message-id: <[email protected]> Currently, if the dom0_nodes parameter is used, to limit the hard or soft affinity of dom0's vCPUs, the boot hangs. This is because the vCPU affinity i

Re: preparations for 4.16.2

2022-08-03 Thread Jan Beulich
On 03.08.2022 11:29, Julien Grall wrote: > On 27/07/2022 08:26, Jan Beulich wrote: >> All, > > Hi Jan, > >> the release is due in about two weeks time. >> >> Please point out backports you find missing from the respective staging >> branch, but which you consider relevant. I'm surprised in partic

Re: [PATCH 3/3] xen/sched: fix cpu hotplug

2022-08-03 Thread Jan Beulich
On 02.08.2022 15:36, Juergen Gross wrote: > --- a/xen/common/sched/cpupool.c > +++ b/xen/common/sched/cpupool.c > @@ -419,6 +419,8 @@ static int cpupool_alloc_affin_masks(struct > affinity_masks *masks) > return 0; > > free_cpumask_var(masks->hard); > +memset(masks, 0, sizeof(*

Re: [PATCH V7 01/11] xen/pci: arm: add stub for is_memory_hole

2022-08-03 Thread Rahul Singh
Hi Oleksandr, > On 29 Jul 2022, at 5:28 pm, Oleksandr wrote: > > > Hello Rahul > > > On 19.07.22 20:42, Oleksandr Tyshchenko wrote: >> From: Oleksandr Andrushchenko >> >> Add a stub for is_memory_hole which is required for PCI passthrough >> on Arm. >> >> Signed-off-by: Oleksandr Andrushch

Re: preparations for 4.16.2

2022-08-03 Thread Julien Grall
(+ Bertrand) On 27/07/2022 08:26, Jan Beulich wrote: All, Hi Jan, the release is due in about two weeks time. Please point out backports you find missing from the respective staging branch, but which you consider relevant. I'm surprised in particular that no Arm backports have appeared on t

Re: [PATCH 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

2022-08-03 Thread Jan Beulich
On 02.08.2022 15:27, Juergen Gross wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -3190,6 +3190,66 @@ out: > return ret; > } > > +static struct cpu_rm_data *schedule_cpu_rm_alloc(unsigned int cpu) > +{ > +struct cpu_rm_data *data; > +struct sched_resourc

Re: [PATCH v2] arm/vgic-v3: fix virq offset in the rank when storing irouter

2022-08-03 Thread Julien Grall
On 03/08/2022 09:19, Julien Grall wrote: Hi Hongda, On 29/07/2022 09:36, Hongda Deng wrote: When vGIC performs irouter registers emulation, to get the target vCPU via virq conveniently, Xen doesn't store the irouter value directly, instead it will use the value (affinities) in irouter to cal

Re: Acer Aspire 5 A517-52G - No firmware ACIP and no boot

2022-08-03 Thread Bruno
Understood. This means, someone in this list might be interested in picking this up and implementing a solution to it to the code. I am glad we have this here now. Thank you. > On 3 Aug 2022, at 09:49, Jan Beulich wrote: > > On 03.08.2022 10:44, Bruno wrote: >> Jan, I am glad we see this now

Re: Acer Aspire 5 A517-52G - No firmware ACIP and no boot

2022-08-03 Thread Jan Beulich
On 03.08.2022 10:44, Bruno wrote: > Jan, I am glad we see this now! > > Should I report this on the to the linux kernel dev group? While you might, I'm not sure they would care. Work needs to be done in the hypervisor first, with Linux making use of the added functionality (i.e. presumably a new

Re: Acer Aspire 5 A517-52G - No firmware ACIP and no boot

2022-08-03 Thread Bruno
Jan, I am glad we see this now! Should I report this on the to the linux kernel dev group? Thank you! > On 3 Aug 2022, at 07:34, Jan Beulich wrote: > > On 03.08.2022 08:25, Jan Beulich wrote: >>> On 02.08.2022 18:07, Bruno wrote: >>> On initramfs: >>> >>> - xl will give me not found - I can

Re: [PATCH 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-03 Thread Juergen Gross
On 03.08.22 10:30, Jan Beulich wrote: On 03.08.2022 10:01, Juergen Gross wrote: On 03.08.22 09:50, Jan Beulich wrote: On 02.08.2022 15:27, Juergen Gross wrote: --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1790,28 +1790,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_

Re: [PATCH 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-03 Thread Jan Beulich
On 03.08.2022 10:01, Juergen Gross wrote: > On 03.08.22 09:50, Jan Beulich wrote: >> On 02.08.2022 15:27, Juergen Gross wrote: >>> --- a/xen/common/sched/core.c >>> +++ b/xen/common/sched/core.c >>> @@ -1790,28 +1790,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t >>> cmd, >>> retu

Re: [PATCH v2] arm/vgic-v3: fix virq offset in the rank when storing irouter

2022-08-03 Thread Julien Grall
Hi Hongda, On 29/07/2022 09:36, Hongda Deng wrote: When vGIC performs irouter registers emulation, to get the target vCPU via virq conveniently, Xen doesn't store the irouter value directly, instead it will use the value (affinities) in irouter to calculate the target vCPU, and then save the tar

Re: [PATCH v2 1/2] xen: add late init call in start_xen

2022-08-03 Thread Julien Grall
Hi Boyoun, On 03/08/2022 03:40, Boyoun Park wrote: Thank you for your reply. I will seriously consider contributing platform specific drivers. Currently, I make a sample usage by applying this to a function in start_xen. I think functions in start_xen could be reduced for readability and underst

Re: [PATCH 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-03 Thread Juergen Gross
On 03.08.22 09:50, Jan Beulich wrote: On 02.08.2022 15:27, Juergen Gross wrote: --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1790,28 +1790,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, return ret; } -void domain_update_node_affinity(struct domain *d

Re: [PATCH] tools: make misra convert tool executable

2022-08-03 Thread Bertrand Marquis
Hi Jan, > On 3 Aug 2022, at 08:55, Jan Beulich wrote: > > On 03.08.2022 09:35, Bertrand Marquis wrote: >> Fix misra document conversion script to be executable. >> >> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) >> Signed-off-by: Bertrand Marquis >> --- >> xen/tools/convert

Re: [PATCH] tools: make misra convert tool executable

2022-08-03 Thread Jan Beulich
On 03.08.2022 09:35, Bertrand Marquis wrote: > Fix misra document conversion script to be executable. > > Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) > Signed-off-by: Bertrand Marquis > --- > xen/tools/convert_misra_doc.py | 0 > 1 file changed, 0 insertions(+), 0 deletions(

[GIT PULL] xen: branch for v6.0-rc1

2022-08-03 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.0-rc1-tag xen: branch for v6.0-rc1 It contains: - a series fine tuning virtio support for Xen guests, including removal the now again unused "platform_has()" feature. - a fix for

Re: [PATCH 1/3] xen/sched: introduce cpupool_update_node_affinity()

2022-08-03 Thread Jan Beulich
On 02.08.2022 15:27, Juergen Gross wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -1790,28 +1790,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t > cmd, > return ret; > } > > -void domain_update_node_affinity(struct domain *d) > +void domain_update_nod

[PATCH] tools: make misra convert tool executable

2022-08-03 Thread Bertrand Marquis
Fix misra document conversion script to be executable. Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) Signed-off-by: Bertrand Marquis --- xen/tools/convert_misra_doc.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 xen/tools/convert_misra_do

Re: [PATCH 2/2] xen/sched: setup dom0 vCPUs affinity only once

2022-08-03 Thread Jan Beulich
On 02.08.2022 15:51, Dario Faggioli wrote: > Right now, affinity for dom0 vCPUs is setup in two steps. This is a > problem as, at least in Credit2, unit_insert() sees and uses the > "intermediate" affinity, and place the vCPUs on CPUs where they cannot > be run. And this in turn results in boot han

[xen-unstable test] 172089: regressions - FAIL

2022-08-03 Thread osstest service owner
flight 172089 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172089/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172073 build-amd64-libvir

Re: [PATCH v2 2/2] xen: remove init_constructors out of start_xen

2022-08-03 Thread Jan Beulich
On 03.08.2022 04:44, Boyoun Park wrote: > From: Boyoun Park > Date: Wed, 3 Aug 2022 10:31:55 +0900 > Subject: [PATCH v2 2/2] xen: remove init_constructors out of start_xen > > This patch removed init_constructors from start_xen > by using __late_initcall. > It can be applied to other init functio

[PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation

2022-08-03 Thread Xenia Ragiadakou
The macro parameters 'off' and 'uart' are used as expressions and it is good to be enclosed in parentheses to prevent against unintended expansion. For the 'uart' case, in mvebu3700_write(), correct the second parentheses that seems to have been accidently misplaced. Signed-off-by: Xenia Ragiadak