> On 3 Aug 2022, at 14:01, Julien Grall <[email protected]> wrote: > > Hi Bertrand, > > On 03/08/2022 13:56, Bertrand Marquis wrote: >>> On 3 Aug 2022, at 13:55, Bertrand Marquis <[email protected]> wrote: >>> >>> >>> >>>> On 3 Aug 2022, at 13:10, Julien Grall <[email protected]> wrote: >>>> >>>> Hi, >>>> >>>> On 03/08/2022 13:05, Jan Beulich wrote: >>>>> On 03.08.2022 13:57, Bertrand Marquis wrote: >>>>>> When calling python tools to convert misra documentation or merge >>>>>> cppcheck xml files, use $(PYTHON). >>>>>> While there fix misra document conversion script to be executable. >>>>>> >>>>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule) >>>>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules >>>>> Nit: These two titles would want expressing consistently. If I >>>>> end up committing this, I'll try to remember to adjust. >>>> >>>> There are actually a few issues with the Fixes tags. From the doc [1] : >>>> - the sha1 should be 12 characters (rather than 10) >>>> - the format should be: >>>> Fixes: <comidid> ("Commit title") >>> >>> You want me to resend and fix that ? > > If Jan doesn't want to fix it on commit. Then I would be happy to do it.
Thanks a lot > >>> >>> On the 12 chars one, I must admit I used git log —oneline and did not count. >>> Any particular reason to use 12 instead of the 10 that git log is giving ? > > 10 characters will often result to clash. 12 is known to be sufficient and > also used by Linux. Ok > >>> Should we suggest how to get this properly in a simple manner ? >> Meaning without changing the git config :-) > > You could use > > 42sh> git log --abbrev=<N> --abbrev-commit It might make sense to add this to the doc ? I am happy to add this if other think it makes sense. Cheers Bertrand > > where N is the number of characters. > > Cheers, > > -- > Julien Grall
