On Fri, Jul 29, 2022 at 06:53:26PM +0100, Edwin Török wrote: > Based on Christian Lindig's work.
Should we have is "Signed-off-by" tag then? Also he might be the author of the patch, isn't it? > Initially this will be used to build unit tests, and to make development > easier. > > Dune supports proper incremental builds and editor integration with > merlin/LSP. > > For now the Makefile based build system is retained too: this is not a > hard dependency on Dune. > > Using version 2.1 of Dune build language here, because that is the one > available in Ubuntu Focal (part of the CI here). > > No functional change. > > Signed-off-by: Edwin Török <[email protected]> > --- > create mode 100644 tools/dune > create mode 100644 tools/dune-project Should this two new "dune*" files be added to MAINTAINERS in the OCAML section? > diff --git a/tools/.gitignore b/tools/.gitignore > new file mode 100644 > index 0000000000..c211749a3b > --- /dev/null > +++ b/tools/.gitignore > @@ -0,0 +1,7 @@ > +dune-workspace* Is this file going to be in many subdirectory or just in tools/ ? You can prepend a slash to tell git to ignore this file only in this directory. > +_build/ Is this where dune is going to do out-of-tree build by default? Also, is this only going to be in tools/_build/ ? > +.merlin > +*.h.gch > +*.opam > +ocaml/*.install > +include/_xentoolcore_list.h That last line doesn't seems related to dune, why is it in this patch? Also, can you sort the lines in this .gitignore? Thanks, -- Anthony PERARD
