On 03.08.2022 14:10, Julien Grall wrote:
> On 03/08/2022 13:05, Jan Beulich wrote:
>> On 03.08.2022 13:57, Bertrand Marquis wrote:
>>> When calling python tools to convert misra documentation or merge
>>> cppcheck xml files, use $(PYTHON).
>>> While there fix misra document conversion script to be executable.
>>>
>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules
>>
>> Nit: These two titles would want expressing consistently. If I
>> end up committing this, I'll try to remember to adjust.
> 
> There are actually a few issues with the Fixes tags. From the doc [1] :
>    - the sha1 should be 12 characters (rather than 10)

Oh, I didn't even pay attention to that.

>    - the format should be:
>        Fixes: <comidid> ("Commit title")

Right, this was the adjustment I was meaning to make.

Jan

Reply via email to