[PATCH weston] libweston-desktop/xdg-shell-v6: Ensure configure timer remains

2017-08-24 Thread Daniel Stone
configure event which will never arrive: the initial configure event gets queued, but calling set_maximised(false) causes the 'same event' check to get tripped which promptly deletes the timer, and no event is ever sent. Signed-off-by: Daniel Stone Cc: Quentin Glidic --- libweston-d

Re: [PATCH weston v11 11/13] compositor-drm: Don't repaint if no damage

2017-08-28 Thread Daniel Stone
Hi, On 21 July 2017 at 15:18, Pekka Paalanen wrote: > On Tue, 18 Jul 2017 14:14:33 +0100 > Daniel Stone wrote: >> @@ -1517,10 +1518,20 @@ drm_output_render(struct drm_output_state *state, >> pixman_region32_t *damage) >> if (scanout_state->fb) >>

Re: [PATCH weston v11 10/13] compositor-drm: Use drm_plane for scanout plane

2017-08-28 Thread Daniel Stone
Hi Philipp, Thanks for the review! On 21 July 2017 at 13:30, Philipp Zabel wrote: > On Tue, 2017-07-18 at 14:14 +0100, Daniel Stone wrote: >> @@ -3804,7 +3840,8 @@ drm_output_enable(struct weston_output *base) >> else >> b-&g

Re: [PATCH weston v11 10/13] compositor-drm: Use drm_plane for scanout plane

2017-08-28 Thread Daniel Stone
Hi Pekka, On 21 July 2017 at 14:59, Pekka Paalanen wrote: > On Tue, 18 Jul 2017 14:14:32 +0100 > Daniel Stone wrote: >> @@ -1424,15 +1419,29 @@ drm_output_prepare_scanout_view(struct >> drm_output_state *output_state, >> return NULL; >> }

Re: [PATCH weston v11 08/13] compositor-drm: Introduce drm_plane_state structure

2017-08-28 Thread Daniel Stone
Hi Pekka, On 20 July 2017 at 18:01, Pekka Paalanen wrote: > On Tue, 18 Jul 2017 14:14:30 +0100 > Daniel Stone wrote: >> @@ -986,6 +1130,20 @@ drm_output_state_duplicate(struct drm_output_state >> *src, >> else >> wl_list_init(&dst->

Re: [PATCH weston] libweston-desktop/xdg-shell-v6: Ensure first configure is sent

2017-08-30 Thread Daniel Stone
Hi Quentin, On 28 August 2017 at 19:12, Quentin Glidic wrote: > The old code for scheduling configure events on idle looked like: > if (configure_scheduled) { > if (this_event_is_the_same) { > remove_timer(); > return; > } > } > > If we queued one new event (either changed, or the

Re: [PATCH] Use sysroot prefix for pkgdatadir variable

2017-08-30 Thread Daniel Stone
Hi Tomek, On 14 August 2017 at 11:02, Tomek Bury wrote: > Daniel, can we have this one merged, please? We sure can. Sorry for the delay. To ssh://git.freedesktop.org/git/wayland/wayland-protocols 9ee1d59..875130e push -> master Cheers, Daniel ___

Re: [PATCH] compositor-drm: fix z-order inversion in plane assignment

2017-09-05 Thread Daniel Stone
Hi Matt, On 24 August 2017 at 15:24, Matt Hoosier wrote: > @@ -1545,10 +1548,22 @@ drm_assign_planes(struct weston_output *output_base, > void *repaint_data) > next_plane = primary; > if (next_plane == NULL) > next_plane = drm_outpu

Re: Why isn't Xwayland just a Wayland client?

2017-09-06 Thread Daniel Stone
Hi Joseph, On 6 September 2017 at 11:56, Joseph Burt wrote: > I'm thinking this might be a job for a bit of translation shim within > Xwayland. Everything an X client needs either has a Wayland equivalent > (through an X server and a little translating XWM shim) or, where > forbidden by Wayland,

Re: [PATCH weston 3/3] gl-renderer: Emit GPU rendering begin and end timeline timepoints

2017-09-15 Thread Daniel Stone
On 15 September 2017 at 12:39, Pekka Paalanen wrote: > I am not familiar yet with the fence/sync APIs so I cannot review their > usage at this time. I do review all the Weston parts. I walked through it the other night, and the fence bits at least are: Reviewed-by: Daniel

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Daniel Stone
c Apart from the below, this series, when squashed into a single patch for import, is: Reviewed-by: Daniel Stone I realise this is a straight copy/import, so sorry to pick on these, but: > +#include // offsetof > +#include // printf > + > +#include "wayland-egl-priv.h" /

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Daniel Stone
Hi Emil, On 15 September 2017 at 15:54, Emil Velikov wrote: > On 15 September 2017 at 14:50, Daniel Stone wrote: >> Currently the client-facing libwayland-egl API is defined by a header >> file shipped by Wayland, but the implementation is left to each >> vendor. This can

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Daniel Stone
Hi Drew, On 15 September 2017 at 16:21, Drew DeVault wrote: > On 2017-09-15 6:17 PM, Pekka Paalanen wrote: >> DRM is for driving any kind of display, GPU or not, acceleratable or >> not. What it gives us is a standard userspace ABI to poke all display >> devices with. >> >> There could be other

[PATCH wayland-protocols] Add zwp_linux_explicit_synchronization_v1

2017-09-19 Thread Daniel Stone
Signed-off-by: Daniel Stone --- Makefile.am| 1 + unstable/linux-explicit-synchronization/README | 5 + .../linux-explicit-synchronization-unstable-v1.xml | 208 + 3 files changed, 214 insertions(+) create mode 100644 unstable

Re: [PATCH wayland-protocols] Add zwp_linux_explicit_synchronization_v1

2017-09-20 Thread Daniel Stone
Hi Matt, On 20 September 2017 at 05:48, Matt Hoosier wrote: > On a related subject, there was discussion back at > https://lists.freedesktop.org/archives/wayland-devel/2013-September/011091.html > that acknowledged a longstanding bug where wl_buffer::release events > are starved indefinitely in t

Re: [PATCH wayland-protocols] Add zwp_linux_explicit_synchronization_v1

2017-09-20 Thread Daniel Stone
Hi Emre, On 20 September 2017 at 06:38, Ucan, Emre (ADITG/ESB) wrote: > Will this protocol be used by libEGL, or applications has to use it directly ? The idea was for whoever calls wl_surface_attach() to also attach the fence: an EGL/Vulkan driver, or a client framework directly if using buffer

Re: [PATCH weston 14/21] compositor-fbdev: MAP_FAILED is not NULL

2017-09-22 Thread Daniel Stone
On 22 September 2017 at 07:31, Pekka Paalanen wrote: > Fix the assumption that MAP_FAILED would be equal to NULL. It is not. > Set 'fb' explicitly to NULL on mmap failure so that comparisons to NULL > would produce the expected result. > > Signed-off-by: Pekka Paalanen

Re: [PATCH weston v11 09/13] compositor-drm: Track cursor_plane with a drm_plane

2017-09-22 Thread Daniel Stone
Hi, On 21 July 2017 at 04:56, Pekka Paalanen wrote: > On Tue, 18 Jul 2017 14:14:31 +0100 > Daniel Stone wrote: >> @@ -3634,10 +3844,11 @@ drm_output_deinit(struct weston_output *base) >> drm_output_fini_egl(output); >> >> weston_plane_

Re: [PATCH v2] compositor: fix starvation of wl_buffer::release

2017-09-26 Thread Daniel Stone
to guarantee that they get correctly notified of buffer > lifecycle events. File under, 'good ideas that didn't quite work out'. Reviewed-by: Daniel Stone Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2017-09-26 Thread Daniel Stone
Hello Esaki-san, On 1 November 2016 at 19:09, Daniel Stone wrote: >> @@ -1101,15 +1096,9 @@ drm_output_prepare_overlay_view(struct drm_output >> *output, >> if (!found) >> return NULL; >> >> - if ((dmabuf = linux_dmabuf_buffer_ge

[PATCH weston v12 01/40] compositor-drm: Introduce drm_output_state structure

2017-09-26 Thread Daniel Stone
plane-but-but-atomic-plane content. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 354 ++--- 1 file changed, 300 insertions(+), 54 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 5e87cb41..51aacd48 1

[PATCH weston v12 04/40] compositor-drm: Use drm_plane for cursor plane

2017-09-26 Thread Daniel Stone
e. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 423 ++--- 1 file changed, 322 insertions(+), 101 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 0827e953..33555d00 100644 --- a/libweston/compositor-d

[PATCH weston v12 06/40] compositor-drm: Don't repaint if no damage

2017-09-26 Thread Daniel Stone
If we don't have any damage for the primary plane, then don't force a repaint; simply reuse the old buffer we already have. Signed-off-by: Daniel Stone Reviewed-by: Pekka Paalanen --- libweston/compositor-drm.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

[PATCH weston v12 03/40] [TEST] compositor-drm: Allow disabling universal planes

2017-09-26 Thread Daniel Stone
Add a test environment variable to allow disabling universal planes. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index b28e602f..0827e953 100644 --- a

[PATCH weston v12 08/40] compositor-drm: Disable unused CRTCs/connectors

2017-09-26 Thread Daniel Stone
If we have an unused CRTC or connector, explicitly disable it during the end of the repaint cycle, or when we get VT-switched back in. Signed-off-by: Daniel Stone Reviewed-by: Pekka Paalanen --- libweston/compositor-drm.c | 60 -- 1 file changed, 48

[PATCH weston v12 02/40] compositor-drm: Introduce drm_plane_state structure

2017-09-26 Thread Daniel Stone
part of output->state_last, and is not directly visible from the plane itself. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 342 - 1 file changed, 277 insertions(+), 65 deletions(-) diff --git a/libweston/compositor-drm.c b/libwes

[PATCH weston v12 07/40] compositor-drm: Track unused connectors and CRTCs

2017-09-26 Thread Daniel Stone
Rather than a more piecemeal approach at backend creation, explicitly track connectors and CRTCs we do not intend to use, so we can ensure they are disabled where appropriate. Signed-off-by: Daniel Stone Reviewed-by: Pekka Paalanen --- libweston/compositor-drm.c | 53

[PATCH weston v12 18/40] compositor-drm: Extract buffer->plane co-ord translation

2017-09-26 Thread Daniel Stone
Pull this into a helper function, so we can use it everywhere. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 157 + 1 file changed, 88 insertions(+), 69 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c

[PATCH weston v12 11/40] compositor-drm: Don't restore original CRTC mode

2017-09-26 Thread Daniel Stone
When leaving Weston, don't attempt to restore the previous CRTC settings. The framebuffer may well have disappeared, and in every likelihood, whoever gets the KMS device afterwards will be repainting anyway. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c

[PATCH weston v12 13/40] compositor-drm: Add blob_id member to drm_mode

2017-09-26 Thread Daniel Stone
For atomic modesetting support, the mode is identified by a blob property ID, rather than being passed inline. Add a blob_id member to drm_mode to handle this, including refactoring mode destruction into a helper function. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 21

[PATCH weston v12 12/40] compositor-drm: Discover atomic properties

2017-09-26 Thread Daniel Stone
From: Pekka Paalanen Set the atomic client cap, where it exists, and use this to discover the plane/CRTC/connector properties we require for atomic modesetting. Signed-off-by: Daniel Stone Co-authored-by: Pekka Paalanen --- configure.ac | 3 +++ libweston/compositor-drm.c | 57

[PATCH weston v12 05/40] compositor-drm: Use drm_plane for scanout plane

2017-09-26 Thread Daniel Stone
Use a real drm_plane to back the scanout plane, displacing output->fb_{last,cur,pending} to their plane-tracked equivalents. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 167 +++-- 1 file changed, 101 insertions(+), 66 deletions(-) d

[PATCH weston v12 33/40] compositor-drm: Ignore occluded views

2017-09-26 Thread Daniel Stone
When trying to assign planes, keep track of the areas which are already occluded, and ignore views which are completely occluded. This allows us to build a state using planes only, when there are occluded views which cannot go into a plane behind views which can. Signed-off-by: Daniel Stone

[PATCH weston v12 28/40] compositor-drm: Support modifiers for drm_fb

2017-09-26 Thread Daniel Stone
Use the new drmModeAddFB2WithModifiers interface to import buffers with modifiers. Signed-off-by: Daniel Stone --- configure.ac | 3 +++ libweston/compositor-drm.c | 28 ++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/configure.ac b

[PATCH weston v12 37/40] compositor-drm: Relax plane restrictions for atomic

2017-09-26 Thread Daniel Stone
Since we now incrementally test atomic state as we build it, we can loosen restrictions on what we can do with planes, and let the kernel tell us whether or not it's OK. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 22 ++ 1 file changed, 14 insertions(

[PATCH weston v12 36/40] compositor-drm: Add test-only mode to state application

2017-09-26 Thread Daniel Stone
The atomic API can allow us to test state before we apply it, to see if it will be valid. Add support for this, which we will later use in assign_planes to ensure our plane configuration is valid. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 180

[PATCH weston v12 30/40] compositor-drm: Rename region variable

2017-09-26 Thread Daniel Stone
Make it a bit more clear what the purpose of the variable is. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 3b22faf1..093e75b1 100644 --- a

[PATCH weston v12 17/40] compositor-drm: Make alpha-to-opaque handling common

2017-09-26 Thread Daniel Stone
Rather than a hardcoded ARGB -> XRGB translation inside a GBM-specific helper, just determine whether or not the view is opaque, and use the generic helpers to implement the format translation. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c |

[PATCH weston v12 25/40] compositor-drm: Remove no_addfb2 handling

2017-09-26 Thread Daniel Stone
ioctl for users on old kernels without AddFB2; unfortunately, we cannot detect the complete absence of the ioctl, as the return here is -EINVAL rather than -ENOTTY. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 46 -- 1 file change

[PATCH weston v12 19/40] compositor-drm: Fully account for buffer transformation

2017-09-26 Thread Daniel Stone
In our new and improved helper to determine the src/dest values for a buffer on a given plane, make sure we account for all buffer transformations, including viewport clipping. Rather than badly open-coding it ourselves, just use the helper which does exactly this. Signed-off-by: Daniel Stone

[PATCH weston v12 40/40] compositor-drm: Support modifiers with GBM

2017-09-26 Thread Daniel Stone
Use the extended GBM allocator interface to support modifiers and multi-planar BOs. Depends on bwidawsk's 'modifiers' tree. Signed-off-by: Daniel Stone --- configure.ac | 3 +++ libweston/compositor-drm.c | 57 ++ 2 fi

[PATCH weston v12 27/40] compositor-drm: Add modifiers to GBM dmabuf import

2017-09-26 Thread Daniel Stone
Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to import multi-plane dmabufs, as well as format modifiers. Signed-off-by: Daniel Stone --- configure.ac | 3 - libweston/compositor-drm.c | 181 + 2 files changed

[PATCH weston v12 32/40] compositor-drm: Ignore views on other outputs

2017-09-26 Thread Daniel Stone
When we come to assign_planes, try very hard to ignore views which are only visible on other outputs, rather than forcibly moving them to the primary plane, which causes damage all round and unnecessary repaints. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 24

[PATCH weston v12 34/40] compositor-drm: Add modes to drm_output_propose_state

2017-09-26 Thread Daniel Stone
Add support for multiple modes: toggling whether or not the renderer and/or planes are acceptable. This will be used to implement a smarter plane-placement heuristic when we have support for testing output states. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 39

[PATCH weston v12 38/40] compositor-drm: Enable planes for atomic

2017-09-26 Thread Daniel Stone
Now that we can sensibly test proposed plane configurations with atomic, sprites are not broken. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston

[PATCH weston v12 35/40] compositor-drm: Return plane state from plane preparation

2017-09-26 Thread Daniel Stone
Return a pointer to the plane state, rather than indirecting via a weston_plane. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 73 ++ 1 file changed, 42 insertions(+), 31 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston

[PATCH weston v12 22/40] compositor-drm: Use plane_coords_for_view for cursor

2017-09-26 Thread Daniel Stone
Use the new helper to populate the cursor state as well, with some special-case handling to account for how we always upload a full-size BO. Signed-off-by: Daniel Stone Reported-by: Derek Foreman --- libweston/compositor-drm.c | 48 +++--- 1 file changed

[PATCH weston v12 16/40] compositor-drm: Allow disabling atomic

2017-09-26 Thread Daniel Stone
Add a test environment variable to allow disabling atomic modesetting. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index d04ba12f..8cd69f1f

[PATCH weston v12 21/40] compositor-drm: Use plane_state_coords_for_view for scanout

2017-09-26 Thread Daniel Stone
Use the shiny new helper we have for working through scanout as well. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 66 -- 1 file changed, 23 insertions(+), 43 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor

[PATCH weston v12 09/40] compositor-drm: Move repaint state application to flush

2017-09-26 Thread Daniel Stone
_dpms generating a synchronous state update. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 313 ++--- 1 file changed, 240 insertions(+), 73 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 530b0fd5..6c1c6881 1

[PATCH weston v12 15/40] compositor-drm: Atomic modesetting support

2017-09-26 Thread Daniel Stone
Add support for using the atomic-modesetting API to apply output state. Unlike previous series, this commit does not unflip sprites_are_broken, until further work has been done with assign_planes to make it reliable. Signed-off-by: Daniel Stone Co-authored-by: Pekka Paalanen Co-authored-by

[PATCH weston v12 24/40] compositor-drm: Use plane FB-import helper for scanout

2017-09-26 Thread Daniel Stone
Use the same codepath, which has the added advantage of being able to import dmabufs. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 62 +- 1 file changed, 12 insertions(+), 50 deletions(-) diff --git a/libweston/compositor-drm.c b

[PATCH weston v12 31/40] compositor-drm: Split drm_assign_planes in two

2017-09-26 Thread Daniel Stone
Move drm_assign_planes into two functions: one which proposes a plane configuration, and another which applies that state to the Weston internal structures. This will be used to try multiple configurations and see which is supported. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c

[PATCH weston v12 29/40] compositor-drm: Don't need safe view-list traversal

2017-09-26 Thread Daniel Stone
Nothing in this loop reorders views within the compositor's view_list. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 72c9e5a2..3b22faf1 100644

[PATCH weston v12 14/40] compositor-drm: Add to_drm_mode helper

2017-09-26 Thread Daniel Stone
Much like we already have to_drm_output and to_drm_backend. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 2a72456d..3c75ec56 100644 --- a

[PATCH weston v12 23/40] compositor-drm: Extract overlay FB import to helper

2017-09-26 Thread Daniel Stone
... in order to be able to use it from scanout as well. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 221 - 1 file changed, 119 insertions(+), 102 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index

[PATCH weston v12 10/40] compositor-drm: Use apply_state for starting repaint

2017-09-26 Thread Daniel Stone
Rather than open-coding it ourselves, use the new apply_state helper in drm_output_start_repaint. Signed-off-by: Daniel Stone Reported-by: Fabien DESSENNE --- libweston/compositor-drm.c | 38 ++ 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a

[PATCH weston v12 26/40] compositor-drm: Extract drm_fb_addfb into a helper

2017-09-26 Thread Daniel Stone
We currently do the same thing in two places, and will soon have a third. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 93 -- 1 file changed, 48 insertions(+), 45 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston

[PATCH weston v12 20/40] [XXX] compositor-drm: Only disallow scaling for overlay planes

2017-09-26 Thread Daniel Stone
x, and then analyse that. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index e835d3b7..07f0b105 100644 --- a/libweston/compositor-

[PATCH weston v12 00/40] Atomic modesetting

2017-09-26 Thread Daniel Stone
Hi, Here's a cleaned-up and fully-tested version of the atomic series. I'm fairly happy with it now. There are a few things I'd want to change, but figured I'd send it all out now rather than waiting another however long: * I'd rather track unused_{crtcs,connectors} by putting them all in ori

[PATCH weston v12 39/40] compositor-drm: Support plane IN_FORMATS

2017-09-26 Thread Daniel Stone
ff-by: Sergi Granell Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 126 ++--- 1 file changed, 118 insertions(+), 8 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 111cb9e3..811

Re: [PATCH weston v3 4/4] gl-renderer: Emit GPU rendering begin and end timeline timepoints

2017-09-27 Thread Daniel Stone
Hi Chris, Thanks for taking a look! On 27 September 2017 at 13:18, Chris Wilson wrote: > Quoting Alexandros Frantzis (2017-09-27 13:09:16) >> Use EGL fence sync objects to emit timepoints for the beginning and the >> end of rendering on the GPU. > > But why not use a qbo with GL_TIMESTAMP? As Al

Re: [PATCH weston v12 00/40] Atomic modesetting

2017-09-27 Thread Daniel Stone
Hi Matt, On 27 September 2017 at 14:46, Matt Hoosier wrote: > On Tue, Sep 26, 2017 at 12:15 PM, Daniel Stone wrote: >> Here's a cleaned-up and fully-tested version of the atomic series. > > Just wondering: do you maintain these in a publicly fetchable repo > somewhere? I

Re: [Mesa-dev] XDC 2017 feedback

2017-09-28 Thread Daniel Stone
Hi, On 28 September 2017 at 03:49, Ian Romanick wrote: > On 09/27/2017 04:55 PM, Rob Clark wrote: >> Sadly by the time we were aware of the dates for the khronos f2f it >> was not possible to change the dates for XDC :-( >> >> The XDC dates were set in Feb, and afaict the khronos dates were >> an

Re: [PATCH wayland] protocol: Suggest get_registry not be called frequently

2017-09-29 Thread Daniel Stone
ting too many wl_registry objects. > > Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-10-04 Thread Daniel Stone
Hi Pekka, On 22 September 2017 at 15:31, Pekka Paalanen wrote: > * > * \param output The weston_output object to initialize > * \param compositor The compositor instance. > + * \param name Name for the output. Please document that @name is duplicated internally, i.e. reference bo

Re: [PATCH weston 00/21] Fixes and reorganization, clone mode prep

2017-10-04 Thread Daniel Stone
-v1 A small nit on 'weston_output_init(..., +name)' notwithstanding, the series to date on head-prep-v1 (different to what was sent; maybe just rebased?) is: Acked-by Daniel Stone Cheers, Daniel ___ wayland-devel mailing list wayland-devel

[PATCH weston] gl-renderer: Ignore INVALID modifier

2017-10-04 Thread Daniel Stone
hand, if a modifier _is_ explicitly specified and we don't have the modifiers extension, then refuse to import the buffer. Signed-off-by: Daniel Stone --- libweston/gl-renderer.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libweston/gl-renderer.c b/libwesto

Re: [PATCH weston] gl-renderer: Ignore INVALID modifier

2017-10-05 Thread Daniel Stone
On 5 October 2017 at 08:15, Pekka Paalanen wrote: > On Wed, 4 Oct 2017 18:35:45 +0100 > Daniel Stone wrote: >> If the user has passed an INVALID modifier, it's because there is no >> applicable modifier, and the buffer layout should be determined by a >>

Re: [PATCH weston v12 03/40] [TEST] compositor-drm: Allow disabling universal planes

2017-10-05 Thread Daniel Stone
Hi Emil, On 2 October 2017 at 10:29, Pekka Paalanen wrote: > On Fri, 29 Sep 2017 14:21:02 +0100 > Emil Velikov wrote: >> Just a general idea, please don't bother with it for now: >> >> Normally it's great if one can have clear description of the format >> env. variables expect. >> Quick grep sho

Re: [RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-10-05 Thread Daniel Stone
Hi, On 5 October 2017 at 13:39, Emil Velikov wrote: > On 29 September 2017 at 14:00, Emil Velikov wrote: >> With the above data in mind, we can reuse the current Wayland version >> AKA WAYLAND_VERSION. >> It should just work for all the known cases, plus it provides >> consistency as a nice bon

[PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-05 Thread Daniel Stone
h for each plane, according to subsampling. Tested with: $ gst-launch-1.0 videotestsrc ! waylandsink Signed-off-by: Daniel Stone Fixes: fdeefe42418 ("gl-renderer: add support of WL_SHM_FORMAT_YUV420") Reported-by: Fabien Lahoudere Bugzilla: https://bugs.freedesktop.org/show_bug.c

Re: [PATCH weston] gl-renderer: Set pitch correctly for subsampled textures

2017-10-06 Thread Daniel Stone
search, as well as a GitHub code search, the only user of WL_SHM_FORMAT_YUV420 is ... GStreamer waylandsink. And that doesn't seem to have changed in quite some time, though Nicolas could probably confirm that. So this is probably just fixing it up full stop? >> Tested with: >> $

Re: Ideas on portable APIs to cheaply copy a GBM bo?

2017-10-10 Thread Daniel Stone
Hi Matt, On 10 October 2017 at 17:12, Matt Hoosier wrote: > My organization maintains a small patch against the DRM compositor > that causes it to register another output. This output accepts the > usual compositor scenegraph, does the rendering down to a primary > plane, and then funnels the res

Re: Ideas on portable APIs to cheaply copy a GBM bo?

2017-10-12 Thread Daniel Stone
Hi Pekka, On 12 October 2017 at 07:56, Pekka Paalanen wrote: > On Wed, 11 Oct 2017 09:01:30 -0500 > Matt Hoosier wrote: >> I'll have a look there. One thing that for simplicity I left out of >> the original description above is that this custom Weston output has a >> fast-path very similar to th

Re: [PATCH weston v12 00/40] Atomic modesetting

2017-10-12 Thread Daniel Stone
Hi Emre, On 12 October 2017 at 10:20, Ucan, Emre (ADITG/ESB) wrote: > I tested your branch " wip/2017-09/atomic-v12" on Intel Apollo Lake with: > - Linux Kernel v4.9 > - Libdrm 2.4.83 > - Mesa 13.0.6 Thanks for testing! > In the end, I could not test the atomic modesetting with this setup. I go

Re: Running multiple Wayland window managers in different ttys

2017-10-23 Thread Daniel Stone
Hi Deepak, On 20 October 2017 at 18:50, Deepak Jois wrote: > I have Gnome running under Wayland on tty2. The Gnome session is > running some app like gnome-terminal. > > I do the following: > > * Press Ctrl-Alt-F3 (switching to tty3, the lowest free tty) > * Login as the same user running the Gno

Re: [PATCH weston v4 1/9] protocol: add weston-debug.xml

2017-10-23 Thread Daniel Stone
Hi Emre, Maniraj, On 12 October 2017 at 13:13, Emre Ucan wrote: > From: Pekka Paalanen > > This is a new debugging extension for non-production environments. The > aim is to replace all build-time choosable debug prints in the > compositor with runtime subscribable debug streams. > > Signed-off-

Re: [PATCH weston v4 1/9] protocol: add weston-debug.xml

2017-10-23 Thread Daniel Stone
Hi all, On 12 October 2017 at 13:13, Emre Ucan wrote: > + > + > + This is a generic debugging interface for Weston internals, the global > + object advertized through wl_registry. > + > + WARNING: This interface by design allows a denial-of-service attack. It > + should

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hi, On 12 October 2017 at 13:13, Emre Ucan wrote: > +WL_EXPORT char * > +weston_debug_scope_timestamp(struct weston_debug_scope *scope, > +char *buf, size_t len) > +{ > + struct timeval tv; > + struct tm *bdt; > + char string[128]; > + size_t re

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hi, On 12 October 2017 at 13:13, Emre Ucan wrote: > +static void > +list_scope_begin(struct weston_debug_stream *stream, void *user_data) > +{ > + struct weston_debug_compositor *wdc = user_data; > + struct weston_debug_scope *scope; > + > + weston_debug_stream_printf(stream, "S

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hey, On 23 October 2017 at 12:54, Pekka Paalanen wrote: > On Mon, 23 Oct 2017 12:34:47 +0200 > Daniel Stone wrote: >> On 12 October 2017 at 13:13, Emre Ucan wrote: >> > + gettimeofday(&tv, NULL); >> > + >> > + bdt =

Re: [PATCH weston v4 2/9] libweston: add weston_debug API and implementation

2017-10-23 Thread Daniel Stone
Hey, One last comment from IRC discussion. On 23 October 2017 at 13:10, Daniel Stone wrote: > On 23 October 2017 at 12:54, Pekka Paalanen wrote: >> On Mon, 23 Oct 2017 12:34:47 +0200 >> Daniel Stone wrote: >>> I would very much not like to see formatted time in the

Re: [PATCH weston 00/10] wayland-backend fixes

2017-10-24 Thread Daniel Stone
testing hard by being >> already >> broken in many ways. Here is a series to fix the issues I found. The >> series can >> also be found at: > > Great work! > > The whole series is: > Reviewed-by: Quentin Glidic And with a read-through but no more: Acked-

Re: [PATCH weston v3 01/36] weston: arm SEGV handler earlier

2017-10-31 Thread Daniel Stone
tect the SEGV handler from dereferencing >> NULL when we don't yet have a compositor or a backend. >> >> The SEGV handler uses weston_log(), so cannot move catch_signals() any >> earlier. >> >> Signed-off-by: Pekka Paalanen > > So

Re: [PATCH weston v12 00/40] Atomic modesetting

2017-11-01 Thread Daniel Stone
Hi Emre. On 1 November 2017 at 11:56, Ucan, Emre (ADITG/ESB) wrote: > Is this the latest WIP branch to test " > https://gitlab.collabora.com/daniels/weston/commits/wip/2017-10/atomic-v13"; ? Right you are. > In my opinion, it would easier to review/test your patches if you can > separate them

Re: New paths for Wayland sockets (Re: Enabling Android-style per application user ids)

2017-11-07 Thread Daniel Stone
Hi, On 3 November 2017 at 07:33, Pekka Paalanen wrote: > People, give your acks/nacks for the two ideas, please: > > - modify WAYLAND_DISPLAY to support absolute paths which overrides > any search paths ACK. It's a simple and straightforward extension to current behaviour. > - when the curren

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-11-13 Thread Daniel Stone
Hi Emil, On 8 November 2017 at 14:06, Emil Velikov wrote: > On 10 October 2017 at 14:43, Emil Velikov wrote: >> In summary - we want the user facing library to live in Wayland with >> vendors providing a backend/plugin. Otherwise we'll get file conflicts >> as library can come from different ve

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-13 Thread Daniel Stone
Hi Emil, On 2 November 2017 at 17:09, Emil Velikov wrote: > Import latest version (v2) of the protocol from Mesa. > > From the README: > > Warning! > The goal is to share the protocol file across Mesa and other low-level > components graphics stack such as libva and Xwayland. File is moved to > w

Re: Position set/get prototype template

2022-08-08 Thread Daniel Stone
On Mon, 8 Aug 2022 at 17:24, samuel ammonius wrote: > I've just looked at the xdg-shell protocol as you said. I was really > surprised at the > amount of features it had, but one part in particular caught my eye: Window geometry is relative to surface co-ordinates. As the first paragraph describ

Re: Meeting (BOF) at Plumbers Dublin to discuss backlight brightness as connector object property RFC?

2022-09-09 Thread Daniel Stone
On Fri, 9 Sept 2022 at 12:50, Simon Ser wrote: > On Friday, September 9th, 2022 at 12:23, Hans de Goede < > hdego...@redhat.com> wrote: > > "people using > > non fully integrated desktop environments like e.g. sway often use custom > > scripts binded to hotkeys to get functionality like the brigh

Re: Weston does not start with "Failed to open device: No such file or directory, Try again..."

2023-02-17 Thread Daniel Stone
Hi Martin, On Fri, 17 Feb 2023 at 11:27, Martin Petzold wrote: > Feb 17 12:16:24 tavla DISPLAY Wayland[957]: [12:16:24.624] Loading module > '/usr/lib/aarch64-linux-gnu/libweston-9/g2d-renderer.so' > Feb 17 12:16:25 tavla DISPLAY Wayland[957]: [ 1] Failed to open device: > No such file or d

Re: Weston 10+ and GLES2 compatibility

2023-03-10 Thread Daniel Stone
Hi Daniel, On Fri, 10 Mar 2023 at 14:28, Levin, Daniel wrote: > We are currently attempting to update from Weston 9.0.0 to Weston 10+ and > facing issues with GLES2 compatibility at both build time and run time. > > For instance, gl_renderer_setup() exits with error if GL_EXT_unpack_subimage >

Re: Why does Java (XWayland / Weston) resize a Window to 1x1 pixel when HDMI is unplugged (and does not resize back when HDMI is plugged)

2023-06-08 Thread Daniel Stone
Hi, On Thu, 8 Jun 2023 at 14:28, Pekka Paalanen wrote: > On Thu, 8 Jun 2023 14:49:37 +0200 > Martin Petzold wrote: > > btw. we are using a Weston 9 package from NXP and there may be important > > fixes for our i.MX8 platform in there. > > Oh. We cannot support modified Weston, sorry. Significan

Re: Why does Java (XWayland / Weston) resize a Window to 1x1 pixel when HDMI is unplugged (and does not resize back when HDMI is plugged)

2023-06-08 Thread Daniel Stone
On Thu, 8 Jun 2023 at 16:54, Martin Petzold wrote: > Am 08.06.23 um 16:58 schrieb Daniel Stone: > > On Thu, 8 Jun 2023 at 14:28, Pekka Paalanen wrote: > >> On Thu, 8 Jun 2023 14:49:37 +0200 >> Martin Petzold wrote: >> > btw. we are using a Weston 9

Re: Refresh rates with multiple monitors

2023-06-13 Thread Daniel Stone
Hi, On Tue, 13 Jun 2023 at 10:20, Pekka Paalanen wrote: > On Tue, 13 Jun 2023 01:11:44 + (UTC) > Joe M wrote: > > As I understand, there is one global wl_display. Is there always one > > wl_compositor too? > > That is inconsequential. > Yeah, I think the really consequential thing is that

Re: Refresh rates with multiple monitors

2023-06-14 Thread Daniel Stone
Hi Joe, On Wed, 14 Jun 2023 at 21:33, Joe M wrote: > Thanks Daniel. Do you know if wl_output instances are decoupled from each > other, when it comes to display refresh? > Yep, absolutely. > The wl_output geometry info hints that each output can be thought of as a > region in a larger composi

Re: Weston 12 compatibility with Yocto Kirkstone

2023-06-15 Thread Daniel Stone
Hi Namit, On Thu, 15 Jun 2023 at 16:37, Namit Solanki (QUIC) < quic_nsola...@quicinc.com> wrote: > > As we all know Weston 10 has bitbakes files available for Yocto kirkstone > version. Can Weston 12 work with Kirkstone as well? > > > > Is Weston 12 compatible with Kirkstone? > > > > Do we need t

Re: Weston mirror/clone to 2 different displays

2023-06-23 Thread Daniel Stone
Hi Dawn, On Thu, 22 Jun 2023 at 18:09, Dawn HOWE wrote: > I am developing an (embedded) medical device which is required to have a > touchscreen display and also mirror the output to a monitor connected via > HDMI. The device is using Wayland/Weston on TorizonCore (based on a yocto > kirkstone).

Re: Need support to have weston randr release

2023-07-08 Thread Daniel Stone
Hi Huy, On Sat, 8 Jul 2023 at 08:39, huy nguyen wrote: > I have a Linux system based on weston wayland and I need to get the > current setting of the display resolution. > Unfortunately, xrandr command does not work on Wayland. > After much searching, I came to this information which is about ad

<    5   6   7   8   9   10   11   12   13   14   >