Hi, On 21 July 2017 at 04:56, Pekka Paalanen <[email protected]> wrote: > On Tue, 18 Jul 2017 14:14:31 +0100 > Daniel Stone <[email protected]> wrote: >> @@ -3634,10 +3844,11 @@ drm_output_deinit(struct weston_output *base) >> drm_output_fini_egl(output); >> >> weston_plane_release(&output->scanout_plane); >> - weston_plane_release(&output->cursor_plane); >> >> - /* Turn off hardware cursor */ >> - drmModeSetCursor(b->drm.fd, output->crtc_id, 0, 0, 0); >> + if (output->cursor_plane) { >> + /* Turn off hardware cursor */ >> + drmModeSetCursor(b->drm.fd, output->crtc_id, 0, 0, 0); > > Are we not leaking the cursor plane if drm_output_find_special_plane() > created it in the no-universal-planes case? > > Looks like drm_plane_destroy() would need a special path for the > special fake planes.
I'll fix the broken weston_plane_release() call, but since the cursor and scanout planes both live on backend->plane_list - even when faked via non-universal planes - it gets killed by destroy_sprites() anyway. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
