problem in my
> experiments.
>
> Signed-off-by: Pekka Paalanen
Oh dear.
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
('add set_toplevel_with_position to internal API' ..
'implement set_xwayland_position') seem safe to push and are:
Reviewed-by: Daniel Stone
'react to geometry changes' makes me a little nervous; is there a way
you can see that this can be resequenced or moved such
Hi Fabien,
On 17 January 2017 at 16:17, Fabien Dessenne wrote:
> As an option, allow to specify a mode (from the configuration file) by
> its refresh rate.
> Example of valid syntax:
> - "mode=1920x1080"Select a 1920x1080 mode, refresh rate undefined.
> - "mode=1920x1080@60" Select the (or on
Hi,
On 18 January 2017 at 12:02, Pekka Paalanen wrote:
> On Tue, 17 Jan 2017 15:44:32 +
> Daniel Stone wrote:
>> 'react to geometry changes' makes me a little nervous; is there a way
>> you can see that this can be resequenced or moved such that we don't
&g
Hi Ben,
On 22 December 2016 at 08:56, Ben wrote:
> Most display managers handle starting a dbus session daemon for you, so
> it does not make sense to start our own. Without this patch, if you run
> weston from gdm, programs cannot connect to the dbus session daemon.
Right you are. I can see bot
ies, and the Weston changes are:
Reviewed-by: Daniel Stone
If no-one has any objections, I'll merge this at the end of the week.
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Hi Emilio,
On 17 January 2017 at 19:58, Emilio Pozuelo Monfort wrote:
> index 223382ce..94b4bfa9 100644
> --- a/libweston/compositor-rdp.c
> +++ b/libweston/compositor-rdp.c
> @@ -664,13 +664,21 @@ rdp_peer_context_new(freerdp_peer* client,
> RdpPeerContext* context)
> context->rfx_conte
On 18 January 2017 at 22:21, Peter Hutterer wrote:
> clients/editor.c: In function ‘read_file’:
> clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean
> constant [-Wlogical-op]
> errno = errsv || EINVAL;
>
> This works in the shell, but not in C. Introduced in 411ffabbb56b
>
>
Hi Emilio,
On 18 January 2017 at 17:43, Emilio Pozuelo Monfort wrote:
> Based on a patch from John Moser
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850658
>
> Signed-off-by: Emilio Pozuelo Monfort
> ---
> libweston/compositor-rdp.c | 8
> 1 file changed, 8 insertions(+)
>
>
Hi Fabien,
On 19 January 2017 at 10:52, Fabien DESSENNE wrote:
> On 09/12/16 20:58, Daniel Stone wrote:
>> @@ -1706,10 +1718,21 @@ drm_output_prepare_scanout_view(struct
>> drm_output_state *output_state,
>> state->dest_h != (unsigned) output-&g
repaint_needed / repaint_scheduled are surprisingly subtle. Explode the
conditional with side-effects into more obvious separate calls, and
document what they do.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 27 +--
1 file changed, 21 insertions(+), 6
Hi Pekka,
On 23 January 2017 at 14:15, Pekka Paalanen wrote:
> On Fri, 20 Jan 2017 11:31:08 +0100
> Emilio Pozuelo Monfort wrote:
>> This version works for me...
>
> Hi guys,
>
> I found another guest to the party. Using net-misc/freerdp-2.0.0_pre20160722
> Weston master fails to build with:
>
>
viewed-by: Daniel Stone
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Hi,
On 23 January 2017 at 15:45, Daniel Stone wrote:
> On 23 January 2017 at 14:15, Pekka Paalanen wrote:
>> However, updating to net-misc/freerdp-2.0.0_pre20161219 allows things
>> to build for me again. There is just one warning:
>
> How about this fixup?
> diff --gi
Hi Armin,
On 10 November 2016 at 10:20, Armin Krezović wrote:
> On 09.11.2016 15:43, Daniel Stone wrote:
>> On 9 October 2016 at 22:48, Armin Krezović wrote:
>>> diff --git a/compositor/main.c b/compositor/main.c
>>> index 320305c..ffeadfb 100644
>>> --- a/co
On 25 January 2017 at 15:01, Daniel Stone wrote:
> This, and any other patch to wayland, wayland-protocols, or weston, to
> migrate any code copyright Collabora or the Raspberry Pi Foundation to
> the standard license text, are:
> Reviewed-by: Daniel Stone
... and pu
Hi Yong,
On 23 November 2016 at 15:38, Yong Bakos wrote:
> connection-test.c did not cover wl_argument_from_va_list, so add one
> test that specifically tests this method.
Easy enough, reviewed and pushed:
To ssh://git.freedesktop.org/git/wayland/wayland
de908658..8fe8a2bb push -> master
Th
Hi Yong,
On 23 January 2017 at 14:18, Yong Bakos wrote:
> From: Yong Bakos
Thanks for catching this!
To ssh://git.freedesktop.org/git/wayland/wayland-protocols
375385e..ab228a6 push -> master
Cheers,
Daniel
___
wayland-devel mailing list
wayland
Hi,
On 27 January 2017 at 14:25, Derek Foreman wrote:
> On 09/12/16 01:57 PM, Daniel Stone wrote:
>> +static int
>> +drm_view_transform_supported(struct weston_view *ev)
>> +{
>> + return !ev->transform.enabled ||
>> +
hardware plane, skipping GPU composition.
In light of all this, just remove the test.
Signed-off-by: Daniel Stone
---
Makefile.am | 7 --
protocol/weston-test.xml | 7 --
tests/buffer-count-test.c | 172 --
tests
Hi Pekka,
On 30 January 2017 at 12:51, Pekka Paalanen wrote:
> On Mon, 30 Jan 2017 16:00:06 +0530
> Varad Gautam wrote:
>> Instead of always always creating a wl_resource and identifying an invalid
>> wl_buffer on commit in weston, how about treating an invalid import just as
>> any other cause
Hi,
On 6 February 2017 at 10:29, Pekka Paalanen wrote:
> On Thu, 2 Feb 2017 14:06:55 +
> "Ucan, Emre (ADITG/SW1)" wrote:
>> weston can be started with --connector option to be initialized
>> with a particular output. But in the update_outputs this option
>> is not considered and output is cr
Hi Pekka,
On 6 February 2017 at 12:00, Pekka Paalanen wrote:
> On Mon, 6 Feb 2017 11:05:51 +
> Daniel Stone wrote:
>> I think we've got to choose between fixing it for 1.13 and removing it
>> immediately after release (which I will happily do), or just ripping
>&
Hi,
On 7 February 2017 at 13:56, Pekka Paalanen wrote:
> I believe all the Collabora copyrighted code is ok for the change, and
> I would not expect anyone of the other copyright holders to complain
> since we already did the same fix in 2015, and IIRC it wasn't necessary
> then to ask all copyri
Hi Armin,
On 9 October 2016 at 22:48, Armin Krezović wrote:
> And properly deconstruct it in drm_output_destroy.
>
> Might be useful for finding out which modes are supported
> before even setting them, in case we want to extend the
> modesetting API.
This is (finally):
Revi
Hi,
On 8 February 2017 at 10:23, Pekka Paalanen wrote:
> On Tue, 7 Feb 2017 17:17:41 -0800
> Bryce Harrington wrote:
>> Breaks the build on older linux kernels.
>>
>> CC clients/weston_simple_dmabuf_v4l-simple-dmabuf-v4l.o
>> clients/simple-dmabuf-v4l.c:358:25: warning: ‘struct v4l2_quer
only use of crtc_allocator with a list walk across outputs.
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compositor-drm.c | 31 +--
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/libweston/compositor-drm.c b/libw
Remove the last usage of connector_allocator, which was to check for
displays which have been hot-unplugged, and replace it with an array
which doesn't rely on the connector IDs remaining below 32 (or 64).
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compo
Rather than using connector_allocator to determine whether an output is
newly connected or not, use a list walk across all outputs instead.
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compositor-drm.c | 25 -
1 file changed, 20 insertions
The KMS backend was previously using a 32-bit-wide bitmask to mark out
CRTCs and connectors it had already allocated to outputs, to avoid
trying to reuse them across multiple outputs.
Unfortunately, this relied on KMS object IDs remaining below 32, and
even extending that out to 64 doesn't fix tha
only use of crtc_allocator with a list walk across outputs.
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compositor-drm.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
v2: Split drm_output_find_by_crtc into a separate fun
Rather than using connector_allocator to determine whether an output is
newly connected or not, use a list walk across all outputs instead.
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compositor-drm.c | 31 +--
1 file changed, 25
Hi,
Pekka quite rightly suggested that some small helper functions would
make this patchset more reasonable; fair enough.
Patches 1 and 2 certainly look a bit better, but patch 3 unfortunately
couldn't benefit since we needed to do the reverse lookup (for every
drm_output we track, is it still pre
Remove the last usage of connector_allocator, which was to check for
displays which have been hot-unplugged, and replace it with an array
which doesn't rely on the connector IDs remaining below 32 (or 64).
Signed-off-by: Daniel Stone
Reported-by: Peter Senna Tschudin
---
libweston/compo
Hi,
On 9 February 2017 at 16:44, Daniel Stone wrote:
> Pekka quite rightly suggested that some small helper functions would
> make this patchset more reasonable; fair enough.
>
> Patches 1 and 2 certainly look a bit better, but patch 3 unfortunately
> couldn't benefit since
vices present, will hit this.
Signed-off-by: Daniel Stone
Reported-by: Thierry Reding
Reported-by: Daniel Vetter
---
libweston/compositor-drm.c | 88 +-
1 file changed, 55 insertions(+), 33 deletions(-)
Resend/ping. Given that this breaks actual
Hi,
On 14 December 2016 at 15:59, Pekka Paalanen wrote:
> On Fri, 9 Dec 2016 19:57:16 +
> Daniel Stone wrote:
>> + {
>> + .format = DRM_FORMAT_RGBX,
>> + .gl_format = GL_RGBA,
>> + .gl_type = GL_UNSIGNED_SHORT_4
Hi Emil,
Thanks for the review!
On 10 February 2017 at 19:51, Emil Velikov wrote:
> On 10 February 2017 at 17:43, Daniel Stone wrote:
>> +static bool
>> +drm_device_is_kms(struct drm_backend *b, struct udev_device *device)
>> +{
>> + [...]
>> +
>&g
vices present, will hit this.
Signed-off-by: Daniel Stone
Reported-by: Thierry Reding
Reported-by: Daniel Vetter
---
libweston/compositor-drm.c | 90 +-
1 file changed, 57 insertions(+), 33 deletions(-)
diff --git a/libweston/compositor-drm.c b/libw
Hi Emmanuel,
On 8 December 2016 at 01:55, Emmanuel Gil Peyrot wrote:
> @@ -1146,6 +1150,48 @@ weston_wm_window_schedule_repaint(struct
> weston_wm_window *window)
> }
>
> static void
> +weston_wm_handle_icon(struct weston_wm *wm, struct weston_wm_window *window)
> +{
> + xcb_get_property
Hi Armin,
On 8 February 2017 at 12:55, Armin Krezović wrote:
> Signed-off-by: Armin Krezović
I've pushed this one as trivially correct, thanks:
To ssh://git.freedesktop.org/git/wayland/weston
e6b7136..9bcf4c5 push -> master
Cheers,
Daniel
___
way
Hi Armin,
On 8 February 2017 at 12:55, Armin Krezović wrote:
> I don't know when it started happening, but recent kernels
> give different names for pci_device and backlight parent.
>
> pci_device is tied to the GPU PCI ID, while backlight parent
> is tied to the connector, rather than the GPU it
Include a list of every copyright statement within the COPYING file.
Signed-off-by: Daniel Stone
---
COPYING | 37 -
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/COPYING b/COPYING
index faefd8f..418b4b4 100644
--- a/COPYING
+++ b/COPYING
Hi Yong,
On 23 January 2017 at 14:17, Yong Bakos wrote:
> From: Yong Bakos
>
> A handful of source files were not using the MIT Expat text in
> COPYING. Update these files to bring them inline with the rest,
> standardizing on the MIT Expat text.
Something weird with the patch, but hand-applyin
Hi Emil,
On 10 February 2017 at 20:14, Emil Velikov wrote:
> Makes the code easier to read and browse through.
Thanks, these both seem trivially correct; I'll push them whenever the
tree reopens.
Cheers,
Daniel
___
wayland-devel mailing list
wayland-d
Hi Emil,
On 13 February 2017 at 23:42, Emil Velikov wrote:
> On 13 February 2017 at 18:57, Daniel Stone wrote:
>> /*
>> * Find primary GPU
>> * Some systems may have multiple DRM devices attached to a single seat.
>> This
> Completely forgot: we want t
Paralleling timespec_to_nsec, converts to milliseconds.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 2 +-
shared/timespec-util.h | 11 +++
tests/timespec-test.c | 9 +
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/libweston/compositor.c b
utterly wasted time.
Add an explicit stamp == NULL, to determine that we are just beginning
our repaint loop, that the timings are in fact totally invalid, and that
it would be beneficial to repaint the output immediately.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 3
Add a (timespec) = (timespec) + (nsec) helper, to save intermediate
conversions to nanoseconds in its users.
Signed-off-by: Daniel Stone
---
Makefile.am| 10
shared/timespec-util.h | 21 +
tests/timespec-test.c | 126
Hi,
One of the nice features of atomic modesetting is, well, atomicity of
modesetting. Specifically that you can perform one call across every
output to set every mode in one go.
The previous atomic series implemented the nuclear pageflip side of
atomic modesetting (for one output, every plane rec
multiple repaints
together when timing allows.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/libweston/compositor.c b/libweston/compositor.c
index a28738ec9..9eab0e298 100644
--- a
Add a (timespec) = (timespec) + (msec) helper, to save intermediate
conversions in its users.
Signed-off-by: Daniel Stone
---
shared/timespec-util.h | 21 +
tests/timespec-test.c | 11 +++
2 files changed, 32 insertions(+)
diff --git a/shared/timespec-util.h b
iterates all of them, scheduling the repaint for the first available
time.
Signed-off-by: Daniel Stone
Cc: Mario Kleiner
Cc: Pekka Paalanen
---
libweston/compositor.c | 101 +
libweston/compositor.h | 3 +-
2 files changed, 79 insertions(+), 25
Implement new repaint_begin and repaint_flush hooks inside
weston_backend, allowing backends to gang together repaints which
trigger at the same time.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 5 +++--
libweston/compositor-fbdev.c| 3 ++-
libweston/compositor
Hi Emil,
On 14 February 2017 at 09:48, Daniel Stone wrote:
> On 13 February 2017 at 23:42, Emil Velikov wrote:
>> Thinking about this a bit more this won't fly either, I'm afraid. In
>> the previous version we'll keep potentially old/unwanted device open,
>&
vices present, will hit this.
Signed-off-by: Daniel Stone
Cc: Emil Velikov
Reported-by: Thierry Reding
Reported-by: Daniel Vetter
---
libweston/compositor-drm.c | 142 +++--
1 file changed, 100 insertions(+), 42 deletions(-)
v5: Document find_primar
Hi,
On 14 February 2017 at 14:09, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 13:18:01 +
> Daniel Stone wrote:
>> Add a (timespec) = (timespec) + (nsec) helper, to save intermediate
>> conversions to nanoseconds in its users.
>
> I recall some comments about usi
Hi,
On 14 February 2017 at 14:24, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 13:18:02 +
> Daniel Stone wrote:
>> +/* Add a millisecond value to a timespec
>> + *
>> + * \param r[out] result: a + b
>> + * \param a[in] base operand as timespec
>> + *
Hi,
On 14 February 2017 at 15:02, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 14:21:17 +
> Daniel Stone wrote:
>> On 14 February 2017 at 14:09, Pekka Paalanen wrote:
>> > On Tue, 14 Feb 2017 13:18:01 +0000
>> > Daniel Stone wrote:
>> >> +static i
vices present, will hit this.
Signed-off-by: Daniel Stone
Reviewed-by: Emil Velikov
Reported-by: Thierry Reding
Reported-by: Daniel Vetter
---
libweston/compositor-drm.c | 145 -
1 file changed, 103 insertions(+), 42 deletions(-)
This is now R-b, bu
Hi Jan,
On 15 February 2017 at 15:05, Jan Engelhardt wrote:
> On Wednesday 2017-02-15 16:02, Derek Foreman wrote:
>>> diff --git a/COPYING b/COPYING
>>> index faefd8f..418b4b4 100644
>>> --- a/COPYING
>>> +++ b/COPYING
>>> @@ -1,8 +1,35 @@
>>> +Copyright © 2008 Tungsten Graphics, Inc.
>>> +Copyri
Hi,
On 16 February 2017 at 14:31, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 13:18:05 +
> Daniel Stone wrote:
>> On startup, we cannot lock on to the repaint timer because it is unknown
>> to us. We deal with this by claiming that the moment of entry into the
>> re
Don't try to dereference the seat if it's NULL.
Signed-off-by: Daniel Stone
---
compositor/screen-share.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/compositor/screen-share.c b/compositor/screen-share.c
index bcb9def..069da1d 100644
--- a/compositor/scre
Destroying the shared seat removes the link from so->seat_list.
Signed-off-by: Daniel Stone
---
compositor/screen-share.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compositor/screen-share.c b/compositor/screen-share.c
index 069da1d..a6f82b1 100644
--- a/composi
If we're building with EGL support generally, but without Cairo/GLESv2,
building the clients fail, because window.c defines the EGL native
types, however platform.h also brings these in.
Signed-off-by: Daniel Stone
Cc: Emil Velikov
Cc: Bryce Harrington
---
clients/window.c | 2 +-
1
Hi,
On 17 February 2017 at 14:22, Pekka Paalanen wrote:
> On Thu, 16 Feb 2017 14:53:39 +
> Daniel Stone wrote:
>> I was about to say 'this doesn't gain us anything', except if all
>> clients do submit and trigger repaint immediately, there's a 7ms grac
Hi,
On 14 February 2017 at 14:09, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 13:18:01 +
> Daniel Stone wrote:
>> +ZUC_TEST(timespec_test, timespec_add_nsec)
>> +{
>> + struct timespec a, r;
>
> An array and a loop to ease readability? :-)
I had a flash
Hi,
On 16 February 2017 at 10:23, Pekka Paalanen wrote:
> On Tue, 14 Feb 2017 13:18:04 +
> Daniel Stone wrote:
>> @@ -2389,34 +2390,35 @@ weston_output_finish_frame(struct weston_output
>> *output,
>> presented_fl
Hi,
On 17 February 2017 at 17:12, Bryce Harrington wrote:
> On Fri, Feb 17, 2017 at 07:50:45AM -0600, Derek Foreman wrote:
>> How about we just remove all the copyrights from COPYING and let
>> anyone that needs to collate this list do it themselves...
>>
>> That way we don't need to remember to
Hi Bryce,
Sorry, totally neglected this whilst travelling.
On 17 February 2017 at 18:09, Bryce Harrington wrote:
> On Fri, Feb 17, 2017 at 05:19:55PM +0000, Daniel Stone wrote:
>> On 17 February 2017 at 17:12, Bryce Harrington wrote:
>> > It seems atypical amongst open sourc
Hi Fabien,
On 6 February 2017 at 16:56, Fabien DESSENNE wrote:
> I remember I used to get « weston-simple-egl -f » working fine.
> But it does not work anymore : nothing is displayed. From the logs I can see
> (among others) zxdg_toplevel_v6.configure and wl_surface.commit
> Testing with another
Hi Pekka,
Thanks for the thoughtful review, as ever.
On 22 February 2017 at 13:45, Pekka Paalanen wrote:
> On Tue, 21 Feb 2017 15:29:09 +0200 Pekka Paalanen wrote:
>> On Fri, 9 Dec 2016 19:57:30 +0000 Daniel Stone
>> wrote:
>> > @@ -452,15 +461,19 @@ drm_output_rele
Hi,
On 21 February 2017 at 13:58, Pekka Paalanen wrote:
> On Fri, 9 Dec 2016 19:57:32 +0000 Daniel Stone wrote:
>> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
>> index af43a15..7dbfc6b 100644
>> --- a/libweston/compositor-drm.c
>> +++ b
Hi Pekka,
On 21 February 2017 at 15:19, Pekka Paalanen wrote:
> On Fri, 9 Dec 2016 19:57:34 +0000 Daniel Stone wrote:
>> @@ -312,6 +316,7 @@ drm_fb_create_dumb(struct drm_backend *b, int width, int
>> height,
>> if (!fb->format->depth || !fb->format->b
Hi,
On 22 February 2017 at 14:08, Pekka Paalanen wrote:
> On Fri, 9 Dec 2016 19:57:36 +0000 Daniel Stone wrote:
> looks like this patch causes an FB to be created from cursor bo-s, and
> this was not done before and the FBs are not used yet. I think this
> requires an explanation i
Hi Arnaud,
On 27 February 2017 at 23:12, Arnaud Vrac wrote:
> On Mon, Feb 27, 2017 at 11:18 PM Daniel Stone wrote:
>> On 6 February 2017 at 16:56, Fabien DESSENNE wrote:
>> > I remember I used to get « weston-simple-egl -f » working fine.
>> > But it does no
Hi,
On 28 February 2017 at 10:59, Pekka Paalanen wrote:
> On Mon, 27 Feb 2017 22:58:48 +0000 Daniel Stone wrote:
>> It's indeed almost certainly a bugfix: if you have one client buffer
>> with multiple views, both of which could be promoted to scanout,
>> you'll
pped for
brevity, and are fixed in the coming revision.
> On Tue, 14 Feb 2017 13:18:06 + Daniel Stone wrote:
>> + if (first_time == 0x)
>> + return;
>> +
>> + /* Now we switch first_time into relative units for the time
Hi Bryce,
On 1 March 2017 at 00:22, Bryce Harrington wrote:
> On Mon, Feb 27, 2017 at 10:17:21PM +0000, Daniel Stone wrote:
>> Yeah, I don't think we're big enough that having separate files makes
>> much sense. What I'm mostly just stuck with is the copyright
&g
Hi,
On 1 March 2017 at 10:29, Pekka Paalanen wrote:
> On Tue, 28 Feb 2017 14:46:21 +0000 Daniel Stone wrote:
>> On 28 February 2017 at 10:59, Pekka Paalanen wrote:
>> > The important thing to document about this change is that is exchanges
>> > a (almost never hit)
Add a (timespec) = (timespec) + (nsec) helper, to save intermediate
conversions to nanoseconds in its users.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
Makefile.am| 10
shared/timespec-util.h | 21 +
tests/timespec-test.c | 124
Hi,
I'm submitting v2 of this series after Pekka's review. At this point,
we now keep all time values in absolute timespec structs, only using
normalisation to nsec for relative comparisons. This required the
addition of subtraction helpers, suggested by Pekka, but reimplemented
to work with signed
previous
state is unknown, e.g. at startup, or coming back from DPMS off.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor-drm.c | 3 +--
libweston/compositor.c | 9 +
2 files changed, 10 insertions(+), 2 deletions(-)
v2: Add assert to verify usage
multiple repaints
together when timing allows.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
v2: No changes.
diff --git a/libweston/compositor.c b/libweston/compositor.c
Add helpers to subtract two timespecs, then return the difference in
either milliseconds or nanoseconds. These will be used to compare
timestamps during the repaint cycle.
Signed-off-by: Daniel Stone
Suggested-by: Pekka Paalanen
---
shared/timespec-util.h | 26 ++
tests
Add a (timespec) = (timespec) + (msec) helper, to save intermediate
conversions in its users.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
shared/timespec-util.h | 12
tests/timespec-test.c | 11 +++
2 files changed, 23 insertions(+)
v2: Trivially
weston_output_finish_frame() and the backends
than seems currently appropriate.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 20 +---
libweston/compositor.h | 9 -
2 files changed, 25 insertions(+), 4 deletions(-)
v2: New in this revision. Required by change to avoid
iterates
all of them, scheduling the repaint for the first available time.
Signed-off-by: Daniel Stone
Cc: Mario Kleiner
Cc: Pekka Paalanen
---
libweston/compositor.c | 113 -
libweston/compositor.h | 6 ++-
2 files changed, 88 insertions(+), 31
It is only used as a binary value.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 2 +-
libweston/compositor-fbdev.c | 2 +-
libweston/compositor.c | 4 ++--
libweston/compositor.h | 5 -
4 files changed, 8 insertions(+), 5 deletions(-)
v2: New in this revision
Paralleling timespec_to_nsec, converts to milliseconds.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor.c | 2 +-
shared/timespec-util.h | 11 +++
tests/timespec-test.c | 9 +
3 files changed, 21 insertions(+), 1 deletion(-)
v2: No changes
Implement new repaint_begin and repaint_flush hooks inside
weston_backend, allowing backends to gang together repaints which
trigger at the same time.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 5 +++--
libweston/compositor-fbdev.c| 3 ++-
libweston/compositor
they miss by multiples of the repaint window, adjust
them until the next repaint timestamp is in the future.
I was unable to find from discussion of the original development whether
or not this is desirable; I can see an argument both ways. Hence, RFC
tag.
Signed-off-by: Daniel Stone
Cc: Pekka
up by some asserts.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 20 +---
libweston/compositor.h | 10 +-
2 files changed, 26 insertions(+), 4 deletions(-)
v3: Only this patch has changed in this revision of the series.
Tri-state wasn't actually enou
Rather than duplicating knowledge of pixel formats across several
components, create a custom central repository.
Differential Revision: https://phabricator.freedesktop.org/D1511
Signed-off-by: Daniel Stone
---
Makefile.am | 2 +
libweston/pixel-formats.c | 403
Differential Revision: https://phabricator.freedesktop.org/D1512
Signed-off-by: Daniel Stone
---
libweston/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/libweston/meson.build b/libweston/meson.build
index db4347f..8127602 100644
--- a/libweston/meson.build
+++ b/libweston
Make drm_output_set_cursor more deterministic, by calculating more state
and performing more plane manipulation, inside
drm_output_prepare_cursor_view.
Differential Revision: https://phabricator.freedesktop.org/D1485
Signed-off-by: Daniel Stone
Reviewed-by: Derek Foreman
---
libweston
Revision: https://phabricator.freedesktop.org/D1488
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor-drm.c | 55 ++
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston/composi
#x27; is used as the last framebuffer for which we know
configuration has been fully applied, i.e. CRTC set executed or pageflip
requested and event received.
Rename these members to fb_current and fb_pending, doing some small
reordering of drm_output whilst in the vicinity.
Signed-off-by: Daniel
Hi all,
Building on the previous series, as well as the global repaint timer
series which I've just sent out for more review (thanks Pekka!), here
is v9 of atomic. The most interesting feature is that it is now atomic.
As mentioned in the patch changelogs, in order to use the atomic API
correctly,
part of
output->state_last, and is not directly visible from the plane itself.
Signed-off-by: Daniel Stone
Differential Revision: https://phabricator.freedesktop.org/D1412
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 334 +
1 f
601 - 700 of 2140 matches
Mail list logo
