Hi, On 8 February 2017 at 10:23, Pekka Paalanen <[email protected]> wrote: > On Tue, 7 Feb 2017 17:17:41 -0800 > Bryce Harrington <[email protected]> wrote: >> Breaks the build on older linux kernels. >> >> CC clients/weston_simple_dmabuf_v4l-simple-dmabuf-v4l.o >> clients/simple-dmabuf-v4l.c:358:25: warning: ‘struct v4l2_query_ext_ctrl’ >> declared inside parameter list [enabled by default] >> const int expected_value) >> ^ >> clients/simple-dmabuf-v4l.c:358:25: warning: its scope is only this >> definition or declaration, which is probably not what you want [enabled by >> default] >> clients/simple-dmabuf-v4l.c: In function ‘check_v4l2_control_bool’: >> clients/simple-dmabuf-v4l.c:363:18: error: dereferencing pointer to >> incomplete type >> ctrl.id = qectrl->id; > > reverting is fine by me, and if you really want, reapplying this patch > can also be delayed for the next development cycle. > > It looks like ext_ctrl was introduced in > > commit 5082c2417841e64df975789011e182ce99a9dacd > Author: Hans Verkuil <[email protected]> > Date: Tue Jun 10 04:14:50 2014 -0300 > > [media] videodev2.h: add struct v4l2_query_ext_ctrl and > VIDIOC_QUERY_EXT_CTRL > > which was first released in 3.17.
Ouch. That's a pretty bad break to have released beta with. :( I've reverted this for now: To ssh://git.freedesktop.org/git/wayland/weston a32986ecf..d5fa09090 push -> master We can reapply when we figure out how best to do it in a way which works on ancient kernels as well. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
