Hi Armin, On 10 November 2016 at 10:20, Armin Krezović <[email protected]> wrote: > On 09.11.2016 15:43, Daniel Stone wrote: >> On 9 October 2016 at 22:48, Armin Krezović <[email protected]> wrote: >>> diff --git a/compositor/main.c b/compositor/main.c >>> index 320305c..ffeadfb 100644 >>> --- a/compositor/main.c >>> +++ b/compositor/main.c >>> @@ -78,6 +78,7 @@ struct wet_compositor { >>> struct weston_config *config; >>> struct wet_output_config *parsed_options; >>> struct wl_listener pending_output_listener; >>> + bool drm_use_current_mode; >>> }; >> >> I'm fairly confused about this one, though I freely admit I didn't >> track the libweston config work, so may have missed something. >> >> What makes --use-current-mode special enough that it should be the >> only such option inside struct wet_compositor? What makes it different >> to, say, use_pixman, which lives in the DRM backend? > > The thing is, --use-pixman flag is used in many places throughout the backend, > while --use-current-mode is only used by function that sets the mode. That > function is now called by the user, and is required to be called before > enabling the output, whereas it was previously done in the backend itself, and > it got the necessary configuration values by calling into an user-defined > function > (configure output -> user defined function -> set mode).
We were both completely right: everything you've said above is correct, and I was right when I said that I may have missed something. ;) To ssh://git.freedesktop.org/git/wayland/weston e23697f59..605ac8e68 push -> master Thanks! Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
