> Date: Tue, 24 Jul 2018 13:29:52 -0700
> From: Bryan Vyhmeister
>
> Do we want the WD Black NVMe identified or should we just leave it out?
> Also, if you want the SSD to not be identified, should at least the
> vendor be added? Thanks again.
Committed, Thanks
> Index: sys/dev/pci/pcidevs
> ==
Do we want the WD Black NVMe identified or should we just leave it out?
Also, if you want the SSD to not be identified, should at least the
vendor be added? Thanks again.
Bryan
Index: sys/dev/pci/pcidevs
===
RCS file: /cvs/src/sys/d
On Sun, Jul 22, 2018 at 11:50:07AM -0600, Theo de Raadt wrote:
> Better.
>
> It is important to not fall into the trap of doing marketing for
> vendors. But also keep in mind another product is likely months away,
> and then what to you do?
True. Good point. I also did not think about what kette
Better.
It is important to not fall into the trap of doing marketing for
vendors. But also keep in mind another product is likely months away,
and then what to you do?
Mark Kettenis wrote:
> > Date: Sun, 22 Jul 2018 10:14:11 -0700
> > From: Bryan Vyhmeister
> >
> > Here is the output from dm
Bryan Vyhmeister wrote:
> On Sun, Jul 22, 2018 at 11:19:00AM -0600, Theo de Raadt wrote:
> > This is unreasonable.
> >
> > 1. Can I add High-performance to every 2nd line in this file? After all,
> >I bet everyone would love to claim that for their hardware.
>
> I'm sure. That's the only w
On Sun, Jul 22, 2018 at 07:36:32PM +0200, Mark Kettenis wrote:
> And it seems that at least the 500G an 1TB models have been marketed
> as SanDisk Extreme PRO:
>
>
> https://www.anandtech.com/show/12543/the-western-digital-wd-black-3d-nand-ssd-review
>
> The names are a bit long. Googling for
On Sun, Jul 22, 2018 at 11:19:00AM -0600, Theo de Raadt wrote:
> This is unreasonable.
>
> 1. Can I add High-performance to every 2nd line in this file? After all,
>I bet everyone would love to claim that for their hardware.
I'm sure. That's the only way the generation one and two hardware a
> Date: Sun, 22 Jul 2018 10:14:11 -0700
> From: Bryan Vyhmeister
>
> Here is the output from dmesg before and after.
>
> nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev 0x00:
> msi, NVMe 1.3
> nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789
>
> nvme0 a
This is unreasonable.
1. Can I add High-performance to every 2nd line in this file? After all,
I bet everyone would love to claim that for their hardware.
2. These product strings get embedded *into the kernel*, bloating it.
3. As a result, we use short boring names, or highly descriptive
Here is the output from dmesg before and after.
nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev 0x00:
msi, NVMe 1.3
nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789
nvme0 at pci3 dev 0 function 0 "SanDisk WD Black High-performance NVMe SSD" rev
0x00: msi
On Fri, Jul 20, 2018 at 11:09:09AM +0200, Mark Kettenis wrote:
> Right. It's best if the names are unique and using
> pre-merger/takeover company names typically helps with that.
If that is the consensus then here is a diff. The WD Black
High-performance NVMe SSDs were never marketed under SanDis
> Date: Thu, 19 Jul 2018 18:36:18 +0100
> From: Stuart Henderson
>
> On 2018/07/19 10:00, Bryan Vyhmeister wrote:
> > I am wanting to add the WD Black High-performance NVMe SSD PCI
> > IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a
> > while back but the vendor ID is 15b7 wh
On Thu, Jul 19, 2018 at 08:32:45PM +0200, Mike Belopuhov wrote:
> But at this point the origin of new devices is WD. I think since it's
> a new addition it should go by WD to reduce potential confusion in the
> future.
I would tend to agree. It would look rather strange to have a Sandisk WD
Black
On 19 July 2018 at 19:36, Stuart Henderson wrote:
>
> On 2018/07/19 10:00, Bryan Vyhmeister wrote:
> > I am wanting to add the WD Black High-performance NVMe SSD PCI
> > IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a
> > while back but the vendor ID is 15b7 which is Sandisk C
On 2018/07/19 10:00, Bryan Vyhmeister wrote:
> I am wanting to add the WD Black High-performance NVMe SSD PCI
> IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a
> while back but the vendor ID is 15b7 which is Sandisk Corp. The product
> itself is WD Black High-performance NVMe S
I am wanting to add the WD Black High-performance NVMe SSD PCI
IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a
while back but the vendor ID is 15b7 which is Sandisk Corp. The product
itself is WD Black High-performance NVMe SSD and is labeled as Western
Digital. The vendor ID o
16 matches
Mail list logo
