Better. It is important to not fall into the trap of doing marketing for vendors. But also keep in mind another product is likely months away, and then what to you do?
Mark Kettenis <mark.kette...@xs4all.nl> wrote: > > Date: Sun, 22 Jul 2018 10:14:11 -0700 > > From: Bryan Vyhmeister <br...@bsdjournal.net> > > > > Here is the output from dmesg before and after. > > > > nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev > > 0x00: msi, NVMe 1.3 > > nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789 > > > > nvme0 at pci3 dev 0 function 0 "SanDisk WD Black High-performance NVMe SSD" > > rev 0x00: msi, NVMe 1.3 > > nvme0: WDS500G2X0C-00L350, firmware 101110WD, serial 181123456789 > > > > As further confirmation that perhaps it should stay SanDisk, the other > > device other than 5001 and 5002 that is listed for vendor 15b7 is the > > Skyhawk Series NVME SSD which was sold by Western Digital as a SanDisk > > Skyhawk SSD. Patch included below. > > And it seems that at least the 500G an 1TB models have been marketed > as SanDisk Extreme PRO: > > > https://www.anandtech.com/show/12543/the-western-digital-wd-black-3d-nand-ssd-review > > The names are a bit long. Googling for "WD Black High-performance > NVMe SSD" doesn't yield any meaningful results. I'd just call both > "WD Black NVMe". WD/SanDisk doesn't seem to differentiate between > controller generations and our nvme(4) driver prints the model number > anyway so it is not a big issue. > > > Index: sys/dev/pci/pcidevs > > =================================================================== > > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > > retrieving revision 1.1854 > > diff -u -p -r1.1854 pcidevs > > --- sys/dev/pci/pcidevs 8 Jul 2018 17:34:07 -0000 1.1854 > > +++ sys/dev/pci/pcidevs 20 Jul 2018 19:39:47 -0000 > > @@ -279,6 +279,7 @@ vendor BLUESTEEL 0x15ab Bluesteel > > vendor VMWARE 0x15ad VMware > > vendor ZOLTRIX 0x15b0 Zoltrix > > vendor MELLANOX 0x15b3 Mellanox > > +vendor SANDISK 0x15b7 SanDisk > > vendor AGILENT 0x15bc Agilent > > vendor QUICKNET 0x15e2 Quicknet Technologies > > vendor NDC 0x15e8 National Datacomm > > @@ -6975,6 +6976,10 @@ product SANGOMA A10X 0x0300 A10x > > product DIGI NEO4 0x00b0 Neo-4 > > product DIGI NEO8 0x00b1 Neo-8 > > product DIGI NEO8_PCIE 0x00f0 Neo-8 > > + > > +/* SanDisk (Western Digital) */ > > +product SANDISK WDSXXXG1X0C 0x5001 WD Black NVMe SSD > > +product SANDISK WDSXXXG2X0C 0x5002 WD Black High-performance NVMe > > SSD > > > > /* Schneider & Koch (SysKonnect) */ > > product SCHNEIDERKOCH FDDI 0x4000 FDDI > > > > >