On Sun, Jul 22, 2018 at 11:50:07AM -0600, Theo de Raadt wrote: > Better. > > It is important to not fall into the trap of doing marketing for > vendors. But also keep in mind another product is likely months away, > and then what to you do?
True. Good point. I also did not think about what kettenis@ pointed out about nvme(4) printing the model number as well. G1 is first generation and G2 is second. Makes perfect sense not to have anything more than "WD Black NVMe" which also lines up with Samsung entries in pcidevs. Bryan Index: sys/dev/pci/pcidevs =================================================================== RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1854 diff -u -p -r1.1854 pcidevs --- sys/dev/pci/pcidevs 8 Jul 2018 17:34:07 -0000 1.1854 +++ sys/dev/pci/pcidevs 20 Jul 2018 19:39:47 -0000 @@ -279,6 +279,7 @@ vendor BLUESTEEL 0x15ab Bluesteel vendor VMWARE 0x15ad VMware vendor ZOLTRIX 0x15b0 Zoltrix vendor MELLANOX 0x15b3 Mellanox +vendor SANDISK 0x15b7 SanDisk vendor AGILENT 0x15bc Agilent vendor QUICKNET 0x15e2 Quicknet Technologies vendor NDC 0x15e8 National Datacomm @@ -6975,6 +6976,10 @@ product SANGOMA A10X 0x0300 A10x product DIGI NEO4 0x00b0 Neo-4 product DIGI NEO8 0x00b1 Neo-8 product DIGI NEO8_PCIE 0x00f0 Neo-8 + +/* SanDisk (Western Digital) */ +product SANDISK WDSXXXG1X0C 0x5001 WD Black NVMe +product SANDISK WDSXXXG2X0C 0x5002 WD Black NVMe /* Schneider & Koch (SysKonnect) */ product SCHNEIDERKOCH FDDI 0x4000 FDDI