On 2018/07/19 10:00, Bryan Vyhmeister wrote: > I am wanting to add the WD Black High-performance NVMe SSD PCI > IDs to pcidevs and I am not sure how to proceed. WD bought Sandisk a > while back but the vendor ID is 15b7 which is Sandisk Corp. The product > itself is WD Black High-performance NVMe SSD and is labeled as Western > Digital. The vendor ID of 15b7 does not exist in our pcidevs at this > point. Should I create a diff as 15b7 being Sandisk or Western Digital? > There are only two products listed under 15b7 that I have found (2001 > and 5001) and this SSD I have is a new (third) one (5002). My intention > is to add the information for 5001 and 5002 which are the original WD > Black NVMe SSD and the new WD Black High-performance NVMe SSD. I have > both 500GB and 1TB versions which share the same product ID as expected. > Output from dmesg and pcidump is below.
AFAIK typically we list under the original vendor name though I'm sure there are exceptions to this. My vote would be for listing as Sandisk. > > Bryan > > > > nvme0 at pci3 dev 0 function 0 unknown vendor 0x15b7 product 0x5002 rev 0x00: > msi, NVMe 1.3 > nvme0: WDS100T2X0C-00L350, firmware 101110WD, serial 181123456789 > > > 4:0:0: unknown unknown > 0x0000: Vendor ID: 15b7 Product ID: 5002 > 0x0004: Command: 0007 Status: 0010 > 0x0008: Class: 01 Subclass: 08 Interface: 02 Revision: 00 > 0x000c: BIST: 00 Header Type: 00 Latency Timer: 00 Cache Line Size: 00 > 0x0010: BAR mem 64bit addr: 0x00000000e0000000/0x00004000 > 0x0018: BAR empty (00000000) > 0x001c: BAR empty (00000000) > 0x0020: BAR mem 64bit addr: 0x00000000e0004000/0x00000100 > 0x0028: Cardbus CIS: 00000000 > 0x002c: Subsystem Vendor ID: 15b7 Product ID: 5002 > 0x0030: Expansion ROM Base Address: 00000000 > 0x0038: 00000000 > 0x003c: Interrupt Pin: 01 Line: ff Min Gnt: 00 Max Lat: 00 > 0x0080: Capability 0x01: Power Management > State: D0 > 0x0090: Capability 0x05: Message Signalled Interrupts (MSI) > 0x00b0: Capability 0x11: Extended Message Signalled Interrupts (MSI-X) > 0x00c0: Capability 0x10: PCI Express > Link Speed: 5.0 / 8.0 GT/s Link Width: x4 / x4 > 0x0100: Enhanced Capability 0x01: Advanced Error Reporting > 0x0150: Enhanced Capability 0x03: Device Serial Number > 0x01b8: Enhanced Capability 0x18: Latency Tolerance Reporting > 0x0300: Enhanced Capability 0x19: Secondary PCIe Capability > 0x0900: Enhanced Capability 0x1e: L1 PM >
