Hi,
with the patch that unlocks sendmsg and sendto, I get the following
KERNEL_ASSERT_LOCKED (transcribed from a photo of the screen) when I
start avahi_daemon:
panic: kernel diagnostic assertion "_kernel_lock_held()" failed: file
"/usr/src/sys/net/if.c", line 1382
Stopped at db_enter+0x12: popq
On Thu, Nov 16, 2017 at 11:13:04AM +1000, David Gwynne wrote:
>
> > On 16 Nov 2017, at 7:23 am, Gregor Best wrote:
> >
> > Hi,
> >
> > On Mon, Nov 13, 2017 at 01:47:01PM +1000, David Gwynne wrote:
> >> [...]
> >> pools maintain count of how m
Hi,
On Mon, Nov 13, 2017 at 01:47:01PM +1000, David Gwynne wrote:
> [...]
> pools maintain count of how many times they failed to provide an
> allocation. you can watch this with vmstat -m or systat pool.
> however, we could use that to populate mb_drops too.
> [...]
That's certainly smarter than
Hi Martin,
On Sun, Nov 12, 2017 at 03:40:59PM +0100, Martin Pieuchot wrote:
> [...]
> It does, some comments below.
> [...]
Wonderful.
> [...]
> This would be an approximation because it might happen that after
> returning NULL the second pool_get(9) won't sleep. However I think
> it's the way
Hi people,
while reading around in /sys/kern/uipc_mbuf.c to try to track down a
problem with my iwm(4) that seems to correlate with mbuf allocation
failures, I noticed that the MBSTAT_DROPS counter and its friends
MBSTAT_{WAIT,DRAIN} don't seem to get increased anywhere in /sys.
Does the patch be
On Tue, Dec 27, 2016 at 01:00:54AM +0100, Gregor Best wrote:
> On Mon, Dec 26, 2016 at 08:44:47PM +0100, Stefan Sperling wrote:
> > [...]
> > E.g. at 33C3 there are APs with: RxMCS 0xf8f8f800
> >
> > The diff below makes OpenBSD clients work in 11n m
On Mon, Dec 26, 2016 at 08:44:47PM +0100, Stefan Sperling wrote:
> [...]
> E.g. at 33C3 there are APs with: RxMCS 0xf8f8f800
>
> The diff below makes OpenBSD clients work in 11n mode on such networks
> by relaxing our "supported MCS" 11n feature check.
> [...]
To go along with the 33c
Hi,
On Mon, Nov 07, 2016 at 03:55:29PM +0100, Gregor Best wrote:
> [...]
> I can't reproduce the problem anymore. If it does turn up again, I'll
> collect the output of route monitor. In the mean time, thanks a bunch
> for your help :)
> [...]
It happened again, thi
Hi,
On Mon, Nov 07, 2016 at 09:12:12AM +0100, Martin Pieuchot wrote:
> [...]
> Could you capture the route changes via "# route monitor"? I'd like
> to know if the 'bad gateway value' message is triggered by userland
> or the kernel.
> [...]
I can't reproduce the problem anymore. If it does turn
Hi Martin,
On Fri, Nov 04, 2016 at 11:44:14AM +0100, Martin Pieuchot wrote:
>
> That's the problem. The entry is flagged as RTF_LLINFO but contains an
> IPv6 address.
>
> Do you see any other errors in /log/messages?
>
Only
nd6_rtrequest: bad gateway value: tap0
immediately before t
Hi,
On Mon, Jun 06, 2016 at 07:16:20PM +0200, Martin Pieuchot wrote:
> [...]
> + if (rt->rt_gateway->sa_family != AF_LINK) {
> + printf("%s: something odd happens\n", __func__);
> + m_freem(m);
> + return (EINVAL);
> + }
> [...]
I noticed that since a w
On Sun, Oct 23, 2016 at 03:42:59PM -0600, Theo de Raadt wrote:
> [...]
> I ask you to figure out logical conditions under which this should
> happen, or if some interaction is wrong.
> [...]
Understood. I'll try tracking down the exact circumstances of the issue
and come back with a better diff.
Hi people,
the patch below the signature makes the touchpad on my new laptop work.
pms(4) didnt' attach previously because the AUX slot on the keyboard was
not enabled.
Since the patch isn't a proper solution, I was wondering whether there's
a quirks mechanism for pckbc, similar to what e.g. some
Hi,
> [...]
> This seems to work fine with inteldrm, a 1280x800 display and
> [...]
Good to hear I didn't break anything :)
> [...]
> No idea either... if you wanted to reduce the risk of breakage, I
> guess you could limit the resolution only if -O is not passed.
> [...]
I've read up on Xv a b
Hi,
this is another patch to video(1). It removes the logic that forces the
video grab frame size to be <= the size of the Xv adaptor. This allows
me to grab and view frames that are 1280x1024 on my 1440x900 screen. Xv
properly scales and stretches the window content, so there's nothing
that gets
On Thu, Sep 15, 2016 at 02:57:16PM +0200, Jeremie Courreges-Anglas wrote:
> [...]
> I think this is the right way to work around the problem and make
> video(1) more user-friendly. However, I doubt that the manpage bits are
> relevant. So I'd like to commit only the .c diff.
>
> Thoughts?
> [...
Hi,
video(1) fails to read files that were previously recorded with -o
somefile, unless -g (to select read(2) as the input method) is also
specified:
$ video -o foo
^C
$ video -i foo
video: ioctl VIDIOC_REQBUFS: Bad file descriptor
$ video -g -i foo
[ plays the file ]
mmap-mode
On Fri, Sep 02, 2016 at 03:36:50PM +0200, Michal Mazurek wrote:
> Here is a working futex implementation for OpenBSD. This diff touches
> the kernel and librthread.
>
> * get rid of tickets from rthreads, they were getting in the way and are
> unused anyway
> * replace all struct _spinlock wit
On Mon, Aug 22, 2016 at 05:03:34PM +0200, Otto Moerbeek wrote:
> On Mon, Aug 22, 2016 at 05:00:12PM +0200, Otto Moerbeek wrote:
>
> > Hmm, indeed, looking into it.
>
> Fixed diff now online,
> [...]
With that one, Firefox and Chromium work fine. There's a problem with
Gimp though:
$ gimp
gimp(5
Hi,
On Mon, Aug 22, 2016 at 08:21:08AM +0200, Otto Moerbeek wrote:
> [...]
> New diff posted in http://www.drijf.net/openbsd/malloc.
>
> The intention is that this is close to commitable. But while a
> straight merge of most recent diff with the current src, a bug
> might have crept in. So beware
Hi Mayukh,
On Sun, May 22, 2016 at 11:17:18PM -0700, Mayukh Bose wrote:
> [...]
> Here's my patch to fix this:
> [...]
Ironically, your patch about whitespace handling has mangled whitespace.
Can you send it again? Maybe your MUA tried sending it as some sort of
formatted text instead of plain te
On Mon, May 02, 2016 at 01:25:22PM +0100, Jason McIntyre wrote:
> On Mon, May 02, 2016 at 01:27:50PM +0200, Henning Brauer wrote:
> > [...]
> > technically, hostname.if doesn't support ip/len notation. It is a
> > notation that the hostname parser doesn't grok and just passes on to
> > ifconfig.
Hi,
/etc/hostname.if supports IPv4 addresses with a CIDR prefix length:
inet 10.0.0.1/16
which is not documented in hostname.if(5). The attached patch fixes
that. I'm not sure whether describing '/prefixlen' before 'netmask' is a
good idea, but it matches the order things have to be spec
On Sun, Feb 21, 2016 at 10:56:43PM +0200, li...@wrant.com wrote:
> [...]
> Others followed suit too, HL_340 bricked clones here. Not sure how to
> resolve the 0x mapping uniformly. Have to invent a separate twerp
> category.
> [...]
USB product IDs only need to be unique under the ven
On Sun, Feb 21, 2016 at 12:41:06PM -0700, Theo de Raadt wrote:
> It makes no sense to renumber the FT232_1 entry. That is just creating
> churn.
>
> As to the 0x entry, I'm wondering whether it should be named something
> like the following, as a historical reminder:
>
> +product FTDI FT232_
Hi people,
some time back, FTDI released a driver for their USB RS232 adaptors that
changed the USB device ID of aftermarket devices to 0x, so that they
wouldn't work on any machine, even with the older FTDI drivers, from
then on ([0] has further info on that).
The fix for that is relati
Hi David and tech@,
I just tried the patch on a December 28 snapshot and got a watchdog
timeout while running iperf. Just the snapshot without the patch
survives iperf without a timeout.
The device in question is this one:
em0 at pci1 dev 0 function 0 "Intel 82583V" rev 0x00: msi, addres
On Fri, Jan 01, 2016 at 12:08:53AM +1000, David Gwynne wrote:
> [...]
> tests? ok?
> [...]
I'll test it tonight in my hackerspace. There's never a better time for
testing network patches than new years eve, since people will be drunk
enough to ignore occasional glitches when I restart the router :
Hi Stefan,
On Sun, Dec 20, 2015 at 07:59:19PM +0100, Stefan Sperling wrote:
> On Sat, Dec 19, 2015 at 01:08:26PM +0100, Stefan Sperling wrote:
> > On Fri, Dec 18, 2015 at 05:40:39PM -0500, David Hill wrote:
> > > With sthen@'s patch I can associate, dhcp, and use net.
> >
> > Here's an updated iw
Hi Stefan,
On Wed, Dec 16, 2015 at 03:35:22PM +0100, Stefan Sperling wrote:
> This diff adds 11n MCS 0-7 with A-MPDU and A-MSDU Rx to the iwn(4)
> driver.
> [...]
Whoo! Thanks a lot for your hard work :)
> [...]
> Please post here or let me know in private which hardware you're.
> testi
Hi people,
the following patch allows vi (and ex) to do tilde expansion without
forking off a shell. The algorithm is similar to the one in mg, modulo
adaptions for the way vi handles line buffers and such. This allows
editing files like `~/foobar` in secure (-S) mode, where fork and
Hi people,
httpd needs to pledge `dns' for name resolution to work while loading
the configuration:
# cat /tmp/test.conf
server "default" {
listen on imnotlocal port 80
}
# httpd -dnvf /tmp/test.conf
Abort trap
# dmesg | tail -n1
Hi Mike,
on amd64 with a snapshot from today, I'm getting (transcribed):
kernel: page fault trap, code=0
ddb{1}> trace
vm_writepage() at vm_writepage+0x158
VOP_IOCTL() at VOP_IOCTL+0x44
vn_ioctl() at vn_ioctl+0x77
sys_ioctl() at sys_ioctl+0x196
On Mon, Nov 23, 2015 at 01:31:11AM -0700, Anthony J. Bentley wrote:
> [...]
> I've passed this diff around privately before and gotten a tepid
> response, but it was pointed out to me that it would fit better on tech@.
> [...]
Yes, please.
--
Gregor
On Mon, Nov 23, 2015 at 01:36:00AM -0700, Anthony J. Bentley wrote:
> [...]
In addition to this, my ~/.exrc also sets cedit to tab. Would this
make sense here as well? Currently it's disabled by default, but
IMHO it's a useful feature for longer editing sessions.
--
Gregor
On Mon, Nov 16, 2015 at 12:05:12AM +1000, David Gwynne wrote:
> On Fri, Nov 13, 2015 at 10:18:51AM -0500, Sonic wrote:
> > On Wed, Nov 11, 2015 at 9:20 AM, Gregor Best wrote:
> > > I've done some further testing and I think I've narrowed it down to the
> > >
Hi Alexis,
On Wed, Nov 11, 2015 at 08:11:15PM +, Alexis VACHETTE wrote:
> [...]
> Even with heavy network load ?
> [...]
So far, yes. I've saturated the device for about 45 Minutes with
something like this (the other end is my laptop):
## on the router
$ dd if=/dev/zero bs=8k
Hi people,
inspired by someone on Hackernews talking about how hard it would be to
properly pledge an editor, here's a patch to pledge Vi and Ex.
I'd like to go a bit deeper than this patch though: In addition to the
-S option which enables "secure mode", Vi and Ex have a -R switch, which
enables
I've done some further testing and I think I've narrowed it down to the
"Unlocking em(4) a bit further"-patch [0]. With the patch reverted, I
haven't seen any watchdog timeouts yet. I'm currently running the router
with the patch reverted to make sure the timeouts don't happen again.
[0]: https://
On Mon, Nov 02, 2015 at 09:29:20PM +0100, Gregor Best wrote:
> [...]
> Looks good so far. I've run a few light tests and the usual load that
> caused the timeouts before, haven't seen any yet.
> [...]
I just checked back on the router and it seems that the patch doesn&#
On Sun, Nov 08, 2015 at 06:57:23PM +0100, Gregor Best wrote:
> [...]
> If it helps debugging this, I can give SSH access to the router,
> provided that reboots don't happen between 18:00 and 02:00 German time
> too often, since that's when we have larger amounts of visitor
On Mon, Nov 02, 2015 at 08:11:30PM +0100, Mark Kettenis wrote:
> Can those that are experiencing watchdog timeouts check if the diff
> below gets rid of them?
> [...]
Looks good so far. I've run a few light tests and the usual load that
caused the timeouts before, haven't seen any yet.
For the re
On Sun, Oct 25, 2015 at 08:20:50AM -0700, Philip Guenther wrote:
> [...]
> This looks like the result of applying the diff but not running config
> [...]
Thanks for the clue bat. It's working fine on a Thinkpad T400.
--
Gregor
Hi Mark,
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote:
> [...]
> This diff needs to be tested on a wide range of hardware. So if you
> have a machine with inteldrm(4), please give it a shot. I'm
> particularly interested in testing on an x40.
> [...]
I got a UVM fault with the
Nice to see rubber duck debugging working. The attached patch seems to
be enough
--
Gregor
--
Index: smtpd.c
===
RCS file: /home/cvs/src/usr.sbin/smtpd/smtpd.c,v
retrieving revision 1.250
diff -u -p -u -r1.250 smtpd.c
--- sm
Hi people,
I've noticed smtpd's deliver_maildir getting killed on syscall 15
(chmod) with the latest snapshot. I've rebuilt and core dumped it as
described by Sebastien and this is the backtrace I got:
#0 0x1d7e8175149a in chmod () at :2
#1 0x1d7c72744ffe in mkdirs (path=0x7f7dd0d0
Hi people,
identd's parent process needs to pledge "id" so it can call setgroups
and friends later.
--
Gregor
Index: identd.c
===
RCS file: /mnt/media/cvs/src/usr.sbin/identd/identd.c,v
retrieving revision 1.32
diff -u -p -
On Fri, Oct 02, 2015 at 01:49:13PM +0200, Tim Kuijsten wrote:
> [...]
> that's a 403..
Whoops, fixed.
--
Gregor
--
Kirkland, Illinois, law forbids bees to fly over the village or through
any of its streets.
On Thu, Oct 01, 2015 at 06:55:21AM -0600, Theo de Raadt wrote:
> For those who are curious, this is the tame diff which is currently
> in snapshots. Yes, we are asking for testing and feedback.
> [...]
I'm getting
ntpd(): syscall 97
with the patch applied. Kernel and ntpd sources ar
On Fri, Sep 25, 2015 at 01:32:07PM +0200, Mark Kettenis wrote:
> [...]
> I'm already onto that one. For some reason the G45/GM45 chipset goes
> down a codepath that does a null-pointer dereference.
> [...]
If there's any way I can help, please let me know.
--
Gregor
Hi people,
I just updated to a recent snapshot and once inteldrm attaches to my
vga1 at pci0 dev 2 function 0 "Intel GM45 Video" rev 0x07
the screen turns blank. Disabling inteldrm with boot -c prevents that,
but then of course X won't start. I have already tried reverting the
"Enable MS
Hi people,
the following patch changes the prompt for the 'Partition size' and
'Partition offset' prompts in fdisk to show the range of allowed values
and display the raw value as well when showing an error for out of
bounds values.
Index: misc.c
==
On Wed, Aug 26, 2015 at 08:42:31AM +0200, Renaud Allard wrote:
> [...]
> + fprintf(stderr, "usage: doas [-ans] [-C config] [-u user] command
> [args]\n");
> [...]
The usage string should probably be
"usage: doas [-ns] [-a style] [-C config] [-u user] command [args]"
and the new option sho
if it is added, it probably wants to be disabled for the ramdisk.
> [...]
I've attached an updated patch, in case this is still interesting to
someone. Do I need to add anything other than `#ifdef SMALL' in the
appropriate places?
--
Gregor Best
--
Index: clparse.c
===
On Sun, Jul 19, 2015 at 03:31:33PM +, Florian Obser wrote:
> [...]
> Oh god, yes please. I always wanted to write this diff myself ;)
> More comments in the diff below.
> [...]
Great to read. I've attached an updated patch.
--
Gregor Best
ackerspace, etc...), I can't use a statically configured
fallback forward zone for all my requests. Manually calling using
unbound-control to change the forward DNS became too annoying, so I
wrote this patch.
Does the patch make sense in OpenBSD or should I keep it as a local
change?
--
On Tue, Jul 14, 2015 at 09:57:45AM -0600, Todd C. Miller wrote:
> [...]
> Shouldn't this be:
>
> p = (p - *store) + newstore;
> [...]
Of course, that makes way more sense. An amended patch is attached.
--
Gregor
Index: misc.c
==
Hi people,
there's a tiny bug in find that causes a segmentation fault in find. The
following C program can be used to replicate a pathological directory
structure:
#include
#include
#include
int main(void) {
char s[256]; int i;
m
#x27;ve been listening to music all day and am currently watching a movie
with this, no regressions so far. This is with
$ dmesg | grep -E '(audio|azalia)'
azalia0 at pci0 dev 27 function 0 "Intel 82801I HD Audio" rev 0x03: msi
azalia0: codecs: Conexant CX20561
audio0 at azal
, you're right.
I think going with the established name is a better idea. I've attached
an amended patch.
--
Gregor Best
Index: dev/usb/umodem.c
===
RCS file: /mnt/media/cvs/src/sys/dev/usb/umodem.c,v
retrieving revi
for a few days now, but only with a
baudrate of 115200, which seems to work fine.
--
Gregor Best
Index: dev/usb/umodem.c
===
RCS file: /mnt/media/cvs/src/sys/dev/usb/umodem.c,v
retrieving revision 1.57
diff -u -p -u -r1.57 umo
On Sun, Jul 27, 2014 at 10:06:12PM +0100, Stuart Henderson wrote:
> [...]
> Nice, I like that a lot. What do you think Claudio?
> [...]
Ping. Are there remaining issues with the patch?
--
Gregor Best
Ping.
--
Gregor Best
Ping? Are there remaining issues with the patch or should I leave
you guys alone until the release stress is over?
--
Gregor Best
5678 0 0 0 NeverActive
some-peer 12345 0 0 0 NeverConnect
--
Gregor Best
Index: bgpctl.c
===
RCS file: /mnt/media/cvs/src/usr.sbin/bgpctl/bgpctl.c,v
retrieving revi
> PS: you only need 11 chars and not 12 for AS-DOT notation
> [...]
Whoops, off by one.
The attached patch addresses the issues you pointed out by removing the
OutQ field and increasing the AS column width by 3 characters. The
output fits into 77 characters now.
-
0 00:07:51364
peer 264734.12578252295 0 00:40:53365
peer 3 64828 17547 13467 0 3d17h36m325
--
Gregor Best
Index: bgpctl.c
===
RCS file:
Hi people,
the attached patch fixes two minor issues with the ifconfig(8) manpage.
The first part makes the operation of the `delete' option without an
argument a bit more obvious.
The second is a simple fix for the range of the `priority' option.
--
Gregor Best
Index:
document the NET_RT_TABLE
fifth-level name for CTL_NET/PF_ROUTE. Is this intentional or should I
write another patch correcting that?
Sincerely,
Gregor Best
Index: route.c
===
RCS file: /usr/src/cvs/src/sbin/route/route.c,v
On Thu, Mar 13, 2014 at 11:16:42AM +0100, Gregor Best wrote:
> [...]
> Couldn't test hibernate yet because my system has root on a softraid
> crypto device and the swap is outside the crypto area.
> [...]
David gave me a hint on how to hardwire my kernel for swap on sd0b.
Wit
eadlock. If you didn't test yet, try this version
> instead.
> [...]
Suspend (to RAM) and resume works fine here with
vga1 at pci0 dev 2 function 0 "Intel GM965 Video" rev 0x0c
Couldn't test hibernate yet because my system has root on a softraid
crypto device an
ev 0x0c
Is there anything I can do to further assist?
Thanks a lot by the way for the explanation of DVACT_RESUME vs. DVACT_WAKEUP.
--
Gregor Best
;d extract it and then use CVS to update it
to the repository, because that's usually a lot faster than doing the
entire checkout from CVS.
I could live with the tarball gone though.
--
Gregor Best
On Mon, Jan 13, 2014 at 12:41:19PM -0800, Philip Guenther wrote:
> [...]
> I think you meant "ungetch(KEY_RESIZE)",
> [...]
You're right.
> [...]
> seems to fix the problem in my testing.
> [...]
Works for me too.
--
Gregor Best
le, sometimes loads of attempts).
> [...]
The patch below seems to fix that for me. resizeterm() does a
putchar(KEY_RESIZE), part of which then gets interpreted as a command parameter
in rundisplay().
I'm not too sure on the cast to char, but since isascii() makes sure the
value passed is
Hi Sylvestre,
> [...]
> Did you use the last snapshots ? If yes you need to recompile your
> libfuse and your kernel to get the last changes.
> [...]
thanks for the clue bat. Not upgrading libfuse was indeed the problem.
--
Gregor Best
there "typical spots" in fuse
where adding one or two printfs() might yield further insight?
Thanks in advance,
Gregor Best
On Sat, Jun 01, 2013 at 06:57:21AM -0700, Mike Larkin wrote:
> [...]
> Sure, go ahead.
> [...]
Then I propose the following variant of the patch:
Index: dev/acpi/acpi.c
===
RCS file: /cvs/src/sys/dev/acpi/acpi.c,v
retrieving revision
e loop once the [...] has been printed
instead of iterating over the queue without doing anything?
--
Gregor Best
ise with my Thinkpad R61i.
--
Gregor Best
#x27;d be very happy to help.
--
Gregor Best
pgps3nCas5Iq2.pgp
Description: PGP signature
ump to 2.0 and
the WPA enterprise patch. I guess using Stuart's effort would be better.
--
Gregor Best
I just rolled an update to the wpa_supplicant port that updates it to
2.0 and includes your patch. I'm trying it out right now but it seems to
work flawlessly. Thanks a lot for the work :)
--
Gregor Best
On Sun, Oct 14, 2012 at 11:05:36AM +0200, David Coppa wrote:
> On Tue, Oct 9, 2012 at 6:21 PM, Gregor Best wrote:
> > This patch simply halves the timeslice processes get until they are
> > preempted. This patch is standalone and the rest of the patches does not
> > depend
I haven't yet run a full
userland build (it's running at the moment but the machine I'm building
on is a bit slower than my laptop).
--
Gregor Best
This patch uses the previous one to take CPU topology into account when
calculating the cost of moving a process between CPUs. This is only done
on amd64 at the moment, and the cost factors are guesses right now, but
it's a start.
--
Gregor Best
This patch simply imports Christiano's code for detecting CPU topology,
as posted on tech@ a while (more than two months) ago. I took it
verbatim and didn't change anything yet.
--
Gregor Best
This patch simply halves the timeslice processes get until they are
preempted. This patch is standalone and the rest of the patches does not
depend on it, but I figured I'd throw it in anyway.
--
Gregor Best
O(log n).
I remove the NICE_WEIGHT define because it's meaningless with this
patch, as there's only one runqueue.
sys/proc.h now includes sys/tree.h, but that does not seem to be a
problem when building the userland. Libc builds fine now for example.
--
Gregor Best
diff --git a/arch/amd64/amd64/identcpu.c b/arch/amd64/amd64/identcpu.c
index c597bb0..982c2bb 100644
--- a/arch/amd64/amd64/identcpu.c
+++ b/arch/amd64/amd64/identcpu.c
@@ -210,6 +210,8 @@ void (*setperf_setup)(struct cpu_info *);
void via_nano_setup(struct cpu_info *ci);
+void cpu_topology(st
diff --git a/arch/amd64/include/cpu.h b/arch/amd64/include/cpu.h
index 12e48d6..99501a1 100644
--- a/arch/amd64/include/cpu.h
+++ b/arch/amd64/include/cpu.h
@@ -102,9 +102,11 @@ struct cpu_info {
u_int32_t ci_cflushsz;
u_int64_t ci_tsc_freq;
+#define ARCH_HAVE_CPU_TOPO
diff --git a/sys/sched.h b/sys/sched.h
index fb01f21..1784ee2 100644
--- a/sys/sched.h
+++ b/sys/sched.h
@@ -69,8 +69,10 @@
#ifndef_SYS_SCHED_H_
#define_SYS_SCHED_H_
+#ifdef _KERNEL
#include
#include
+#endif
/*
* Posix defines a which may want to include
@@ -88,11 +90
diff --git a/kern/kern_clock.c b/kern/kern_clock.c
index 843965b..f598afc 100644
--- a/kern/kern_clock.c
+++ b/kern/kern_clock.c
@@ -233,7 +233,7 @@ hardclock(struct clockframe *frame)
if (stathz == 0)
statclock(frame);
- if (--ci->ci_schedstate.spc_rrticks <= 0)
+
diff --git a/kern/sched_bsd.c b/kern/sched_bsd.c
index 172bb8f..c7121dc 100644
--- a/kern/sched_bsd.c
+++ b/kern/sched_bsd.c
@@ -77,12 +77,12 @@ scheduler_start(void)
timeout_set(&schedcpu_to, schedcpu, &schedcpu_to);
- rrticks_init = hz / 10;
+ rrticks_init = hz / 20;
nel data to userland in such a
broad way.
The patches will follow as single emails.
--
Gregor Best
hat
should not be an issue anymore, don't worry :)
> Try splitting up your diff and working them into pieces kernel hackers can
> work with...
> [...]
I will. Actually, the diff is a bunch of seperate git commits on my
machine, so that shouldn't be too hard to do.
--
Gregor Best
#x27;ll change the
deadline-calculation to also take the sleep priority into account.
Thanks for the explanation :)
--
Gregor Best
[demime 1.01d removed an attachment of type application/pgp-signature]
> [...]
> I don't think changing the idle loop like this is ok. You want to
> continue checking whether the runqueue is empty in between
> cpu_idle_enter() and cpu_idle_leave().
> [...]
Fair point. I'll change that :)
--
Gregor Best
too large,
but the rest of the patch will of course work without this bit.
Thanks for taking your time to look at this :)
--
Gregor Best
oking forward to anything you have to comment, especially cool
benchmark ideas or the like.
--
Gregor Best
Index: arch/amd64/amd64/identcpu.c
===
RCS file: /cvs/src/sys/arch/amd64/amd64/identcpu.c,v
retrieving revision 1.39
1 - 100 of 112 matches
Mail list logo
