On Mon, Oct 08, 2012 at 07:42:13PM +0200, Marc Espie wrote:
> [...]
> Your diff doesn't pass userland compiles.
> You're adding a dependency on tree.h in proc.h.
>
> In kernel land on amd64, that's okay, since machine/param.h will pull
> machine/cpu.h which pulls sys/sched.h which now pulls sys/tree.h,
>
> but it definitely doesn't fly in userland... my build crashed & burned
> in libc...
>
> assuming that's okay (not usually a kernel guy), you can go include
> sys/tree.h directly in proc.h...
> [...]
I think wrapping all the things that need sys/tree.h in #ifdef KERNEL
should do the trick since they don't really make sense in userland
anyway.
> Please, please, please, don't vanish into the woods for the next 6 months.
> [...]
Since I now have way more space time on my hands than before, that
should not be an issue anymore, don't worry :)
> Try splitting up your diff and working them into pieces kernel hackers can
> work with...
> [...]
I will. Actually, the diff is a bunch of seperate git commits on my
machine, so that shouldn't be too hard to do.
--
Gregor Best
