Hi Alexandre,

> [...]
> This change is unclear for me; AFAIU, it removes the mechanism
> which makes processes wake up with a priority depending on what  
> they are blocked on.
> [...]

Where do you see that? The code I removed/changed simply calulated the queue 
from
which to remove `p` and removed it from there (similar for insertion). That 
needed
to be changed to modify the RB tree used as a new runqueue.

> [...]
> For instance processes waking up from poll(2) or audio read/write
> won't be prioritized any longer. If so, this would hurt audio and
> other interactive processes but would improve cpu-intesive
> bloatware.
> [...]

They weren't prioritised with the old version of this code either.

> [...]
> this change is unrelated to the rest isn't it?
> [...]

Yes, it is. I changed it because 100ms time slices felt a bit too large,
but the rest of the patch will of course work without this bit.

Thanks for taking your time to look at this :)

-- 
    Gregor Best

Reply via email to