mmd-osm left a comment (openstreetmap/openstreetmap-website#3107)
The two screenshots I posted initially were based on a similar approach
(obviously without using chatgpt back then). The main goal was to declare the
API structure, in order to extract it as OpenAPI format (OAS3) later on.
I have
@mmd-osm commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewind
mmd-osm left a comment (openstreetmap/openstreetmap-website#5990)
The copyright page will change shortly. Can you check
https://github.com/osmfoundation/ewg_bidding/pull/20 + #5989 for planned
updates?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/opens
@mmd-osm commented on this pull request.
> +# Table name: note_tags
+#
+# note_id :bigint(8)not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_id =>
mmd-osm left a comment (openstreetmap/openstreetmap-website#5759)
Duplicate of #1747
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5759#issuecomment-2705667755
You are receiving this because you are subscribed to this thread.
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
Iām sure youād need to backfill this information for all changesets, if you
donāt like users complaining about inconsistent numbers in the future.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
mmd-osm left a comment (openstreetmap/openstreetmap-website#5760)
Duplicate of #5759
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5760#issuecomment-2705722791
You are receiving this because you are subscribed to this thread.
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
I suppose this will be rather slow, because we donāt store this information on
changeset level.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5758#issuecomment
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
I just checked this topic from cgimap side. It shouldn't be too much effort. We
anyway have all details about created/modified/deleted nodes/way/relations. It
boils down to an additional `UPDATE changesets SET created_objs = creat
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
Yes, I know those. I guess you need to keep bugging folks over at OSMUS:
https://openstreetmap.us/our-work/charter-projects/osmcha/
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
> OSMCha is very painful to use, 18 seconds load time for each changeset to
> review, 40 seconds to load the list of changesets
If there's a performance issue with OSMCha, why not report it in their repo in
the first place? https
We're supporting WebP format for map downloads now. The change is a left
over from
https://github.com/openstreetmap/openstreetmap-website/pull/5607#issuecomment-2660979843
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/p
mmd-osm left a comment (openstreetmap/openstreetmap-website#5733)
@jessequinn : it would be good if you could post error messages as text rather
than screenshot. Search here on Github doesn't work that well with images.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
mmd-osm left a comment (openstreetmap/openstreetmap-website#5639)
Elsewhere I've seen that `:options` has been added to the list of methods in
cors.rb (e.g.
https://github.com/mastodon/mastodon/blob/main/config/initializers/cors.rb#L23),
while it's not included in our version:
https://github.c
mmd-osm left a comment (openstreetmap/openstreetmap-website#5715)
By the way, are we already using YJIT or planning to do so in the future?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5715#issuecomment-2675766655
You are recei
mmd-osm left a comment (openstreetmap/openstreetmap-website#5714)
For non-confidential apps, PKCE flow is relevant, which the wiki page doesnāt
explain in much detail. You could refer to
https://doorkeeper.gitbook.io/guides/ruby-on-rails/pkce-flow as a starting
point.
--
Reply to this email d
Closed #5080.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#event-16387647115
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
mmd-osm left a comment (openstreetmap/openstreetmap-website#5080)
Closing since there were too many breaking upstream changes in the meantime.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2672436660
You are re
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
The most notable thing I find worth porting over from osmcha is the changeset
visualization. Other projects need to jump through hoops to generate augmented
diffs, and we have direct access to all relevant data and could probably
mmd-osm left a comment (openstreetmap/openstreetmap-website#5987)
It would be good to have a maximum field length, both for home_location_name as
well as company.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-
mmd-osm left a comment (openstreetmap/openstreetmap-website#5979)
> "If a client only supports one version they can jump straight to the
> versioned capabilities call."
Turning off /api/capabilitites and having the clients call the versioned
capabilities would still require some changes on the
mmd-osm left a comment (openstreetmap/openstreetmap-website#5997)
`ruby ./script/statistics` works with the current code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5997#issuecomment-2869171433
You are receiving this because
mmd-osm created an issue (openstreetmap/openstreetmap-website#6020)
Before starting a new PR, I wanted to get some feedback, if this login option
is working, and if anyone is still using it? My impression is that it is in
some broken state for quite a while. I would therefore suggest to remove i
mmd-osm left a comment (openstreetmap/openstreetmap-website#6021)
Yes, I've also seen that. I gave it a try, seems to be working ok on Chrome:
--
Reply to this email directly or view it on GitHub:
https://
mmd-osm left a comment (openstreetmap/openstreetmap-website#6021)
Same results here: Chrome Version 128.0.6613.84 on Linux x64 is failing,
Firefox is ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6021#issuecomment-2888348
mmd-osm left a comment (openstreetmap/openstreetmap-website#6022)
We never see these screenshots images taken when something is failing:
`[Screenshot Image]:
/home/runner/work/openstreetmap-website/openstreetmap-website/tmp/screenshots/failures_test_translated_links.png`
https://dev.to/ugifract
mmd-osm left a comment (openstreetmap/openstreetmap-website#6020)
@tomhughes: So the issue with the current code seems to be related to
ruby-openid, which has been archived a couple of years ago:
https://github.com/openid/ruby-openid
During callback processing, the user session no longer includ
mmd-osm left a comment (openstreetmap/openstreetmap-website#6028)
Isn't that similar to #5987?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6028#issuecomment-2892302476
You are receiving this because you are subscribed to thi
@mmd-osm commented on this pull request.
> @@ -24,9 +24,8 @@
:include_blank => t("auth.providers.none"),
:hide_label => true,
:wrapper => { :class => "col-auto mb-0" } %>
- <%= f.text_field(:auth_uid, :hide_label => true, :wrapper
@mmd-osm pushed 1 commit.
706d167f08d9a5e6eaa55f024e346146e6bfb1f5 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/a52b33ba96918d3523c9c6e91c1cf218b50e9e25..706d167f08d9a5e6eaa55f024e346146e6bfb1f5
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038)
I also haven't addressed this bit yet:
https://github.com/openstreetmap/openstreetmap-website/blob/dcd886e3e37af9b5f0003aec0563eef5a7b02c1e/app/controllers/users_controller.rb#L142-L146
Should we remove it? It seems to be some sor
@mmd-osm commented on this pull request.
><% end -%>
<% end %>
-
- <%# :tabindex starts high to allow rendering at the bottom of the template %>
- <%= form_tag auth_path(:provider => "openid"), :id => "openid_login_form",
:class => "collapse" do %>
-
-
-<%=
@mmd-osm commented on this pull request.
>$("input#user_avatar").on("change", function () {
$("#user_avatar_action_new").prop("checked", true);
});
- function enableAuth() {
-$("#auth_prompt").hide();
-$("#auth_field").show();
-$("#user_auth_uid").prop("disabled", fals
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038)
Regarding the `preferred_auth_provider`, I was looking for the exact URL to
trigger the different layout. It seems I need to include this parameter along
with the respective auth provider in the referer parameter:
* http://localh
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
I'd say, Mastodon links look almost the same as before:
Old:
```
[Edit your OSM profile], make it include My fediverse acount
```
New:
```
https://en.osm.town/@username";>
```
So there's still the "ref="...me" in place. The que
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
Ok, please ignore my previous comment. Your bot was relying on the fact that
users put in a social media link in their profile description text, which you
were able to obtain from the description.
With the recent changes, users w
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
I think this was already in place for quite some time, and looks like this
example: https://en.osm.town/@mapcomplete_edits/114543361361396417
In case people maintained a link to their mastodon account on their osm
profile, they w
@mmd-osm pushed 1 commit.
a52b33ba96918d3523c9c6e91c1cf218b50e9e25 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/d9c9ea5f1cfa553da2bbc8586a1e83ae60271183..a52b33ba96918d3523c9c6e91c1cf218b50e9e25
You are receiving this be
This pull request adds human readable HTTP 509 rate limiting error messages.
Before:
After:
You can view, comment on, or m
mmd-osm left a comment (openstreetmap/openstreetmap-website#1602)
@tomhughes : the PR is quite old... `bundle exec rails test` seems to work
without deadlock_retry Gem these days. Was there some other reason to add it
back then? Can we retire it?
--
Reply to this email directly or view it on
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058)
How much faster is this now compared to the original version?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-2916602284
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
Thank you for your feedback, in particular for the interesting example about
the create action.
> I didn't see anyone respond above to @joto's point
I think I sort of addressed this one: _I agree that the action attribute
doesn
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
@AntonKhorev : can you take a look at the proposed db schema changes and
comment if you're ok with them?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5758#iss
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
So we could probably deploy the cgimap implementation on the dev server (as
dedicated entry in https://apis.dev.openstreetmap.org/) for further testing,
and get some feedback on the proposed format.
The implementation covers chan
### Description
Fixes #6020
### How has this been tested?
Scenarios tested on local instance:
1. GitHub as single third party provider
- Log in / Sign up
- Change external authentication on "My Account" from
"Github" to "None", and back to "Github", check
log in process
2. No third party prov
mmd-osm left a comment (openstreetmap/openstreetmap-website#6023)
Let's close this one, the issue has been fixed in the meantime.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6023#issuecomment-2901870479
You are receiving thi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036)
Maybe @Nikerabbit could help here from TranslateWiki side?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901866257
You are receiving this bec
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036)
@Nikerabbit : thanks a lot for the super quick fix, much appreciated!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901964263
You are receivi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
Not sure what exactly your point is, `not_public_flash` is still in use:
https://github.com/openstreetmap/openstreetmap-website/blob/1b63e9e16dff92df226aed707058b7228527bc6e/app/controllers/site_controller.rb#L100
--
Reply to thi
@mmd-osm pushed 1 commit.
d9c9ea5f1cfa553da2bbc8586a1e83ae60271183 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/42f4bfc9e341d20275c6a096167acb9cc39a2f49..d9c9ea5f1cfa553da2bbc8586a1e83ae60271183
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
Okay, I see what you mean. Obviously this particular feature will only be
relevant to a very small group, if at all. You can be assured that we
re-evaluate features from time to time and remove them when they are no longer
releva
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
https://wiki.openstreetmap.org/wiki/Anonymous_edits has some more background.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6035#issuecomment-2899942196
You are
mmd-osm left a comment (openstreetmap/openstreetmap-website#6028)
> Here's some other people reporting it on the community forums:
https://community.openstreetmap.org/t/actual-problems-with-id-editor/130320/2
At least some users mentioned in
https://community.openstreetmap.org/t/current-problems
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
https://github.com/openstreetmap/openstreetmap-website/issues/5950#issuecomment-2830201587
has some previous discussion on this topic.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#2185)
I'm not seeing any error messages on Rails 8 anymore in case
config/settings.local.yml is missing. Is this working as expected? Maybe we
could remove the respective section in the readme file now.
--
Reply to this email directly
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
Did you configure doorkeeper_signing_key in your settings.local.yml?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927568676
You are receivin
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
The issue is that JOSM requires the /.well-known/oauth-authorization-server
endpoint to be around, and for some reason Doorkeeper disables this endpoint
unless you define a doorkeeper_signing_key. That's mostly in place so that JO
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
https://josm.openstreetmap.de/changeset/18991/josm talks about leveraging [RFC
8414](https://datatracker.ietf.org/doc/html/rfc8414) to determine
authorization_endpoint and token_endpoint fields. I think that's more of a
convenien
mmd-osm left a comment (openstreetmap/openstreetmap-website#6082)
> [github](https://github.com/CEPT-VZG/digipin)
This reference implementation is written in Javascript and would have to be
converted to Ruby (which is trivial thanks to LLMs). However, there are no unit
tests in the original rep
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
https://dupnotes.webmapping.cyou/creator_om.html has a few examples like
https://www.openstreetmap.org/note/4806005 and
https://www.openstreetmap.org/note/4806010 where the user has added additional
text "It is now changed to Bel
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058)
@1ec5: this change is probably only relevant for developers running their local
Rails instance. The code is not used in production.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
No idea what youāre trying to achieve. Why donāt you use the API or some
external tool like osmosis to load the data. It seems very odd that youāre
fudging with the tile field calculation.
--
Reply to this email directly or vie
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
What you probably want are idempotent API endpoints like weāve been discussing
in #2201
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6100#issuecomment-2972565
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
Also, please stop spamming unrelated repos:
https://github.com/openstreetmap/iD/issues/11132
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6099#issuecomment-29
mmd-osm left a comment (openstreetmap/openstreetmap-website#6127)
According to https://www.mediawiki.org/wiki/Wikibase/API/en the endpoint
supports multiple ids in one request, separated by a pipe character. Since we
anyway know all ids upfront, we could do with a single page update (=less
flic
mmd-osm left a comment (openstreetmap/openstreetmap-website#6123)
You need to report issues regarding the built in iD editor in the following
place: https://github.com/openstreetmap/iD/issues
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
@AntonKhorev : the main issue here is about creating multiple identical notes
(same lat/lon & note description), presumably as a result of some technical
glitch. I don't think we would end up with that many identical notes for the
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
By the way, calling the original Rails code returns the following result:
```
QuadTile.tile_for_point(35.2000381, 114.6629926)
=> 3875963095
```
This matches:
```
id | latitude | longitude | changeset_id | visible |
mmd-osm left a comment (openstreetmap/openstreetmap-website#2201)
In the meantime, there are Gems like https://github.com/julik/idempo available
that implement idempotency more generically (untested).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
> Here are some stats https://dupnotes.webmapping.cyou/ with a [subset of
> Organic Maps duplicated
> notes](https://dupnotes.webmapping.cyou/organic-maps/om-dupe-notes.json). So
> it is still an issue.
One thing I find interest
mmd-osm left a comment (openstreetmap/openstreetmap-website#6098)
https://github.com/openstreetmap/openstreetmap-website/blob/4989c1fd8e2245fa9212c879a10630cc159c52da/app/models/concerns/geo_record.rb#L37
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
mmd-osm left a comment (openstreetmap/openstreetmap-website#6135)
This has already been implemented in #5403. Obviously some parameters would
have to be set to make this work. So not an issue for this repo but more of an
operations issue.
--
Reply to this email directly or view it on GitHub:
h
mmd-osm left a comment (openstreetmap/openstreetmap-website#6091)
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Profiles.show.social+links.title
and
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Activerecord.attributes.user.company
appear to be the correc
mmd-osm left a comment (openstreetmap/openstreetmap-website#6091)
"Home location name" doesn't appear to be translated at all, try
https://www.openstreetmap.org/profile?locale=fr or
https://www.openstreetmap.org/profile?locale=de
--
Reply to this email directly or view it on GitHub:
https://gi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6154)
Iāve frequently seen hanging test runs in cgimap, which turned out to be
related to a used up quota. The job was being silently killed, and eventually
hit the timeout, although itās been dead for some minutes already. You should
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> the cookie is going to be valid if I exported on osm.org recently
I think the TOTP cookie is valid for an hour or so. I'm also testing locally by
running an export on osm.org to get a valid token, then continue with local
test
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> During preflight the export script shouldn't look at cookies because it won't
> receive any cookies.
Agreed, the script isn't handling preflight requests properly at the moment.
Maybe Apache could also return something for OPT
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The click.rails event seems to be handled by jquery-ujs
(https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L524-L551).
There's also some code in place to re-enable form elements, but my debugger
isn't stopping there. I
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think what you describe is documented here:
https://turbo.hotwired.dev/handbook/drive#form-submissions
_During a submission, Turbo Drive will set the āsubmitterā elementās
[disabled](https://developer.mozilla.org/en-US/docs/Web
@mmd-osm commented on this pull request.
> @@ -15,7 +15,15 @@
data[:token] = token.token
end
data[:locale] = ID::LOCALES.preferred(preferred_languages).to_s
- data[:asset_map] = assets("iD").to_json %>
+ data[:asset_map] = assets("iD").to_json
+
+ # Include user preferences fo
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> Would it? Is it even required by the exporter?
Yes, it's explicitly checked here:
https://github.com/openstreetmap/chef/blob/master/cookbooks/tile/templates/default/export.erb#L179-L183
--
Reply to this email directly or view
mmd-osm left a comment (openstreetmap/openstreetmap-website#6138)
> I also did not manage to get an OAuth setup going locally for proper
> debugging (I don't have
> https://www.openstreetmap.org/.well-known/openid-configuration locally for
> some reason).
This topic came up recently:
https://
mmd-osm left a comment (openstreetmap/openstreetmap-website#6139)
I think this has been forever this way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6139#issuecomment-3014331983
You are receiving this because you are subscr
@mmd-osm pushed 1 commit.
2ee3e989e4b9edb41378d275544d1cc3915e Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/67727a878643a2ccd4df03a6b0ee6a90aa557663..2ee3e989e4b9edb41378d275544d1cc3915e
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6207)
OSM.router is probably the bigger issue. It blocks a number of other features,
such as adding notes, query features, directions, etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
@mmd-osm commented on this pull request.
> @@ -8,7 +8,6 @@ L.OSM.share = function (options) {
function init(map, $ui) {
// Link / Embed
-
oops, fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2
@mmd-osm commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/sv
@mmd-osm pushed 1 commit.
6f098b047258b6bf1d0f13ac8638040757c1874d Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/0f027550cff731114749a11cfa1b18bdc1e6a498..6f098b047258b6bf1d0f13ac8638040757c1874d
You are receiving
@mmd-osm commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
+ if (event.detail.success) {
+event.detail.fetchResponse
@mmd-osm commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/sv
@mmd-osm commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
good point
--
Reply to this email directly or view it on GitHub:
ht
@mmd-osm pushed 1 commit.
0f027550cff731114749a11cfa1b18bdc1e6a498 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/2ee3e989e4b9edb41378d275544d1cc3915e..0f027550cff731114749a11cfa1b18bdc1e6a498
You are receiving
@mmd-osm pushed 1 commit.
67727a878643a2ccd4df03a6b0ee6a90aa557663 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b514a848c5732df855e978748b94fcb87067bc1d..67727a878643a2ccd4df03a6b0ee6a90aa557663
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Instead of hardcoding formats, I have added a new attribute "formats" to
layers.yml, and disable non-supported formats in the select options:
https://github.com/user-attachments/assets/e5a5639e-69f5-45d2-aacc-96af327a91cf";
/>
T
mmd-osm left a comment (openstreetmap/openstreetmap-website#6207)
Indeed, now everything seems to be working fine again.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6207#issuecomment-3092270750
You are receiving this because
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Currently the export script returns errors as text/html, which Turbo happily
picks up to replace the osm.org page. In this case, the user has to reload the
page. Browser back button would take them to a random place, which is quit
@mmd-osm pushed 1 commit.
e1311a90607d422f7f0e4c8d4d76d08a637de9af Handle response error message
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/6f098b047258b6bf1d0f13ac8638040757c1874d..e1311a90607d422f7f0e4c8d4d76d08a637de9af
You are receiving this
@mmd-osm pushed 1 commit.
723ee4bcbab76b7e599cb6bd986a7ee98f217b6b Simplify code
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/e1311a90607d422f7f0e4c8d4d76d08a637de9af..723ee4bcbab76b7e599cb6bd986a7ee98f217b6b
You are receiving this because you are
This seems to break sites that are using a popup to sign in to OSM, like this
example: https://osmlab.github.io/osm-auth/
Error message: Uncaught TypeError: can't access property "authComplete", opener
is null
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
mmd-osm created an issue (openstreetmap/openstreetmap-website#6172)
### URL
_No response_
### How to reproduce the issue?
* We're starting on a page that supports paging (so either diaries or traces)
and navigate to an older entry. The resulting URL in the browser window is then
something lik
201 - 300 of 349 matches
Mail list logo
