### Description Fixes #6020 ### How has this been tested?
Scenarios tested on local instance: 1. GitHub as single third party provider - Log in / Sign up - Change external authentication on "My Account" from "Github" to "None", and back to "Github", check log in process 2. No third party providers configured - Check that UI doesn't mention "or log in with a third party" along with an empty list of third party providers Open issues: - app/assets/javascripts/auth_providers.js seems to have a timing issue on /user/new page. Previously, the auth provider pointed to /auth/github?referer=undefined. I added a fallback to replace undefined by an empty string. It would probably make sense to call this code from app/assets/javascripts/user.js in some different way. Please comment with suggestions for improvement. - I couldn't find out how to test `preferred_auth_provider`. Is this parameter documented somewhere? You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6038 -- Commit Summary -- * Remove legacy OpenID login -- File Changes -- M Gemfile (1) M Gemfile.lock (8) D app/assets/images/auth_providers/openid.svg (5) M app/assets/javascripts/auth_providers.js (2) M app/assets/javascripts/user.js (34) M app/controllers/accounts_controller.rb (2) M app/controllers/concerns/session_methods.rb (4) M app/controllers/users_controller.rb (3) M app/views/accounts/show.html.erb (3) M app/views/application/_auth_providers.html.erb (30) M app/views/sessions/new.html.erb (2) M app/views/users/new.html.erb (2) M config/initializers/omniauth.rb (19) M config/locales/en.yml (5) M lib/auth.rb (2) M test/integration/login_test.rb (142) M test/integration/user_creation_test.rb (126) M test/system/user_login_test.rb (14) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6038.patch https://github.com/openstreetmap/openstreetmap-website/pull/6038.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6038 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
