Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-28 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Oct 26, 2015 at 04:21:16PM -0200, Eduardo Habkost wrote: >> On Mon, Oct 26, 2015 at 06:43:43PM +0100, Markus Armbruster wrote: >> > Eduardo Habkost writes: >> [...] >> > > Not sure if this is appropriate post soft-freeze, but if we are >> > > going to apply >> >

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-28 Thread Eduardo Habkost
On Mon, Oct 26, 2015 at 04:21:16PM -0200, Eduardo Habkost wrote: > On Mon, Oct 26, 2015 at 06:43:43PM +0100, Markus Armbruster wrote: > > Eduardo Habkost writes: > [...] > > > Not sure if this is appropriate post soft-freeze, but if we are going to > > > apply > > > the max-cpus patch from Drew b

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-28 Thread Laszlo Ersek
On 10/28/15 14:58, Andrew Jones wrote: > On Tue, Oct 27, 2015 at 08:36:07PM +0100, Laszlo Ersek wrote: >> On 10/27/15 20:25, Eduardo Habkost wrote: >>> On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: In addition to Markus' and Eric's comments, I think we should 1. make

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-28 Thread Andrew Jones
On Tue, Oct 27, 2015 at 08:36:07PM +0100, Laszlo Ersek wrote: > On 10/27/15 20:25, Eduardo Habkost wrote: > > On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: > >> In addition to Markus' and Eric's comments, I think we should > >> > >> 1. make sure the first word's case is correct. Low

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Laszlo Ersek
On 10/27/15 20:25, Eduardo Habkost wrote: > On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: >> In addition to Markus' and Eric's comments, I think we should >> >> 1. make sure the first word's case is correct. Lowercase for phrases, >>uppercase for sentences and proper nouns. > >

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: > In addition to Markus' and Eric's comments, I think we should > > 1. make sure the first word's case is correct. Lowercase for phrases, >uppercase for sentences and proper nouns. I think I can understand this in the more obvious

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Eduardo Habkost
On Mon, Oct 26, 2015 at 01:10:31PM -0600, Eric Blake wrote: > On 10/26/2015 11:13 AM, Eduardo Habkost wrote: > > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > > > The trailing newlines, "qemu:" and "error:" message prefixes were > > removed. > > > > The only remaining

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Markus Armbruster
Andrew Jones writes: > On Mon, Oct 26, 2015 at 03:13:43PM -0200, Eduardo Habkost wrote: >> This replaces most fprintf(stderr) calls on vl.c with error_report(). >> >> The trailing newlines, "qemu:" and "error:" message prefixes were >> removed. >> >> The only remaining fprintf(stderr) calls are

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-27 Thread Andrew Jones
On Mon, Oct 26, 2015 at 03:13:43PM -0200, Eduardo Habkost wrote: > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > The trailing newlines, "qemu:" and "error:" message prefixes were > removed. > > The only remaining fprintf(stderr) calls are the ones at > qemu_kill_report

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-26 Thread Eric Blake
On 10/26/2015 11:13 AM, Eduardo Habkost wrote: > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > The trailing newlines, "qemu:" and "error:" message prefixes were > removed. > > The only remaining fprintf(stderr) calls are the ones at > qemu_kill_report(), because the er

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-26 Thread Eduardo Habkost
On Mon, Oct 26, 2015 at 06:43:43PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: [...] > > Not sure if this is appropriate post soft-freeze, but if we are going to > > apply > > the max-cpus patch from Drew before 2.5.0, we could simply change all the > > fprintf() calls in a single s

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-26 Thread Eduardo Habkost
On Mon, Oct 26, 2015 at 06:43:43PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > > > The trailing newlines, "qemu:" and "error:" message prefixes were > > removed. > > Good! > > Some of the messages end

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-26 Thread Markus Armbruster
Eduardo Habkost writes: > This replaces most fprintf(stderr) calls on vl.c with error_report(). > > The trailing newlines, "qemu:" and "error:" message prefixes were > removed. Good! Some of the messages end in a period, which could also be dropped. Example: Usage: -virtfs fsdriver,mount_t

[Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-26 Thread Eduardo Habkost
This replaces most fprintf(stderr) calls on vl.c with error_report(). The trailing newlines, "qemu:" and "error:" message prefixes were removed. The only remaining fprintf(stderr) calls are the ones at qemu_kill_report(), because the error mesage is split in multiple fprintf() calls. Signed-off-