On 10/27/15 20:25, Eduardo Habkost wrote:
> On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote:
>> In addition to Markus' and Eric's comments, I think we should
>>
>> 1. make sure the first word's case is correct. Lowercase for phrases,
>> uppercase for sentences and proper nouns.
>
> I think I can understand this in the more obvious cases, but I don't
> know how I could convert the following instance:
>
> [...]
>>> case QEMU_OPTION_no_kvm_pit: {
>>> - fprintf(stderr, "Warning: KVM PIT can no longer be
>>> disabled "
>>> - "separately.\n");
>>> + error_report("Warning: KVM PIT can no longer be disabled "
>>> + "separately.");
>>
>> Could change this from a sentence into a phrase. Also, we need a consistent
>> 'warning' prefix. Should we make a error_report_warn variant?
>
> Converting that sentence to a phrase is beyond my non-native english
> speaker skills. Do you have any suggestions? :)
>
easy-peasy, "KVM PIT no longer disableable separately"!
/me hides ;)
