D28487: Redesign of system monitor plasmoids

2020-05-11 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c8deafbb0731: Redesign of system monitor plasmoids (authored by mart). REPOSITORY R120 Plasma Workspac

D28487: Redesign of system monitor plasmoids

2020-05-08 Thread Nathaniel Graham
ngraham added a comment. When I create a new System Monitor Sensor widget, it's totally blank: F8300732: Screenshot_20200508_103957.png <https://phabricator.kde.org/F8300732> Needs to have a Configure... button on it in this case. REPOSITORY R120 Plasma Workspace REVI

D28487: Redesign of system monitor plasmoids

2020-05-08 Thread Marco Martin
mart updated this revision to Diff 82287. mart added a comment. - Merge branch 'master' into mart/mewSystemMonitor REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82224&id=82287 BRANCH mart/mewSystemMonitor REVISION DETAIL https://pha

D28487: Redesign of system monitor plasmoids

2020-05-07 Thread Marco Martin
mart updated this revision to Diff 82224. mart added a comment. - adapt to api changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82187&id=82224 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487 AFF

D28487: Redesign of system monitor plasmoids

2020-05-07 Thread Marco Martin
mart updated this revision to Diff 82187. mart marked 3 inline comments as done. mart added a comment. - make disk usage a bar chart REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82118&id=82187 BRANCH mart/mewSystemMonitor REVISION DE

D28487: Redesign of system monitor plasmoids

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82118. mart added a comment. - Controls QQC2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82117&id=82118 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487 AFFECTED F

D28487: Redesign of system monitor plasmoids

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82117. mart added a comment. - adapt to api changes - move faces config in own file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=81077&id=82117 BRANCH mart/mewSystemMonitor REVISION DETAIL https

D28487: Redesign of system monitor plasmoids

2020-05-04 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ConfigAppearance.qml:24 > +import QtQuick.Layouts 1.2 > +import QtQuick.Controls 2.2 as Controls > + `as QQC2` > ConfigSensors.qml:24 > +import QtQuick.Layouts 1.2 > +import QtQuick.Controls 2.2 as Controls > +import QtQml.Models 2.12 `as QQC2`

D28487: Redesign of system monitor plasmoids

2020-05-04 Thread Alex Debus
alexde added a comment. Not sure, if this is part of the scope of this work, but do you also plan to add some meaningful labels and ticks to the axis? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: alexde, ngraham, ksmanis, davi

D28487: Redesign of system monitor plasmoids

2020-05-04 Thread Nathaniel Graham
ngraham added a comment. Looks fantastic! However I've applied the dependent patches, but this doesn't compile for me: In member function ‘virtual void SystemMonitor::init()’: /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:63:78: err

D28487: Redesign of system monitor plasmoids

2020-05-01 Thread Arjen Hiemstra
ahiemstra added a comment. In D28487#661262 , @ksmanis wrote: > Is there an ETA for this? Is it worth fixing any bugs in the old applets in the meantime? We'd really like this in 5.19, but it's a pretty large set of changes in multiple p

D28487: Redesign of system monitor plasmoids

2020-05-01 Thread Nathaniel Graham
ngraham added a comment. In D28487#661262 , @ksmanis wrote: > Is there an ETA for this? Hopefully Plasma 5.19! But given the closeness to the release, we might end up punting it until 5.20. Either way, one of those two. > Is it worth

D28487: Redesign of system monitor plasmoids

2020-05-01 Thread Konstantinos Smanis
ksmanis added a comment. Is there an ETA for this? Is it worth fixing any bugs in the old applets in the meantime? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, Orage,

D29165: [System Monitor] Fix update interval setting

2020-04-25 Thread Konstantinos Smanis
ksmanis updated this revision to Diff 81160. ksmanis added a comment. - Make update interval spinbox locale-aware REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29165?vs=81139&id=81160 BRANCH master REVISION DETAIL https://phabricator.kde.org

D29165: [System Monitor] Fix update interval setting

2020-04-24 Thread Konstantinos Smanis
ksmanis added a comment. I am not sure what the proper solution for the i18ncp call is given that the argument is decimal. Someone more knowledgeable should probably chime in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29165 To: ksmanis, #plasma Cc: pl

D29165: [System Monitor] Fix update interval setting

2020-04-24 Thread Konstantinos Smanis
ksmanis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY The update interval setting for the system monitor applets seems to be borked right now, as a result of a missing reference and

D28487: Redesign of system monitor plasmoids

2020-04-24 Thread Marco Martin
mart updated this revision to Diff 81077. mart added a comment. - move faces and packagestructure to libksysguard REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=81020&id=81077 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phab

D28487: Redesign of system monitor plasmoids

2020-04-23 Thread Marco Martin
mart updated this revision to Diff 81020. mart added a comment. - use the new face library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=80403&id=81020 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28487: Redesign of system monitor plasmoids

2020-04-17 Thread Marco Martin
mart updated this revision to Diff 80403. mart added a comment. - port to the new library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79120&id=80403 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D14490: [System Monitor] Enable high dpi pixmaps

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. @broulik can this land? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14490 To: broulik, #plasma, davidedmundson, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

2019-05-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a980bedc4d1: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

2019-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 57780. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21074?vs=57737&id=57780 BRANCH systemmonitor-modernize-setting

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

2019-05-08 Thread Filip Fila
filipf added inline comments. INLINE COMMENTS > ConfigGeneral.qml:113 > +Kirigami.FormLayout { > +id: formLayout > + We should do `anchors.left: parent.left` and `anchors.right: parent.right` here so the layout is horizontally centered. > ConfigGeneral.qml:121 > + > +Ki

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

2019-05-07 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal

D21056: [System Monitor] [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

2019-05-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal

D17796: Show accurate checked state for system monitor configuration pages

2019-04-09 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:83045375ec2b: Show accurate checked state for system monitor configuration pages (authored by pavelmos, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D17796: Show accurate checked state for system monitor configuration pages

2019-04-03 Thread Nathaniel Graham
ngraham added a comment. We need a #plasma review first. Calling all Plasma devs! :) REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, rag

D17796: Show accurate checked state for system monitor configuration pages

2019-04-03 Thread Pavel Mos
pavelmos added a comment. It seems to me that everything is fine. Are there any other comments or questions? REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D17796: Show accurate checked state for system monitor configuration pages

2019-02-08 Thread Kai Uwe Broulik
broulik added a comment. > The call on line 141 looks superfluous - if there's any change to checked we modify cfg_sources which should trigger the reload. QML cannot detect changes within a JS structure, if you `push()` into an `Array` or modify members of an `Object` it doesn't see the

D17796: Show accurate checked state for system monitor configuration pages

2019-02-08 Thread Pavel Mos
pavelmos added a comment. I have no commit access. REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D17796: Show accurate checked state for system monitor configuration pages

2018-12-29 Thread Pavel Mos
pavelmos added a comment. In D17796#382974 <https://phabricator.kde.org/D17796#382974>, @ngraham wrote: > There we go, it works now! Code change looks sane to me. > > Please change the title to something more descriptive, such as "Show accurate checked stat

D14490: [System Monitor] Enable high dpi pixmaps

2018-07-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Needs D14489 for pr

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

2018-05-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R114:6e753e6653ac: Sync systemloadviewer showed items to ksysguard/system monitor (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11558?vs=30143&id=33491

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

2018-04-26 Thread Henrik Fehlauer
rkflx added a comment. FYI, now the applet is inconsistent with KInfoCenter > Memory, which //does// show the cache. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D11558 To: davidedmundson, #plasma, broulik Cc: rkflx, plasma-devel, ragreen, P

D6864: [System Monitor Applet] Add setting for update interval

2018-04-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2e129f84ce03: [System Monitor Applet] Add setting for update interval (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6864?vs=17090&id=32983#toc REPOSITORY R120 Pl

D6864: [System Monitor Applet] Add setting for update interval

2018-04-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please add the "." that cfeck said, then ship it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6864 To: broulik, #plasma, davidedmundson

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

2018-04-10 Thread David Edmundson
davidedmundson added a comment. Either things are consistent or not consistent with other applets. That is a yes/no case. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D11558 To: davidedmundson, #plasma Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D11558: Sync systemloadviewer showed items to ksysguard/system monitor

2018-04-10 Thread Henrik Fehlauer
rkflx added a comment. In D11558#243632 , @davidedmundson wrote: > We're at an impasse then. Only if you make this a yes/no decision. There are still options for a compromise which would fit both use cases. > by default it's current

D6864: [System Monitor Applet] Add setting for update interval

2017-08-01 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > cfeck wrote in ConfigGeneral.qml:115 > Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates > per second. I just did what ksysguard does where a 0 interval pauses updating, for whatever reason this may be useful.. REPOSIT

D6864: [System Monitor Applet] Add setting for update interval

2017-07-31 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > main.xml:13 > + > +The interval in milliseconds to update the data shown > +2000 Add a "." > ConfigGeneral.qml:115 > +suffix: i18nc("Suffix for spinbox (seconds)", " sec") > +maximumValue: 1000 >

D6864: [System Monitor Applet] Add setting for update interval

2017-07-24 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 353063 FIXED-IN: 5.11.0 TEST PLAN Tested that setting is applied to CPU monitor and opening the dialog restores the value F3818724

Re: Review Request 104015: A usable system monitor plasmoid

2014-07-29 Thread rhn rhn
discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- A plasmoid intended to be used on a panel. Inspired by gnome-multiload-applet and gkrellm. Before I decided to write this plasmoid, I considered other monitors. Here's what I found: - system-mo

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-15 Thread Commit Hook
t: > http://git.reviewboard.kde.org/r/113659/ > --- > > (Updated Nov. 5, 2013, 10:34 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: kde-workspace > > > Description > --- &

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-15 Thread Sergei Lopatin
marked as submitted. Review request for Plasma and Eike Hein. Repository: kde-workspace Description --- Added ability to system-monitor plasmoid to set configuration from js code. Something like this: a = activityForScreen(0) if (a) { var applet = a.addWidget("system-monitor_a

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
board.kde.org/r/113659/ > --- > > (Updated Nov. 5, 2013, 10:34 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: kde-workspace > > > Description > --- > > Added ability to system-monitor plas

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
Hein. Changes --- Added sanity check to ram module. Things works great for now. Repository: kde-workspace Description --- Added ability to system-monitor plasmoid to set configuration from js code. Something like this: a = activityForScreen(0) if (a) { var applet = a.addWidget("s

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
. Changes --- Call configChanged on child applets. It's still buggy Repository: kde-workspace Description --- Added ability to system-monitor plasmoid to set configuration from js code. Something like this: a = activityForScreen(0) if (a) { var applet = a.addWidget(&q

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
ly, visit: > http://git.reviewboard.kde.org/r/113659/ > --- > > (Updated Nov. 5, 2013, 8:58 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: kde-workspace > > > Descriptio

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
. Changes --- Added "don't do unnecessary work because the applets list didn't change" check. Repository: kde-workspace Description --- Added ability to system-monitor plasmoid to set configuration from js code. Something like this: a = activityForScreen(0)

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
> On Nov. 5, 2013, 7:39 p.m., Eike Hein wrote: > > This is a promising first start. Indeed, the System Monitor applet didn't > > implement configChanged(), causing scripting its configuration not to work, > > as we talked about on IRC. > > > > However, th

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
> On Nov. 5, 2013, 7:39 p.m., Eike Hein wrote: > > This is a promising first start. Indeed, the System Monitor applet didn't > > implement configChanged(), causing scripting its configuration not to work, > > as we talked about on IRC. > > > > However, th

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
. Repository: kde-workspace Description --- Added ability to system-monitor plasmoid to set configuration from js code. Something like this: a = activityForScreen(0) if (a) { var applet = a.addWidget("system-monitor_applet") applet.writeConfig("applets", "

Re: Current state of System Monitor

2012-08-10 Thread Shaun Reich
same repo, different branch. plasma/sreich/qml2-systemmonitor or something. -- Shaun Reich, KDE Software Developer (kde.org) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Current state of System Monitor

2012-08-10 Thread Peter Hartmann
ompiled Qt5 and hopefully would be able to try it. Can you point me to this code - assuming it's public at all? At anongit.kde.org/kde-workspace/plasma/generic/system-monitor there's only C++ code, but maybe there's othere directory or whole othe

Re: Current state of System Monitor

2012-08-09 Thread Shaun Reich
On Thu, Aug 9, 2012 at 1:16 PM, Peter Hartmann wrote: > On 07.08.2012 12:34, Shaun Reich wrote: >> >> >> Uh.. I've had a wip from scratch QML2 version of the system monitors in a >> workspace branch for a long time now. Obviously it can't be used until Qt5 >> is out. >> >> It has more functionalit

Re: Current state of System Monitor

2012-08-09 Thread Peter Hartmann
On 07.08.2012 12:34, Shaun Reich wrote: Uh.. I've had a wip from scratch QML2 version of the system monitors in a workspace branch for a long time now. Obviously it can't be used until Qt5 is out. It has more functionality than the current ones too. In the sense that it also has a bar graph

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 18:08, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: 09.08.2012 15:10, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: by the way that's what the formfactor mechanism for plasmoids is for. the same plasmoid should adapt itself for an optimal visualizati

Re: Current state of System Monitor

2012-08-09 Thread Marco Martin
On Thursday 09 August 2012, Dmitry wrote: > 09.08.2012 15:10, Marco Martin пишет: > > On Thursday 09 August 2012, Dmitry wrote: > >>> by the way that's what the formfactor mechanism for plasmoids is for. > >>> the same plasmoid should adapt itself for an optimal visualization > >>> wether is in the

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 15:10, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: by the way that's what the formfactor mechanism for plasmoids is for. the same plasmoid should adapt itself for an optimal visualization wether is in the desktop, an horizontal panel or a vertical one, just check th

Re: Current state of System Monitor

2012-08-09 Thread Marco Martin
On Thursday 09 August 2012, Dmitry wrote: > > by the way that's what the formfactor mechanism for plasmoids is for. > > the same plasmoid should adapt itself for an optimal visualization wether > > is in the desktop, an horizontal panel or a vertical one, just check the > > plasmoid.formFactor pro

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 14:27, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: http://doc-snapshot.qt-project.org/5.0/qml-qtquick2-context2d.html Hello, Mark! I think, you haven't understood me right. I don't want to port current C++ system monitor applet because it hasn't b

Re: Current state of System Monitor

2012-08-09 Thread Marco Martin
On Thursday 09 August 2012, Dmitry wrote: > > http://doc-snapshot.qt-project.org/5.0/qml-qtquick2-context2d.html > > Hello, Mark! > > I think, you haven't understood me right. I don't want to port current > C++ system monitor applet because it hasn't been i

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
08.08.2012 17:13, Mark пишет: On Tue, Aug 7, 2012 at 12:55 PM, Dmitry wrote: 07.08.2012 13:16, Marco Martin пишет: On Tuesday 07 August 2012, Dmitry wrote: Hello! I'm working on my new system monitor applet. I hate current default C++ applet. So, I've decided to implement my sim

Re: Current state of System Monitor

2012-08-09 Thread Marco Martin
On Thursday 09 August 2012, Giorgos Tsiapaliokas wrote: > On 8 August 2012 16:13, Mark wrote: > > My advice would be to use the current KDE Plasma ported components [1] > > Why to use those and not to use > org.kde.plasma.components it&a=tree&h=

Re: Current state of System Monitor

2012-08-09 Thread Giorgos Tsiapaliokas
On 8 August 2012 16:13, Mark wrote: > My advice would be to use the current KDE Plasma ported components [1] Why to use those and not to use org.kde.plasma.components

Re: Current state of System Monitor

2012-08-08 Thread Mark
On Tue, Aug 7, 2012 at 12:55 PM, Dmitry wrote: > 07.08.2012 13:16, Marco Martin пишет: > >> On Tuesday 07 August 2012, Dmitry wrote: >>> >>> Hello! >>> >>> I'm working on my new system monitor applet. I hate current default C++ >>> app

Re: Current state of System Monitor

2012-08-07 Thread Dmitry
07.08.2012 13:16, Marco Martin пишет: On Tuesday 07 August 2012, Dmitry wrote: Hello! I'm working on my new system monitor applet. I hate current default C++ applet. So, I've decided to implement my simple system monitor in pure QML (no C++ code at all). At the same time I don't

Re: Current state of System Monitor

2012-08-07 Thread Shaun Reich
Uh.. I've had a wip from scratch QML2 version of the system monitors in a workspace branch for a long time now. Obviously it can't be used until Qt5 is out. It has more functionality than the current ones too. In the sense that it also has a bar graph visualization. ___

Re: Current state of System Monitor

2012-08-07 Thread Marco Martin
On Tuesday 07 August 2012, Dmitry wrote: > > Hello! > > I'm working on my new system monitor applet. I hate current default C++ > applet. So, I've decided to implement my simple system monitor in pure > QML (no C++ code at all). At the same time I don't know woul

Re: Current state of System Monitor

2012-08-07 Thread Dmitry
07.08.2012 12:25, Marco Martin пишет: On Tuesday 07 August 2012, Peter Hartmann wrote: Hello I'd like to inquire if QML port of System Monitor applet is in work or in plans for near future. There is only C++ code in repo, but revision history tells me that there were such attempts in the

Re: Current state of System Monitor

2012-08-07 Thread Marco Martin
On Tuesday 07 August 2012, Peter Hartmann wrote: > Hello > > I'd like to inquire if QML port of System Monitor applet is in work or > in plans for near future. There is only C++ code in repo, but revision > history tells me that there were such attempts in the past. Will &g

Current state of System Monitor

2012-08-06 Thread Peter Hartmann
Hello I'd like to inquire if QML port of System Monitor applet is in work or in plans for near future. There is only C++ code in repo, but revision history tells me that there were such attempts in the past. Will hypothetical patches won't be rejected on the basis of "major re

Re: Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" key

2012-06-29 Thread Commit Hook
org/r/105338/ > --- > > (Updated June 24, 2012, 7:39 a.m.) > > > Review request for Plasma and John Tapsell. > > > Description > --- > > Currently, ksysguard.desktop contains "Name=System Monitor" and

Re: Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" key

2012-06-28 Thread Aaron J. Seigo
ne 24, 2012, 7:39 a.m.) > > > Review request for Plasma and John Tapsell. > > > Description > --- > > Currently, ksysguard.desktop contains "Name=System Monitor" and > "GenericName=System Monitor". > > FOD specification[1] writes

Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" key

2012-06-24 Thread Jekyll Wu
--- Currently, ksysguard.desktop contains "Name=System Monitor" and "GenericName=System Monitor". FOD specification[1] writes: NameSpecific name of the application, for example "Mozilla". GenericName Generic name of the application, for example "Web Browser

Re: Review Request: A usable system monitor plasmoid

2012-02-19 Thread rhn rhn
18, 2012, 6:16 p.m.) > > > Review request for Plasma. > > > Description > --- > > A plasmoid intended to be used on a panel. Inspired by gnome-multiload-applet > and gkrellm. > > Before I decided to write this plasmoid, I considered other monitors. Here's >

Re: Review Request: A usable system monitor plasmoid

2012-02-19 Thread rhn rhn
l. Inspired by gnome-multiload-applet > and gkrellm. > > Before I decided to write this plasmoid, I considered other monitors. Here's > what I found: > - system-monitor: >* not pixel-perfect: it uses antialiasing and Bezier curves >* in stacking mode, it adds

Re: Review Request: A usable system monitor plasmoid

2012-02-19 Thread Aaron J. Seigo
Updated Feb. 18, 2012, 6:16 p.m.) > > > Review request for Plasma. > > > Description > --- > > A plasmoid intended to be used on a panel. Inspired by gnome-multiload-applet > and gkrellm. > > Before I decided to write this plasmoid, I considered o

Re: Review Request: A usable system monitor plasmoid

2012-02-19 Thread Aaron J. Seigo
; > (Updated Feb. 18, 2012, 6:16 p.m.) > > > Review request for Plasma. > > > Description > --- > > A plasmoid intended to be used on a panel. Inspired by gnome-multiload-applet > and gkrellm. > > Before I decided to write this plasmoid, I considered

Review Request: A usable system monitor plasmoid

2012-02-19 Thread rhn rhn
used on a panel. Inspired by gnome-multiload-applet and gkrellm. Before I decided to write this plasmoid, I considered other monitors. Here's what I found: - system-monitor: * not pixel-perfect: it uses antialiasing and Bezier curves * in stacking mode, it adds a few pixels to all v

Re: Review Request: Plasma HDD Activity/IO system monitor applet creation

2012-02-07 Thread Marco Martin
l of them derive from, so i will fix more of > that/those soon as well (i've already fixed quite a few of them). > > > Diffs > - > > plasma/generic/applets/system-monitor/CMakeLists.txt 0f74eb6 > plasma/generic/applets/system-monitor/hdd-activity-config.ui e641c8a >

Review Request: Plasma HDD Activity/IO system monitor applet creation

2012-02-05 Thread Shaun Reich
lated to this applet and the other applets, are due to the main base class that all of them derive from, so i will fix more of that/those soon as well (i've already fixed quite a few of them). Diffs ----- plasma/generic/applets/system-monitor/CMakeLists.txt 0f74eb6 plasma/generic/applet

Re: Plasma system monitor applets to QML?

2012-01-03 Thread Marco Martin
igured "okay, after I'm done with this...I'll have to rewrite > the system monitor applets to do something sane". > > But then I couldn't get the idea out of my head of porting these > applets to QML ;-) > > I noticed it's on the "To port to Q

Plasma system monitor applets to QML?

2012-01-02 Thread Shaun Reich
sources based on a Regular Expression, then recreates every visualization (== graph in the widget...and there can be n number of graphs in 1 widget). Anyone else find that silly? So I figured "okay, after I'm done with this...I'll have to rewrite the system monitor applets to do someth

Re: Review Request: Enabling "Apply" button in system-monitor

2011-02-15 Thread Marco Martin
gt; > > Review request for Plasma. > > > Summary > --- > > Enabling "Apply" buttons in system-monitor configuration dialog. It includes > cpu, hdd, net, ram and temperature plasmoids. > > > Diffs > - > > plasma/generic/ap

Re: Review Request: Enabling "Apply" button in system-monitor

2011-02-15 Thread Sinny Kumari
--- Forgot to add testing part. Summary --- Enabling "Apply" buttons in system-monitor configuration dialog. It includes cpu, hdd, net, ram and temperature plasmoids. Diffs - plasma/generic/applets/system-monitor/cpu.cpp f47402d plasma/generic/applets/system-monit

Review Request: Enabling "Apply" button in system-monitor

2011-02-15 Thread Sinny Kumari
buttons in system-monitor configuration dialog. It includes cpu, hdd, net, ram and temperature plasmoids. Diffs - plasma/generic/applets/system-monitor/cpu.cpp f47402d plasma/generic/applets/system-monitor/hdd.cpp 5b6985e plasma/generic/applets/system-monitor/net.cpp 7e38240 plas

Re: Review Request: bug fixes for the system-monitor applet

2010-10-01 Thread Aaron Seigo
ply, visit: > http://svn.reviewboard.kde.org/r/3950/ > --- > > (Updated 2010-05-14 08:21:03) > > > Review request for Plasma. > > > Summary > --- > > As my first work for KDE, I would like to add some powe

Re: Review Request: bug fixes for the system-monitor applet

2010-09-25 Thread Petri Damstén
d 2010-05-14 08:21:03) > > > Review request for Plasma. > > > Summary > --- > > As my first work for KDE, I would like to add some power management > monitoring features to the system-monitor applet. Monitoring the cpu clock > frequency when using the on-demand or the

Re: Review Request: bug fixes for the system-monitor applet

2010-09-24 Thread Beat Wolf
d 2010-05-14 08:21:03) > > > Review request for Plasma. > > > Summary > --- > > As my first work for KDE, I would like to add some power management > monitoring features to the system-monitor applet. Monitoring the cpu clock > frequency when using the on-demand or

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
> > (Updated 2010-05-14 08:21:03) > > > Review request for Plasma. > > > Summary > --- > > As my first work for KDE, I would like to add some power management > monitoring features to the system-monitor applet. Monitori

Re: Review Request: bug fixes for the system-monitor applet

2010-05-14 Thread Michel Lafon-Puyo
monitoring features to the system-monitor applet. Monitoring the cpu clock frequency when using the on-demand or the conservative governor could be useful (at least it is for me :)). Before going further in this development I tried to fix some little bugs with the applet. Here is the list of the

Re: Review Request: bug fixes for the system-monitor applet

2010-05-13 Thread Petri Damstén
On Thu, May 13, 2010 at 1:07 AM, Aaron Seigo wrote: Can't find reviewboard password from my laptop so commenting here... > a few minor coments below. the biggest issue now is that with your patch, the > icon for the drives in the disk monitor appear _below_ the meters rather than > beside them

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Aaron Seigo
patch, the icon for the drives in the disk monitor appear _below_ the meters rather than beside them. are you seeing this as well? /trunk/KDE/kdebase/workspace/plasma/generic/applets/system-monitor/applet.cpp <http://reviewboard.kde.org/r/3950/#comment5330> qDeleteAll(m_visualiz

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Michel Lafon-Puyo
ase. :) > > > > thanks for the patch, and welcome to KDE & Plasma hacking! Thank you very much :) > On 2010-05-11 17:20:41, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/system-monitor/applet.cpp, > > line 251 > > &l

Re: Review Request: bug fixes for the system-monitor applet

2010-05-12 Thread Michel Lafon-Puyo
would like to add some power management monitoring features to the system-monitor applet. Monitoring the cpu clock frequency when using the on-demand or the conservative governor could be useful (at least it is for me :)). Before going further in this development I tried to fix some little bu

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Aaron Seigo
ven't actually done any testing (have to run to a meeting now, actually ...) but i will do so later. there are some comments below, in any case. :) thanks for the patch, and welcome to KDE & Plasma hacking! /trunk/KDE/kdebase/workspace/plasma/generic/applets/system-monitor/ap

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Aaron Seigo
http://reviewboard.kde.org/r/3950/ > --- > > (Updated 2010-05-11 16:25:30) > > > Review request for Plasma. > > > Summary > --- > > As my first work for KDE, I would like to add some power

Re: Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Michel Lafon-Puyo
(updated) --- As my first work for KDE, I would like to add some power management monitoring features to the system-monitor applet. Monitoring the cpu clock frequency when using the on-demand or the conservative governor could be useful (at least it is for me :)). Before going further in this

Review Request: bug fixes for the system-monitor applet

2010-05-11 Thread Michel Lafon-Puyo
like to add some power management monitoring features to the system-monitor applet. Monitoring the cpu clock frequency when using the on-demand or the conservative governor could be useful (at least it is for me :)). Before going further in this development I tried to fix some little bugs with

  1   2   >