----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/#review43126 -----------------------------------------------------------
Ship it! I still think it'd be preferrable to rewrite System Monitor's config handling to follow the usual configAccepted/configChanged pattern, which would then also force the issue of writing a fully-efficient configChanged() that only applies the diff to the previous state, but in lieu of that, this would seem to fix the observable problems with the current approach at least. - Eike Hein On Nov. 5, 2013, 10:34 p.m., Sergei Lopatin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113659/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 10:34 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: kde-workspace > > > Description > ------- > > Added ability to system-monitor plasmoid to set configuration from js code. > Something like this: > a = activityForScreen(0) > if (a) { > var applet = a.addWidget("system-monitor_applet") > applet.writeConfig("applets", "sm_ram,sm_cpu") > } > > > Diffs > ----- > > plasma/generic/applets/system-monitor/ram.cpp 5805e68 > plasma/generic/applets/system-monitor/system-monitor.h f8a2975 > plasma/generic/applets/system-monitor/system-monitor.cpp 1705a99 > > Diff: http://git.reviewboard.kde.org/r/113659/diff/ > > > Testing > ------- > > > Thanks, > > Sergei Lopatin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
