broulik added a comment.

  > The call on line 141 looks superfluous - if there's any change to checked 
we modify cfg_sources which should trigger the reload.
  
  QML cannot detect changes within a JS structure, if you `push()` into an 
`Array` or modify members of an `Object` it doesn't see the change and the 
automatism for `onCfg_...Changed` doesn't trigger

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

Reply via email to