----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105338/ -----------------------------------------------------------
Review request for Plasma and John Tapsell. Description ------- Currently, ksysguard.desktop contains "Name=System Monitor" and "GenericName=System Monitor". FOD specification[1] writes: Name Specific name of the application, for example "Mozilla". GenericName Generic name of the application, for example "Web Browser". So I think using a generic name like "System Monitor" for "Name" is problematic. The current situation of using the same generic name for both "Name" and "GenericName" is also questionable. The patch simply uses "KSysGuard" for the "Name" key . [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys Diffs ----- ksysguard/gui/ksysguard.desktop 7e8ff32 Diff: http://git.reviewboard.kde.org/r/105338/diff/ Testing ------- Thanks, Jekyll Wu
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel