Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- (Updated Aug. 15, 2016, 1:34 p.m.) Status -- This change has been ma

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98401 --- Fix it, then Ship it! src/declarativeimports/plasmacompon

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- (Updated Aug. 15, 2016, 11:22 a.m.) Review request for KDE Frameworks and

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98397 --- src/declarativeimports/plasmastyle/TextFieldStyle.qml (line

Re: Review Request 128660: Add an optional reveal password button to TextField

> On Aug. 15, 2016, 10:52 vorm., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmastyle/TextFieldStyle.qml, line 80 > > > > > > Don't add units.smallSpacing if there's no actions, the padding is now > > un

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98396 --- src/declarativeimports/plasmacomponents/qml/TextField.qml (l

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- (Updated Aug. 14, 2016, 10:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98328 --- Sorry, found two issues. src/declarativeimports/plasmacompo

Re: Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98326 --- Fix it, then Ship it! Neat. Some minor nitpicks below. A

Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor