----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98328 -----------------------------------------------------------
Sorry, found two issues. src/declarativeimports/plasmacomponents/qml/TextField.qml (line 45) <https://git.reviewboard.kde.org/r/128660/#comment66253> Add @since src/declarativeimports/plasmastyle/TextFieldStyle.qml (line 70) <https://git.reviewboard.kde.org/r/128660/#comment66254> The +6 is wrong here, it doesn't needs to be added only once (not multipplied by the button count below) src/declarativeimports/plasmastyle/TextFieldStyle.qml (line 74) <https://git.reviewboard.kde.org/r/128660/#comment66255> Here you need the +6 and the units.smallSpacing is wrong, I think. At least with two buttons the padding on the right is wrong here. - Kai Uwe Broulik On Aug. 12, 2016, 12:36 vorm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128660/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 12:36 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Similar to KPasswordWidget in kwidgetaddons > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextField.qml > c0d9155df5bb584cd3070a66c99d98465b81a5ef > src/declarativeimports/plasmastyle/TextFieldStyle.qml > 05ff3d542ad0de6879ec1de832b5e5d9ed33281e > tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 > > Diff: https://git.reviewboard.kde.org/r/128660/diff/ > > > Testing > ------- > > Updated manual test. See screenshot. > > > File Attachments > ---------------- > > Spectacle.B12253.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png > > > Thanks, > > David Edmundson > >
