----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98326 -----------------------------------------------------------
Fix it, then Ship it! Neat. Some minor nitpicks below. And thanks for already incorporating the fixes of Reviews 128551 and 128549 which I forgot about :) src/declarativeimports/plasmacomponents/qml/TextField.qml (line 85) <https://git.reviewboard.kde.org/r/128660/#comment66245> Hardcoded pixel size (hm was there before, so..) src/declarativeimports/plasmacomponents/qml/TextField.qml (line 88) <https://git.reviewboard.kde.org/r/128660/#comment66246> That is the default for Row, only RowLayout has a default spacing src/declarativeimports/plasmacomponents/qml/TextField.qml (line 92) <https://git.reviewboard.kde.org/r/128660/#comment66247> === src/declarativeimports/plasmastyle/TextFieldStyle.qml (line 70) <https://git.reviewboard.kde.org/r/128660/#comment66251> Coding style, add spaces src/declarativeimports/plasmastyle/TextFieldStyle.qml (line 71) <https://git.reviewboard.kde.org/r/128660/#comment66249> Could be simplified to var actionCount = control.clearButtonShown + control.revealPasswordButtonShown tests/components/textfield.qml (line 37) <https://git.reviewboard.kde.org/r/128660/#comment66250> Two empty lines - Kai Uwe Broulik On Aug. 12, 2016, 12:36 vorm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128660/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 12:36 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Similar to KPasswordWidget in kwidgetaddons > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextField.qml > c0d9155df5bb584cd3070a66c99d98465b81a5ef > src/declarativeimports/plasmastyle/TextFieldStyle.qml > 05ff3d542ad0de6879ec1de832b5e5d9ed33281e > tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 > > Diff: https://git.reviewboard.kde.org/r/128660/diff/ > > > Testing > ------- > > Updated manual test. See screenshot. > > > File Attachments > ---------------- > > Spectacle.B12253.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png > > > Thanks, > > David Edmundson > >
