----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98401 -----------------------------------------------------------
Fix it, then Ship it! src/declarativeimports/plasmacomponents/qml/TextField.qml (line 113) <https://git.reviewboard.kde.org/r/128660/#comment66289> This always confuses me but: the LTR or RTL suffix does NOT indicate the writing direction but the direction of the arrow (ie. it's vice-versa as you would think it is). That Breeze uses the same icon for both doesn't help with this, of course, so should be: source: LayoutMirroring.enabled ? "edit-clear-locationbar-ltr" : "edit-clear-locationbar-rtl" http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Actions-edit-clear-locationbar-ltr-icon.html ? that's the mirrored one with "ltr" suffix - Kai Uwe Broulik On Aug. 15, 2016, 11:22 vorm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128660/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 11:22 vorm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Similar to KPasswordWidget in kwidgetaddons > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextField.qml > c0d9155df5bb584cd3070a66c99d98465b81a5ef > src/declarativeimports/plasmastyle/TextFieldStyle.qml > 05ff3d542ad0de6879ec1de832b5e5d9ed33281e > tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 > > Diff: https://git.reviewboard.kde.org/r/128660/diff/ > > > Testing > ------- > > Updated manual test. See screenshot. > > > File Attachments > ---------------- > > Spectacle.B12253.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png > > > Thanks, > > David Edmundson > >
