Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 5:25 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 119 > > > > > > What was the point of this layout, there's only one item in it? nevermind, I got con

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65237 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Status -- This change has been ma

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 4:11 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 167 > > > > > > does it not work to do > > visible: keystateSource.data["Caps Lock"]["Locked"] >

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 2:04 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 178 > > > > > > Does that work? Shouldn't it be dataChanged() ? both work, this calls the slot, your

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 2:11 p.m.) Review request for Plasma and Andrew L

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 --- Ship it! Nice lookandfeel/contents/lockscreen/LockScreen.qm

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65208 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:39 p.m.) Review request for Plasma. Changes -

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 18, 2014, 2:24 p.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > > > > > I don't see who is setting the value for capsLockOn, did I miss > > something? > >

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 18, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > > > > > I don't see who is setting the value for capsLockOn, did I miss > > something? > >

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repositor

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 63 > > > > > > units.largeSpacing * 15 > > > > Nonetheless, that looks wrong to me, don't we

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:19 p.m.) Review request for Plasma. Changes -

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 18, 2014, 8:55 vorm., Martin Klapetek wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 162 > > > > > > Thinking about the label... > > > > What if we'd remove the "Warning: " par

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64713 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, lines 166-167 > > > > > > So you tell it to be centered horizontally, and wrap, but a maximum of > > one

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64587 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 15, 2014, 12:25 a.m.) Review request for Plasma. Reposito

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64580 --- lookandfeel/contents/components/UserSelect.qml

Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- Review request for Plasma. Repository: plasma-workspace Description ---