> On Aug. 18, 2014, 2:24 p.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > <https://git.reviewboard.kde.org/r/119797/diff/4/?file=306152#file306152line32> > > > > I don't see who is setting the value for capsLockOn, did I miss > > something? > > > > Also this could be an alias to the label visible property. > > Dan Vrátil wrote: > This property is set by UnlockApp in > ksmserver/screenlocker/greeter/greeterapp.cpp on l383 - the code for capslock > state detection has already been there (brough in from KDE 4), we were just > not making use of the property in QML. > > Should I add a comment where this is comming from?
Well, this code is being used by the SDDM theme as well, so making it into a proper QML component would make sense, I'd say. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 ----------------------------------------------------------- On Aug. 18, 2014, 2:21 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119797/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 2:21 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This will show a warning when capslock is enabled, like it used to in KDE 4 > screen locker. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 > lookandfeel/contents/components/UserSelect.qml 7b605b1 > > Diff: https://git.reviewboard.kde.org/r/119797/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
