> On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, lines 166-167 > > <https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line166> > > > > So you tell it to be centered horizontally, and wrap, but a maximum of > > one line is allowed? This will have no effect whatsoever since the label > > will just grow outside horizontally because it has no width/side anchors > > set.
Just copy-pasted from the notificationLabel above :-) > On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 32 > > <https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line32> > > > > You generally don't need semicolons after QML properties Sorry, habit of a C++ programmer - punch semicolon after every line :) > On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 63 > > <https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line63> > > > > units.largeSpacing * 15 > > > > Nonetheless, that looks wrong to me, don't we have gridUnit for stuff > > like that? This actually represents the height of the actual content block - I'm not sure we can/want to use some generic value for that. I think in ideal case the height of the element should be based on total height of the elements it contains - I'm not sure why this is not the case but I'll try to do it that way first. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64587 ----------------------------------------------------------- On Aug. 15, 2014, 12:25 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119797/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 12:25 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This will show a warning when capslock is enabled, like it used to in KDE 4 > screen locker. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 > lookandfeel/contents/components/UserSelect.qml 7b605b1 > > Diff: https://git.reviewboard.kde.org/r/119797/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
