----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64713 -----------------------------------------------------------
lookandfeel/contents/lockscreen/LockScreen.qml <https://git.reviewboard.kde.org/r/119797/#comment45266> Thinking about the label... What if we'd remove the "Warning: " part and either just leave it like that or make the font red? My reasoning being that a text suddenly appearing is enough to notice and therefore the "warning" part is not necessary. If the purpose of the "Warning" is to catch user's attention, this could be done as well by the red color with the advantage of less words needed to read and red color generally meaning "warning/attention". Oh and the "!" at the end should go, somewhere there is a guideline saying "don't make screaming interfaces" ;) - Martin Klapetek On Aug. 15, 2014, 12:25 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119797/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 12:25 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This will show a warning when capslock is enabled, like it used to in KDE 4 > screen locker. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 > lookandfeel/contents/components/UserSelect.qml 7b605b1 > > Diff: https://git.reviewboard.kde.org/r/119797/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
