Re: Wallpaper class; API review requested

2008-08-13 Thread Kevin Ottens
Le Wednesday 13 August 2008, Aaron J. Seigo a écrit : > the point that might be missing here is that the wallpaper plugin is > internal to the containment. it's not meant to be some external item. it's > simple something that can be defined by external users of containment > ("please use wallpaper

Re: Wallpaper class; API review requested

2008-08-13 Thread Petri Damstén
On Wednesday 13 August 2008 15:44:50 Aaron J. Seigo wrote: > alternately, a load and save method set could be added that take a > KConfigGroup& and call that from the appropriate places in the config > dialog and/or containment. i actually like that better as it means that it > keeps the coupling l

Re: Wallpaper class; API review requested

2008-08-13 Thread Aaron J. Seigo
On Wednesday 13 August 2008, Petri Damstén wrote: > - Should wallpaper plugin rely on that parent in > createConfigurationInterface has applyClicked() and okClicked() signals > like applets do? yes, i think so. > - Should the wallpaper plugin configuration be containment specific (I > think yes.

Re: Wallpaper class; API review requested

2008-08-13 Thread Petri Damstén
On Monday 11 August 2008 16:31:11 Kevin Ottens wrote: > * Depending on what we figure out regarding what the modes are, it might > be worth it to have a small "WallpaperMode" class (it holds already three > properties, and could grow). Now that I have learned how Actions work in desktop file I th

Re: Wallpaper class; API review requested

2008-08-13 Thread Aaron J. Seigo
On Wednesday 13 August 2008, Kevin Ottens wrote: > Le Wednesday 13 August 2008, Aaron J. Seigo a écrit : > > On Wednesday 13 August 2008, Kevin Ottens wrote: > > > Le Tuesday 12 August 2008, Aaron J. Seigo a écrit : > > > > ownership of the Wallpaper* would then be taken by the Containment in > > >

Re: Wallpaper class; API review requested

2008-08-13 Thread Kevin Ottens
Le Wednesday 13 August 2008, Aaron J. Seigo a écrit : > On Wednesday 13 August 2008, Kevin Ottens wrote: > > Le Tuesday 12 August 2008, Aaron J. Seigo a écrit : > > > ownership of the Wallpaper* would then be taken by the Containment in > > > this case; > > > > Is that required? > > no; but then it

Re: Wallpaper class; API review requested

2008-08-13 Thread Aaron J. Seigo
On Wednesday 13 August 2008, Kevin Ottens wrote: > Le Tuesday 12 August 2008, Aaron J. Seigo a écrit : > > On Monday 11 August 2008, Kevin Ottens wrote: > > > Hello, > > > > > > Same dumb method as usual from me. > > > > > > Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > > > > the affected c

Re: Wallpaper class; API review requested

2008-08-13 Thread Kevin Ottens
Le Tuesday 12 August 2008, Aaron J. Seigo a écrit : > On Monday 11 August 2008, Kevin Ottens wrote: > > Hello, > > > > Same dumb method as usual from me. > > > > Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > > > the affected classes are Containment, with a setter and getter for the > > > wa

Re: Wallpaper class; API review requested

2008-08-12 Thread Aaron J. Seigo
On Monday 11 August 2008, Kevin Ottens wrote: > Hello, > > Same dumb method as usual from me. > > Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > > the affected classes are Containment, with a setter and getter for the > > wallpaper > > I'd probably add a setWallpaper(Wallpaper*) so that the

Re: Wallpaper class; API review requested

2008-08-11 Thread Kevin Ottens
Hello, Same dumb method as usual from me. Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > the affected classes are Containment, with a setter and getter for the > wallpaper I'd probably add a setWallpaper(Wallpaper*) so that the setter/getter couple becomes symetric with an extra convenie