On Wednesday 13 August 2008, Kevin Ottens wrote: > Le Tuesday 12 August 2008, Aaron J. Seigo a écrit : > > On Monday 11 August 2008, Kevin Ottens wrote: > > > Hello, > > > > > > Same dumb method as usual from me. > > > > > > Le Tuesday 05 August 2008, Aaron J. Seigo a écrit : > > > > the affected classes are Containment, with a setter and getter for > > > > the wallpaper > > > > > > I'd probably add a setWallpaper(Wallpaper*) so that the setter/getter > > > couple becomes symetric with an extra convenience version (the one > > > doing the load for you). > > > > ownership of the Wallpaper* would then be taken by the Containment in > > this case; > > Is that required?
no; but then it's another connect-to-destroyed(QObject*) bit of code. > > our current wallpaper renderer does Single Image, Slideshow and Plain > > Color. so, three different modes. > > Gotcha. What about RenderingMode? Just "mode" doesn't convey enough > information to me. works for me. > > > * Depending on what we figure out regarding what the modes are, it > > > might be worth it to have a small "WallpaperMode" class (it holds > > > already three properties, and could grow). > > > > which 3 properties? > > /me looks at his hand again. > OK, I can't count it seems, the 2 properties so that obviously less of a > problem *for now*. Could that grow? I've a hard time figuring out if it's > likely or not... But somehow I clearly imagine that modes could have more > information attached to them, for instance "is it animated?", for decision i think that would be internal to the wallpaper and not exposed. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Trolltech
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
